Spike on admin resource sorting #2728
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorting will be handled in memory by a custom implementation
Accept a sort key on the object passed to on store.query() which returns the results sorted in-memory
By default store.query({ sort }) will expect the sort object to have an
attribute specified based on attributes defined by the model. The
sorting will actually happen on "keys" in the json api formatted
"attributes" object, which might contain keys that are not defined as
attr() on the model. This is true for the current default sort of
created_time. Making this distinction will help avoid querying on
insider json api attributes from the payload without a refactor or
some explicit handling. In the case of "created_time", it is identified
as a "universally sortable key" for all models in the code but
currently is not exposed as an option that can be passed via { sort }
since it's the current default.
Use ascending as the default sort direction except in the case that created_time is used in which case to match the existing default behavior it should be descending
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…and sortAttrbute, not custom sort function yet
Collaborator
Author
|
Spike has served its purpose and will be used as an example for the upcoming implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots (if appropriate)
How to Test
Checklist