-
Notifications
You must be signed in to change notification settings - Fork 33
Upgrade ember-electron from 4.2.2 to 6.0.0 #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hashicc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the ember-electron changelog I agree it looks safe. Also I think the other @electron-forge/* have already been merged here, so this PR is really just ember-electron.
|
Thaks for the feedback. That is correct, this PR initially was a branch from the electron-forge upgrade, now pointing to main, Since electron-forge changes have been merged. Still working on a blocking issue, that's why marked as draft, will update the PR as soon I unblock 😉 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reproducing some issues and debugging
What were the issues? Considering we were already on 4.12, I'm curious what the problems were
|
My apologie, rather than answering your comment I click "Edit" and answer within your own comment. I corrected that and now a propper answer: The test finishes but not the process that runs it. In local test, test process keeps running infinetely, until you manually stops it. In CI it times out. I didn't digg that much to indentify the cause of the issue tho. My findings are:
Open to discuss this further if need. |
DhariniJeeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thanks for the upgrade!
Description
Upgrade ember-electron from
4.2.2to6.0.0. In preparation for electron upgradeAs per changelog, it is safe to upgrade.
🎟️ Jira ticket
UPDATE: We change the goal from
ember-electronv7 to v6. After reproducing some issues and debugging,ember-electronv7 does not support ember < 4.8 and we are using ember 4.12. So for pragmatism we decided to upgrade to 6. Once the ember upgrade is complete, we will review this dependency.How to Test