-
Notifications
You must be signed in to change notification settings - Fork 33
feat: Conditionally display 'Check for Updates' menu item based on built-in CLI #2754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Conditionally display 'Check for Updates' menu item based on built-in CLI #2754
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
6c28896 to
8ae6081
Compare
ZedLi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the fix and first PR!
cameronperera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
calcaide
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!! thanks for the work 🙌
DhariniJeeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and congrats on the first PR! 🎉
priya-patel04
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix with first PR! 🥳
lisbet-alvarez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work & awesome first PR!
hashicc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 thanks for the fix!
8ae6081 to
6984594
Compare
…te-menu-when-cli-not-installed
Description
This change ensures that the "Check for Updates" menu is only displayed if the CLI exists.
🎟️ Jira ticket
Screenshots
Before Changes:

After Changes:

How to Test
As mentioned, the "Check for Updates" menu will only be visible if the built-in CLI is included.
The CLI is included based on the build command. By default, the CLI is not included. To include the CLI, use the following command:
SETUP_CLI=true yarn build:desktopAfter building, navigate to the build folder and run the Boundary app from the following location:
<your_repo_path>/boundary-ui/ui/desktop/electron-app/out/Boundary-darwin-arm64/Boundary.appThe CLI folder can be found at:
<your_repo_path>/boundary-ui/ui/desktop/electron-app/out/Boundary-darwin-arm64/Boundary.app/Contents/ResourcesThe "Check for Updates" button will appear when the CLI folder exists. If the folder is missing, the button will not be visible. There are two ways to remove the CLI folder:
yarn build:desktopChecklist
I have added JSON response output for API changesI have added tests that prove my fix is effective or that my feature works