Skip to content

Conversation

@sohail-hashicorp
Copy link
Collaborator

Description

This change ensures that the "Check for Updates" menu is only displayed if the CLI exists.

🎟️ Jira ticket

Screenshots

Before Changes:
image

After Changes:
image

How to Test

As mentioned, the "Check for Updates" menu will only be visible if the built-in CLI is included.

The CLI is included based on the build command. By default, the CLI is not included. To include the CLI, use the following command:
SETUP_CLI=true yarn build:desktop

After building, navigate to the build folder and run the Boundary app from the following location:
<your_repo_path>/boundary-ui/ui/desktop/electron-app/out/Boundary-darwin-arm64/Boundary.app

The CLI folder can be found at:

<your_repo_path>/boundary-ui/ui/desktop/electron-app/out/Boundary-darwin-arm64/Boundary.app/Contents/Resources

The "Check for Updates" button will appear when the CLI folder exists. If the folder is missing, the button will not be visible. There are two ways to remove the CLI folder:

  1. Exclude the CLI during the build process by running the following command: yarn build:desktop
  2. Manually delete the CLI folder if it exists. Afterward, quit and restart the application to see the changes.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sohail-hashicorp sohail-hashicorp requested a review from a team as a code owner March 28, 2025 03:56
@vercel
Copy link

vercel bot commented Mar 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 2:46pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2025 2:46pm

@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Mar 28, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the fix and first PR!

Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!! thanks for the work 🙌

Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and congrats on the first PR! 🎉

Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix with first PR! 🥳

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work & awesome first PR!

Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for the fix!

@calcaide calcaide merged commit 0fcd58c into main Apr 10, 2025
21 checks passed
@calcaide calcaide deleted the ICU-15297/remove-update-menu-when-cli-not-installed branch April 10, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants