Skip to content

[Replace] Rose::Button in ui/admin #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laurenolivia merged 6 commits into from
Apr 22, 2025
Merged

[Replace] Rose::Button in ui/admin #2771

laurenolivia merged 6 commits into from
Apr 22, 2025

Conversation

@laurenolivia
Copy link
Contributor

@laurenolivia laurenolivia commented Apr 10, 2025

Description

This PR replaces instances of Rose::Button with Hds::Button.

Screenshots (if appropriate)

How to Test

  1. Verify the buttons across ui/admin and ui/desktop

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@laurenolivia laurenolivia requested a review from a team as a code owner April 10, 2025 22:37
@vercel
Copy link

vercel bot commented Apr 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 5:19pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 5:19pm

@laurenolivia laurenolivia marked this pull request as draft April 10, 2025 22:38
laurenolivia
laurenolivia commented Apr 11, 2025
View reviewed changes
laurenolivia
laurenolivia commented Apr 11, 2025
View reviewed changes
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-btn-with-hds-btn branch from fedadbe to 306c564 Compare April 11, 2025 14:59
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-btn-with-hds-btn branch 2 times, most recently from e60f897 to 61e4844 Compare April 11, 2025 15:11
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-btn-with-hds-btn branch from 61e4844 to 63187c2 Compare April 14, 2025 16:47
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-btn-with-hds-btn branch from 37aa919 to d254412 Compare April 15, 2025 15:06
@laurenolivia laurenolivia marked this pull request as ready for review April 15, 2025 17:59
priya-patel04
priya-patel04 previously approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@priya-patel04 priya-patel04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the changes! Looks great!! 🎊

@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-btn-with-hds-btn branch from 9e39cc0 to 1432894 Compare April 18, 2025 20:56
hashicc
hashicc previously approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@laurenolivia laurenolivia dismissed stale reviews from hashicc and priya-patel04 via c99e4a9 April 22, 2025 17:06
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-btn-with-hds-btn branch from 1432894 to c99e4a9 Compare April 22, 2025 17:06
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-btn-with-hds-btn branch 2 times, most recently from 464c494 to 90122f5 Compare April 22, 2025 17:14
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-btn-with-hds-btn branch from 90122f5 to 5894c08 Compare April 22, 2025 17:15
DhariniJeeva
DhariniJeeva approved these changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks for getting the buttons migrated 🎉

@laurenolivia laurenolivia removed the request for review from calcaide April 22, 2025 20:24
@laurenolivia laurenolivia merged commit 36db2d3 into main Apr 22, 2025
13 checks passed
@laurenolivia laurenolivia deleted the laurenolivia/replace-rose-btn-with-hds-btn branch April 22, 2025 20:25
@laurenolivia laurenolivia changed the title Replace Rose::Button with Hds::Button [Replace] Rose::Button in ui/admin Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DhariniJeeva DhariniJeeva DhariniJeeva approved these changes

@hashicc hashicc hashicc left review comments

@priya-patel04 priya-patel04 priya-patel04 left review comments

+1 more reviewer

@calcaide calcaide calcaide left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

addons admin desktop styles-addon ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@laurenolivia @calcaide @DhariniJeeva @hashicc @priya-patel04