refactor: 💡 update text span elements with Hds::Text::Body #2779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cameronperera
commented
Apr 16, 2025
cameronperera
commented
Apr 16, 2025
cameronperera
commented
Apr 16, 2025
priya-patel04
approved these changes
Apr 17, 2025
Collaborator
priya-patel04
left a comment
priya-patel04
left a comment
There was a problem hiding this comment.
Looks great! 🚀
lisbet-alvarez
approved these changes
Apr 21, 2025
Collaborator
lisbet-alvarez
left a comment
lisbet-alvarez
left a comment
There was a problem hiding this comment.
Awesome!! Looks great!
cameronperera
deleted the
ICU-16864-foundation-components-replace-span-with-hds-text
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-16864
Description
Update text span elements with Hds::Text::Body
We will have
spanelements throughout our codebase but all spans that were purely used for containing text have been updated.Screenshots (if appropriate)
OrderedSeriesDiagram:
Hidden Secret:
I used the
disabledcolor here. This is the closest color that still fits within the Hds::Text::Body specifications. We can specify our own color but I am not sure this instance justifies using something other than the standard colors. Happy to discuss.How to Test
All of these changes are pretty much exactly the same as before, outside of the HiddenSecret component (see comment above). You just need to click around in Vercel to see the changes.
Checklist