Icu 16722 interaction components replace rose dropdown with hds dropdown #2780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-dropdown-with-hds-dropdown
…e-dropdown-with-hds-dropdown
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Author
|
note: This is getting merged into llb since there are quite a bit of changes around this migration and I wanted to keep the PRs simply enough to review. I will also be running e2e tests and fix if anything's broken |
DhariniJeeva
commented
Apr 16, 2025
cameronperera
previously approved these changes
Apr 22, 2025
Collaborator
cameronperera
left a comment
cameronperera
left a comment
There was a problem hiding this comment.
LGTM and we were able to remove more instances of resourceFilter!
priya-patel04
previously approved these changes
Apr 22, 2025
Collaborator
priya-patel04
left a comment
priya-patel04
left a comment
There was a problem hiding this comment.
Tested locally and looks great! 🎉
3 tasks
lisbet-alvarez
previously approved these changes
Apr 23, 2025
Collaborator
lisbet-alvarez
left a comment
lisbet-alvarez
left a comment
There was a problem hiding this comment.
Awesome work!! Looks great!
ui/admin/app/controllers/scopes/scope/groups/group/add-members.js
Outdated
Show resolved
Hide resolved
4 tasks
DhariniJeeva
dismissed stale reviews from lisbet-alvarez, laurenolivia, priya-patel04, and cameronperera
via
96fba6a
…e-dropdown-with-hds-dropdown
DhariniJeeva
requested review from
cameronperera,
laurenolivia,
lisbet-alvarez and
priya-patel04
lisbet-alvarez
approved these changes
Apr 24, 2025
priya-patel04
approved these changes
Apr 24, 2025
cameronperera
approved these changes
Apr 24, 2025
DhariniJeeva
deleted the
ICU-16722-interaction-components-replace-rose-dropdown-with-hds-dropdown
branch
DhariniJeeva
added a commit
that referenced
this pull request
Apr 28, 2025
DhariniJeeva
added a commit
that referenced
this pull request
Apr 29, 2025
DhariniJeeva
added a commit
that referenced
this pull request
May 9, 2025
4 tasks
DhariniJeeva
added a commit
that referenced
this pull request
May 13, 2025
DhariniJeeva
added a commit
that referenced
this pull request
May 13, 2025
DhariniJeeva
added a commit
that referenced
this pull request
May 14, 2025
DhariniJeeva
added a commit
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: this PR covers only a portion of the dropdown migration, I will be handling the worker tags and the desktop in a separate PR to keep this one moderately simple.
what is covered:
what's not covered:
https://hashicorp.atlassian.net/browse/ICU-16722
Screenshots (if appropriate)
before:
after:
members:
before:
after:
principals:
before:
after:
How to Test
Checklist
[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description