Icu 16542 upgrade ember addons rose #2784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lisbet-alvarez
commented
Apr 21, 2025
lisbet-alvarez
commented
Apr 21, 2025
lisbet-alvarez
commented
Apr 21, 2025
lisbet-alvarez
commented
Apr 21, 2025
lisbet-alvarez
commented
Apr 21, 2025
lisbet-alvarez
commented
Apr 21, 2025
calcaide
reviewed
Apr 22, 2025
hashicc
reviewed
Apr 25, 2025
hashicc
previously approved these changes
Apr 25, 2025
Collaborator
hashicc
left a comment
hashicc
left a comment
There was a problem hiding this comment.
💯 And simplifies the yarn lock file greatly. Looking forward to seeing all these ember changes land
lisbet-alvarez
force-pushed
the
ICU-16542-upgrade-ember-addons-rose
branch
from
da40bdc to
e3969f5
Compare
lisbet-alvarez
commented
Apr 25, 2025
calcaide
reviewed
Apr 30, 2025
calcaide
previously approved these changes
Apr 30, 2025
Contributor
calcaide
left a comment
calcaide
left a comment
There was a problem hiding this comment.
Run the unit test, e2e test, linter, formatter and everything else successfully like a champ. Amazing hard work Lis!! 💪 💃 one more step for Ember upgrade 🥳
ZedLi
approved these changes
May 1, 2025
Collaborator
ZedLi
left a comment
ZedLi
left a comment
There was a problem hiding this comment.
Looks great, thanks for the upgrade!
calcaide
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ember-cli-updateember init🎟️ Jira ticket
How to Test
Desktop Releases Test Run
Checklist