Skip to content

Credential Library - Create #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gsusmi merged 14 commits into from
Jul 23, 2021
Merged

Credential Library - Create #647

gsusmi merged 14 commits into from
Jul 23, 2021

Conversation

@gsusmi
Copy link
Collaborator

@gsusmi gsusmi commented Jul 18, 2021

Screen Shot 2021-07-18 at 14 30 51

@vercel
Copy link

vercel bot commented Jul 18, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

boundary-ui – ./ui/admin

🔍 Inspect: https://vercel.com/hashicorp/boundary-ui/BnErXWoc7PqtFXeujJ62P44jZsUr
✅ Preview: https://boundary-ui-git-credential-library-create-hashicorp.vercel.app

boundary-ui-storybook – ./addons/rose

🔍 Inspect: https://vercel.com/hashicorp/boundary-ui-storybook/5wQPPTncs8qXrgHuQdpsSmfuheAT
✅ Preview: https://boundary-ui-storybook-git-credential-library-create-hashicorp.vercel.app

boundary-ui-desktop – ./ui/desktop

🔍 Inspect: https://vercel.com/hashicorp/boundary-ui-desktop/BNQVeLX7oYgMvzUdivrMPsASkYmJ
✅ Preview: https://boundary-ui-desktop-git-credential-library-create-hashicorp.vercel.app

ghost
ghost suggested changes Jul 20, 2021
View reviewed changes
ghost
ghost suggested changes Jul 20, 2021
View reviewed changes
@calcaide
Copy link
Contributor

calcaide commented Jul 22, 2021

I know this is a draft and you already have it plan, but before moving from draft to ready, a rebase with main might be need since I merged changes recently in some of the credential-store routes and templates.

Nice work!! 🥳

@gsusmi
Copy link
Collaborator Author

gsusmi commented Jul 22, 2021

credential-library-error-handling

Radiobutton group component doesn't support error handling yet. Will introduce this in a future PR onto Rose addon.

@gsusmi gsusmi marked this pull request as ready for review July 22, 2021 21:57
@gsusmi gsusmi changed the title [draft] Credential library create Credential Library - Create Jul 22, 2021
@gsusmi gsusmi requested review from a user, DhariniJeeva and calcaide July 22, 2021 21:57
calcaide
calcaide approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Awesome job

@gsusmi gsusmi merged commit b1614dc into main Jul 23, 2021
@gsusmi gsusmi deleted the credential-library-create branch July 23, 2021 17:08
DhariniJeeva pushed a commit that referenced this pull request Sep 3, 2025
@hc-github-team-secure-boundary
Merge pull request #647 from hashicorp/oss/merge-main-8e40b01cafcfa44…
9aadc8c 
…cd398ab856eaa467f059b63fb

[main] OSS to ENT merge of (8e40b01)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DhariniJeeva DhariniJeeva Awaiting requested review from DhariniJeeva

2 more reviewers

@calcaide calcaide calcaide approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

addons admin api-addon styles-addon ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsusmi @calcaide @DhariniJeeva