-
Notifications
You must be signed in to change notification settings - Fork 50
Website: add @hasStickyFirstColumn to Advanced Table code docs
#2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9a89516 to
796934a
Compare
dchyun
reviewed
Mar 31, 2025
website/docs/components/table/advanced-table/partials/specifications/sticky-column.md
Show resolved
Hide resolved
f912e6a to
8067320
Compare
heatherlarsen
previously approved these changes
Apr 1, 2025
Contributor
heatherlarsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorytindall I left a few suggestions to simplify, but overall, this looks great.
website/docs/components/table/advanced-table/partials/specifications/sticky-column.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/specifications/sticky-column.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/specifications/sticky-column.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/specifications/sticky-column.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/specifications/sticky-column.md
Outdated
Show resolved
Hide resolved
dchyun
reviewed
Apr 1, 2025
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Show resolved
Hide resolved
8067320 to
b0202c3
Compare
…moved/rewrote the content for the stickky header.
Simplify and use more plain language. Co-authored-by: Heather Larsen <hlarsen@hashicorp.com>
804721e to
bf9df98
Compare
…-to-use.md Co-authored-by: Dylan Hyun <dylan.hyun@hashicorp.com>
dchyun
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will add code documentation for the Advanced Table sticky column.
PREVIEW
📸 Screenshots
🔗 External links
Jira ticket: HDS-4583
💬 Please consider using conventional comments when reviewing this PR.