Skip to content

chore(showcase): eslint & prettier #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aklkv merged 1 commit into from
May 20, 2025
Merged

chore(showcase): eslint & prettier #2810

aklkv merged 1 commit into from
May 20, 2025

Conversation

@aklkv
Copy link
Collaborator

@aklkv aklkv commented Apr 3, 2025 •
edited by didoo
Loading

📌 Summary

  • add latest eslint and prettier setup
  • bump pnpm

🛠️ Detailed description

📸 Screenshots

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]

👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@aklkv aklkv self-assigned this Apr 3, 2025
@vercel
Copy link

vercel bot commented Apr 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview May 20, 2025 5:56am
hds-website ✅ Ready (Inspect) Visit Preview May 20, 2025 5:56am

@aklkv aklkv changed the title chore: eslint & prettier for apps chore(showcase): eslint & prettier Apr 14, 2025
@aklkv aklkv marked this pull request as ready for review April 14, 2025 15:42
@aklkv aklkv requested a review from a team as a code owner April 14, 2025 15:42
@didoo
Copy link
Contributor

didoo commented Apr 14, 2025 •
edited
Loading

As mentioned in another PR/comment, I strongly think we need to find a way to isolate the changes to the CSS files and have another tool to do the linting for them. Some of the changes I see are too drastic/draconian, and are not what was collectively decided time ago by the HDS team about CSS linting rules.

/cc @alex-ju

@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from 79dae35 to beb764d Compare April 19, 2025 07:26
@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from beb764d to 584619e Compare April 19, 2025 07:40
@didoo
Copy link
Contributor

didoo commented Apr 22, 2025

@aklkv FYI @alex-ju is OO until May 5 so unless it's urgent/blocker I would wait for him to come back (he has much more context about these changes and the previous PRs)

@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from 584619e to ae76679 Compare May 3, 2025 10:26
@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from ae76679 to 0f48d7d Compare May 5, 2025 00:17
@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from 0f48d7d to 8db68e6 Compare May 5, 2025 07:41
@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from 8db68e6 to d52c956 Compare May 5, 2025 07:49
@aklkv
Copy link
Collaborator Author

aklkv commented May 13, 2025

@alex-ju is there anything I can help here to move it forward?

@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from 81e1db4 to 99beadf Compare May 13, 2025 07:46
@alex-ju
Copy link
Member

alex-ju commented May 13, 2025

I strongly think we need to find a way to isolate the changes to the CSS files and have another tool to do the linting for them. Some of the changes I see are too drastic/draconian, and are not what was collectively decided time ago by the HDS team about CSS linting rules.

The main concern with this PR seems to be around Sass linting. Now, I'm not sure what alternatives we have here.
@didoo would it work for you if @aklkv disables prettier for Sass – keeping the code as is – and we plan to look for alternatives at a later point? or do you prefer having it resolved as part of this PR?

@didoo
Copy link
Contributor

didoo commented May 13, 2025

@didoo would it work for you if @aklkv disables prettier for Sass

yes, that would be the pragmatic thing to do, for me

@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from 99beadf to 535eb39 Compare May 14, 2025 07:40
@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from 535eb39 to 4c462ec Compare May 14, 2025 07:43
@aklkv
Copy link
Collaborator Author

aklkv commented May 14, 2025

@didoo @alex-ju I have removed all changes to *.scss and added it to prettierignore pattern. Let me know if you would like me to address anything else 🙏

@didoo
Copy link
Contributor

didoo commented May 14, 2025

@didoo @alex-ju I have removed all changes to *.scss and added it to prettierignore pattern. Let me know if you would like me to address anything else 🙏

I'll let @alex-ju have a look (he has more context/knowledge)

@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from 4c462ec to aee73bc Compare May 17, 2025 10:59
@aklkv aklkv mentioned this pull request May 17, 2025
Closed
2 tasks
alex-ju
alex-ju previously approved these changes May 19, 2025
View reviewed changes
@aklkv aklkv force-pushed the chore/eslint-prettier-for-apps branch from aee73bc to 50198de Compare May 20, 2025 05:53
@aklkv aklkv requested a review from alex-ju May 20, 2025 05:57
@aklkv
Copy link
Collaborator Author

aklkv commented May 20, 2025

@alex-ju I had to rebase, can I have another ✅ please

@aklkv aklkv merged commit 039c4f5 into main May 20, 2025
16 checks passed
@aklkv aklkv deleted the chore/eslint-prettier-for-apps branch May 20, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didoo didoo didoo approved these changes

@alex-ju alex-ju Awaiting requested review from alex-ju

Assignees

@aklkv aklkv

Labels

showcase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aklkv @didoo @alex-ju @hashibot-hds