-
Notifications
You must be signed in to change notification settings - Fork 49
AdvancedTable - AppFrame followup #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@didoo agree about the overflow: auto thing.. this came up because the scroll bar was not showing up in the "right" context for the horizontal scrolling. Another thing, we have a ticket open to investigate the best way to set the height for the table. In the showcase, I had to cap the table at 600px to make sure the thead would stick which isnt ideal. The overflow: auto fix could also be added in with that work. |
shleewhite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I just left the one suggestion.
07eeb14 to
45319d2
Compare
|
@shleewhite I've rebased my branch on |
68e6ec1 to
641c8ff
Compare
…cedTable” showcase page
…to a local wrapper of the GenericAdvancedTable demo component
16bb70c to
0f2d2f9
Compare
|
@LilithJames-HDS after your branch has been merged to |
📌 Summary
Looking at #2789 I noticed a couple of possible improvements.
🛠️ Detailed description
In this PR I have:
iFramewith the AdvancedTable AppFrame demo in the “AdvancedTable” showcase pagemaincontainer, making the example more similar to what consumers would have in productionoverflow: auto(ormin-width: 0) would be a problem that consumer would have too. In which case, we should consider having thehds-advanced-table__containerasdisplay: gridor something similar, so this would work out of the box instead of having to taking care of the overflow themselves. @KristinLBradley what do you think?Preview:
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.