Skip to content

[Project Solar / Phase 1 / Components] DialogPrimitive/Modal/Flyout carbonization#3645

Open
didoo wants to merge 9 commits intoproject-solar/phase-1-main-feature-branchfrom
project-solar/phase-1/HDS-6126-6085-6098/dialog-primitive-flyout-modal-carbonization
Open

[Project Solar / Phase 1 / Components] DialogPrimitive/Modal/Flyout carbonization#3645
didoo wants to merge 9 commits intoproject-solar/phase-1-main-feature-branchfrom
project-solar/phase-1/HDS-6126-6085-6098/dialog-primitive-flyout-modal-carbonization

Conversation

@didoo
Copy link
Contributor

@didoo didoo commented Feb 25, 2026

📌 Summary

This PR intends to finalize the "carbonization" of the DialogPrimitive, Modal, and Flyout components.

🛠️ Detailed description

In this PR I have:

👀 Previews:

🤔 Open questions

See shared document: https://docs.google.com/document/d/1b3lGaN1sJBD5G_1vPkpBubznLR1WacHKK9kzlULTO4c/edit?tab=t.94hepqj7ajq6#heading=h.lryrk1b5x8rt

🔗 External links

Jira tickets:

Figma file: https://www.figma.com/design/GWMDKHuGr98DFxSptH6vgj/-LJ--Token-Migration


👀 Component checklist

  • Percy was checked for any visual regression
    • Note: the subtle differences in the DialogPrimitive and Modal screenshots are due to the fact that we added a 1px transparent border to the dialog primitive, which slightly shifts the layout of the element; this is not an issue in production code, since the component in horizontally/vertically centered in the screen

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hds-showcase Ready Ready Preview Mar 18, 2026 6:48pm
hds-website Ready Ready Preview Mar 18, 2026 6:48pm

Request Review

@dchyun
Copy link
Contributor

dchyun commented Mar 2, 2026

@didoo I've carbonized the DismissButton which is used inside components here. If you would like to cherry pick those changes you can get them from #3665

@didoo
Copy link
Contributor Author

didoo commented Mar 4, 2026

@didoo I've carbonized the DismissButton which is used inside components here. If you would like to cherry pick those changes you can get them from #3665

@dchyun probably I could rebase this branch on yours, or viceversa, so we can see the overall effect of both carbonizations (it's used also in the Alert, and hence the Toast, components(

@didoo didoo force-pushed the project-solar/phase-1/HDS-6126-6085-6098/dialog-primitive-flyout-modal-carbonization branch from c3ba6a1 to 2abc5d1 Compare March 6, 2026 12:09
@didoo didoo changed the base branch from project-solar/phase-1-main-feature-branch to project-solar/phase-1/dchyun/dismiss-button-carbonization March 6, 2026 12:12
@didoo
Copy link
Contributor Author

didoo commented Mar 6, 2026

@dchyun update: I've rebased this PR on #3665

@didoo didoo force-pushed the project-solar/phase-1/HDS-6126-6085-6098/dialog-primitive-flyout-modal-carbonization branch from 2abc5d1 to b50ac52 Compare March 6, 2026 12:37
@didoo didoo force-pushed the project-solar/phase-1/dchyun/dismiss-button-carbonization branch from 51554b2 to 6d1e9e8 Compare March 11, 2026 15:25
@didoo didoo force-pushed the project-solar/phase-1/HDS-6126-6085-6098/dialog-primitive-flyout-modal-carbonization branch from b50ac52 to dfec8eb Compare March 11, 2026 15:27
@didoo didoo force-pushed the project-solar/phase-1/dchyun/dismiss-button-carbonization branch from 6d1e9e8 to f4f830d Compare March 11, 2026 18:25
@didoo didoo force-pushed the project-solar/phase-1/HDS-6126-6085-6098/dialog-primitive-flyout-modal-carbonization branch from dfec8eb to 2ee74fb Compare March 11, 2026 18:39
@didoo didoo force-pushed the project-solar/phase-1/HDS-6126-6085-6098/dialog-primitive-flyout-modal-carbonization branch from 2ee74fb to 9afb23f Compare March 11, 2026 18:41
@didoo didoo force-pushed the project-solar/phase-1/dchyun/dismiss-button-carbonization branch from f4f830d to 78e8666 Compare March 11, 2026 20:45
@didoo didoo force-pushed the project-solar/phase-1/HDS-6126-6085-6098/dialog-primitive-flyout-modal-carbonization branch from 9afb23f to 4789032 Compare March 11, 2026 21:07
@KristinLBradley
Copy link
Contributor

The Dialog Primitive border-color is transparent in the default theme. Is this as expected?

Dialog Primitive Carbonization

image

Dialog Primitive Showcase

image

@didoo
Copy link
Contributor Author

didoo commented Mar 17, 2026

The Dialog Primitive border-color is transparent in the default theme. Is this as expected?

@KristinLBradley yes, because in the default/"classic" HDS the border is applied via the elevation/box-shadow, but in the "carbonized" versions the shadow is completely removed ("none") so we had to introduce a border around the dialog element (transparent in one case, with color in the other)

Copy link
Contributor

@KristinLBradley KristinLBradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I just had a couple minor feedback comments I added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants