[Project Solar / Phase 1 / Components] DialogPrimitive/Modal/Flyout carbonization#3645
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@dchyun probably I could rebase this branch on yours, or viceversa, so we can see the overall effect of both carbonizations (it's used also in the |
c3ba6a1 to
2abc5d1
Compare
2abc5d1 to
b50ac52
Compare
51554b2 to
6d1e9e8
Compare
b50ac52 to
dfec8eb
Compare
6d1e9e8 to
f4f830d
Compare
dfec8eb to
2ee74fb
Compare
2ee74fb to
9afb23f
Compare
f4f830d to
78e8666
Compare
9afb23f to
4789032
Compare
3fd4412 to
db64ddb
Compare
db64ddb to
5fc3f79
Compare
5fc3f79 to
ba3b9f8
Compare
@KristinLBradley yes, because in the default/"classic" HDS the border is applied via the elevation/box-shadow, but in the "carbonized" versions the shadow is completely removed ("none") so we had to introduce a border around the dialog element (transparent in one case, with color in the other) |
showcase/app/components/page-carbonization/utilities/dialog-primitive/index.gts
Outdated
Show resolved
Hide resolved
showcase/app/styles/showcase-pages/carbonization/dialog-primitive.scss
Outdated
Show resolved
Hide resolved
KristinLBradley
left a comment
There was a problem hiding this comment.
Looks good overall. I just had a couple minor feedback comments I added.
…oent from IBM 4 Products


📌 Summary
This PR intends to finalize the "carbonization" of the
DialogPrimitive,Modal, andFlyoutcomponents.🛠️ Detailed description
In this PR I have:
utilities/dialog-primitiveandcomponents/flyoutcomponents/modalwas done during the dry-run phasedialog-primitiveDialogPrimitive,ModalandFlyoutcomponentsDismissButtonposition when carbonized (following [Project Solar / Phase 1 / Components]DismissButtoncarbonization #3665)DialogPrimitiveto align with most recent Figma variables for the componentFlyoutby using equivalent web component (SidePanel from IBM 4 Products)👀 Previews:
🤔 Open questions
See shared document: https://docs.google.com/document/d/1b3lGaN1sJBD5G_1vPkpBubznLR1WacHKK9kzlULTO4c/edit?tab=t.94hepqj7ajq6#heading=h.lryrk1b5x8rt
🔗 External links
Jira tickets:
Figma file: https://www.figma.com/design/GWMDKHuGr98DFxSptH6vgj/-LJ--Token-Migration
👀 Component checklist
DialogPrimitiveandModalscreenshots are due to the fact that we added a 1px transparent border to the dialog primitive, which slightly shifts the layout of the element; this is not an issue in production code, since the component in horizontally/vertically centered in the screen💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.