chore: fix user-facing and comment typos (reciever, seperator, occured)#794
Open
SAY-5 wants to merge 1 commit intohashicorp:mainfrom
Open
chore: fix user-facing and comment typos (reciever, seperator, occured)#794SAY-5 wants to merge 1 commit intohashicorp:mainfrom
SAY-5 wants to merge 1 commit intohashicorp:mainfrom
Conversation
Seven typos across four files, two of which surface to users via
hcl JSON parser diagnostic messages:
json/parser.go 'Missing attribute seperator comma' (x2)
-> 'Missing attribute separator comma'
json/public.go 'an error occured while closing/reading it.'
-> 'an error occurred while closing/reading it.'
Comment-only fixes (no behaviour change):
diagnostic.go recieve -> receive, reciever -> receiver
pos.go reciever -> receiver (x3)
hclwrite/node.go reciever -> receiver
Build, vet, and full test suite all remain green.
Signed-off-by: SAY-5 <say.apm35@gmail.com>
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
1 similar comment
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven typos across four files; two surface to users via HCL JSON parser diagnostics:
json/parser.go— `Missing attribute seperator comma` (two spots) → `separator`json/public.go— `an error occured while closing/reading it.` → `occurred`Comment-only fixes:
diagnostic.go— `recieve` → `receive`, `reciever` → `receiver`pos.go— `reciever` → `receiver` (×3)hclwrite/node.go— `reciever` → `receiver`Test plan
go build ./...go vet ./...go test ./... -count=1 -timeout 120s— full suite green, includinghclwrite/fuzz,integrationtest,json,json/fuzz,specsuite