tests: Add missing RequireConsul and RequireRoot checks #25456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some tests that were missing RequireConsul before. Doesn't remove RequireConsul from tests that perform operations before calling getTestConsul.
tgross
approved these changes
Mar 20, 2025
Member
tgross
left a comment
tgross
left a comment
There was a problem hiding this comment.
LGTM
I'm not 100% sure why all those taskrunner tests are requiring root, especially given they use the mock driver. But I suspect that's due to the changes we made for resources.cores and NUMA. As of #23803 which we did as part of the preliminaries for the "rootless Nomad" project, we should be able to perform those operations with cgroup delegation. It might be nice to swap out testutil.RequireRoot for a testutil.RequireOwnsCgroup in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding RequireConsul and RequireRoot checks to a lot of tests that are missing them. Highly unlikely to be comprehensive, but I want to land some progress before getting distracted.
Testing & Reproduction steps
Lots of tests should fail without this patch, especially if Consul isn't installed.
Links
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.