Skip to content

fixes subscription ID while validating image #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JenGoldstrich merged 3 commits into from
Jul 17, 2025
Merged

fixes subscription ID while validating image #473

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6150aaf
fixes subscription ID while validating image
Feb 27, 2025
4e2799d
updates subscription
Mar 24, 2025
f222ea6
apply goimports formatting
Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions builder/azure/chroot/step_verify_shared_image_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func (s *StepVerifySharedImageSource) Run(ctx context.Context, state multistep.S
s.SharedImageID))

galleryImageVersionID := galleryimageversions.NewImageVersionID(
azcli.SubscriptionID(),
resource.Subscription,
Copy link
Contributor

@JenGoldstrich JenGoldstrich Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shubangmck thanks for this contribution, I notice another instance where we're setting the subscription ID from the az cli's subscription.

This change makes sense but on line 106 we query the Image after querying the Image Version ID, so wouldn't you also need to also override the subscription ID there to fix your issue?

Copy link
Contributor Author

@shubhang-cmpl shubhang-cmpl Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JenGoldstrich Just updated my code, thanks for pointing it out!

resource.ResourceGroup,
resource.ResourceName[0],
resource.ResourceName[1],
Expand Down Expand Up @@ -103,7 +103,7 @@ func (s *StepVerifySharedImageSource) Run(ctx context.Context, state multistep.S

imageResource, _ := resource.Parent()
galleryImageID := galleryimages.NewGalleryImageID(
azcli.SubscriptionID(),
resource.Subscription,
resource.ResourceGroup,
resource.ResourceName[0],
resource.ResourceName[1],
Expand Down
Loading