Skip to content

bug/agentpoolworkspaces - Agent Pools using non-existent endpoints and failing to add allowed workspaces. (99)#110

Merged
KshitijaChoudhari merged 3 commits intonext-0.1.3from
bug/agentpoolworkspaces
Mar 27, 2026
Merged

bug/agentpoolworkspaces - Agent Pools using non-existent endpoints and failing to add allowed workspaces. (99)#110
KshitijaChoudhari merged 3 commits intonext-0.1.3from
bug/agentpoolworkspaces

Conversation

@KshitijaChoudhari
Copy link
Copy Markdown
Collaborator

@KshitijaChoudhari KshitijaChoudhari commented Mar 9, 2026

Description

This PR has add/fix support for agent-pool workspaces and related examples/tests.

  • Main goals:

Restore and update agent-related models and examples to support agent pool workspaces.
Remove or refactor the deprecated agent_pools resource and replace usages with the new workflow.
Update unit tests and examples to reflect the API changes and ensure compatibility.

Files of interest:
agent_pool.py
agent.py
agent_pools.py
test_agent_pools.py

Testing plan

  1. Run unit tests locally:
    Install and activate the virtualenv if not active:
    source .venv/bin/activate

  2. Run the unit tests (focused and full):
    pytest tests/units/test_agent_pools.py
    pytest

Screenshot 2026-03-09 at 10 49 58 AM

3.Manually exercise examples against a TFE instance :
Update credentials as needed and run to validate end-to-end behavior.
Screenshot 2026-03-09 at 11 00 20 AM

External links

-->

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

Rollback Plan

If a change needs to be reverted, we will roll out an update to the code within 7 days.

If this change causes regressions:
Revert the branch by merging a revert PR or use git revert and open a follow-up PR.
Hotfixes can be applied to main if needed and backported to the release branch.

Changes to Security Controls

No intentional changes to access controls, encryption, or logging are included in this PR. If any of the example code requires secrets or tokens, ensure they are supplied via secure environment variables and not hard-coded.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.

@KshitijaChoudhari KshitijaChoudhari requested a review from a team as a code owner March 9, 2026 05:20
@KshitijaChoudhari KshitijaChoudhari merged commit d3f5401 into next-0.1.3 Mar 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants