Bugfix/pagination

[isivaselvan]

Description

_list pagination in _base.py can repeatedly request page 1 and appear to hang (or loop indefinitely) when callers pass page[number] in params and use smaller page[size].

The current logic uses setdefault("page[number]", page) inside the loop.
When params already contains page[number] (for example from RunListOptions), setdefault does not overwrite it, so the request stays pinned to the same page even though page += 1 executes.

Testing plan

External links

Issue102
JIRA

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

python examples/run.py --organization sandbox --page-size 2

================================================================================
Listing runs across organization: sandbox
================================================================================
Found 12 runs across organization
- run-6dk7frv2Jup | status=RunStatus.Run_Planned
- run-yAdFQuW | status=RunStatus.Run_Planned
- run-9me6qitsR3 | status=RunStatus.Run_Errored
- run-yyrBwjS | status=RunStatus.Run_Errored
- run-BDn8sXmuP | status=RunStatus.Run_Errored
- run-Se5YLhhDh | status=RunStatus.Run_Applied
- run-9SX7FLk | status=RunStatus.Run_Errored
- run-56P1iMnrnG | status=RunStatus.Run_Errored
- run-zMffwuE9 | status=RunStatus.Run_Errored
- run-vjaXmp | status=RunStatus.Run_Errored
- run-gTnXiDfzj3 | status=RunStatus.Run_Errored
- run-b3TLLbmxJ | status=RunStatus.Run_Errored

Rollback Plan

Changes to Security Controls

PCI review checklist

• I have documented a clear reason for, and description of, the change I am making.

• If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

• If applicable, I've documented the impact of any changes to security controls.

  Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.