Skip to content

Conversation

@KshitijaChoudhari
Copy link
Collaborator

Description

Testing plan

External links

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

Rollback Plan

Changes to Security Controls

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.

@KshitijaChoudhari KshitijaChoudhari requested a review from a team as a code owner September 22, 2025 05:58
tag_bindings: list[TagBinding] = Field(default_factory=list)


# Variable Set related types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a follow up tickets to move these to seperate file under models/ folder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iam404 iam404 merged commit a1f82c7 into main Sep 22, 2025
11 checks passed
@iam404 iam404 deleted the variableset branch September 22, 2025 10:54
import builtins
from typing import Any

from tfe._http import HTTPTransport
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why importing 'tfe' package in its own file ?

https://developer.hashicorp.com/terraform/cloud-docs/api-docs/variable-sets
"""

def __init__(self, transport: HTTPTransport):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants