feat: Add notification configuration API support #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support workspace and team notification configurations - Add comprehensive unit tests with 31 test cases - Include example usage with sanitized webhook URLs - Based on Go TFE notification_configuration implementation
- Add explicit type annotations for all class attributes - Update to modern Python type syntax (list instead of List, | None instead of Optional) - Fix Collection[str] issues by adding explicit type annotations - All 31 unit tests still passing - Ruff compliance maintained - Only 3 MyPy unreachable warnings remain (false positives)
- Clean up documentation to remove Go TFE implementation references - Make codebase more self-contained and focused on Python implementation - Update all notification configuration files
This reverts commit a93a64a.
KshitijaChoudhari
force-pushed
the
notifications
branch
from
a86255a to
9681f1c
Compare
isivaselvan
reviewed
Oct 13, 2025
Collaborator
There was a problem hiding this comment.
Why the notification model was created on tfe folder? Kindly, remove the file
Collaborator
Author
There was a problem hiding this comment.
This has been resolved
isivaselvan
reviewed
Oct 13, 2025
Collaborator
There was a problem hiding this comment.
Remove the resource file under tfe folder. Its not required, as we renamed the folder to pytfe.
Collaborator
Author
There was a problem hiding this comment.
this has been resolved as well
isivaselvan
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing plan
External links
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Rollback Plan
Changes to Security Controls
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.