Conversation
…y instead of through the compat package
schmichael
approved these changes
Jan 9, 2025
Member
schmichael
left a comment
schmichael
left a comment
There was a problem hiding this comment.
❤️ ❤️ ❤️ linting guardrails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous PR switched the repo over to emitting metrics via github.com/hashicorp/go-metrics/compat. In discussions with other engineers it came up that if new metrics are added it would be good to ensure that they use the compat package as well. To that end, this PR introduces linter rules to ensure only the compat package is used.