fix: correct metrics label in requestPreVote handler#665
Merged
tgross merged 1 commit intohashicorp:mainfrom Mar 13, 2026
Merged
fix: correct metrics label in requestPreVote handler#665tgross merged 1 commit intohashicorp:mainfrom
tgross merged 1 commit intohashicorp:mainfrom
Conversation
|
|
Member
|
@Qian-Cheng-nju can we get you to sign the CLA as well? |
Contributor
Author
|
@tgross Thanks for the heads up! I've just signed the CLA. |
Contributor
Author
|
Hi @tgross, just checking in on this one — the CLA is signed and your review is approved. Is there anything else needed from my side to get this merged? Happy to make any changes if needed. Thanks! |
Member
|
Sorry for the delay @Qian-Cheng-nju. I had to get merge rights sorted out. Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
requestPreVotehandler reuses the metrics key"requestVote"from copy-paste in #530. This causes pre-vote RPC latency to be mixed into theraft.rpc.requestVotemetric.Fix: change to
"requestPreVote"to match the pattern used by all other RPC handlers.