Skip to content

Conversation

@zchsh
Copy link
Contributor

@zchsh zchsh commented Mar 9, 2021

🎟️ Asana Task
πŸ” Preview Link


This PR bumps @hashicorp/react-docs-page's docs-sidenav dep from a pre-release to the equivalent stable release.

Ideally this would have somehow happened automatically, but I think I'd messed something up with how I ran pre-releases in #154 that made lerna not bump this automatically.

Release Information

Please select one (required)

  • Major (This PR introduces a breaking (incompatible API) change)
  • Minor (This PR adds functionality but it backwards-compatible)
  • Patch (This PR adds a backwards-compatible bug fix)
Release Notes (required) This release bumps the `docs-sidenav` dep from a pre-release to the equivalent stable release.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Write a useful description (above) to give reviewers appropriate context.
  • Add release notes to the appropriate section (above).
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Cross Browser Testing account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Mar 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/8e4f4MUSjsbEypxna4CVxiNdTNdF
βœ… Preview: https://react-components-git-zsbump-docs-page-dep-hashicorp.vercel.app

@zchsh zchsh requested a review from brkalow March 9, 2021 17:19
@zchsh
Copy link
Contributor Author

zchsh commented Mar 9, 2021

@brkalow more cruft from #154 😬 TLDR; need to bump deps in 1) docs-page and 2) glossary-page and re-release. This PR is 1 of 2.

When I just pulled main and ran release, lerna didn't recognize the docs-sidenav > docs-page > glossary-page interdependencies. I think this is cause i made manual npm version bumps in #154 to avoid pre-release conflicts.

@zchsh zchsh merged commit 93b21d6 into main Mar 9, 2021
@zchsh zchsh deleted the zs.bump-docs-page-dep branch March 9, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants