Skip to content

Conversation

@zchsh
Copy link
Contributor

@zchsh zchsh commented Mar 9, 2021

🎟️ Asana Task
πŸ” Preview Link


Looks like things are somehow still not in sync, this PR fixes issues in docs-page and glossary-page package-locks.

See #163 for further details.

Release Information

Please select one (required)

  • Major (This PR introduces a breaking (incompatible API) change)
  • Minor (This PR adds functionality but it backwards-compatible)
  • Patch (This PR adds a backwards-compatible bug fix)
Release Notes (required) Fixes lerna symlink related issues in package-lock files.

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Write a useful description (above) to give reviewers appropriate context.
  • Add release notes to the appropriate section (above).
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Cross Browser Testing account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@vercel
Copy link

vercel bot commented Mar 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/E9JZbiW671fb6DE9iR7Y53MJ8FUU
βœ… Preview: https://react-components-git-zsfix-package-locks-again-hashicorp.vercel.app

@zchsh
Copy link
Contributor Author

zchsh commented Mar 9, 2021

@brkalow well this is feeling very flaky...

I went to publish glossary-page, and after pulling main, clearing out all node_modules, and running a fresh npm i && npm run bootstrap I got this diff. I think this is the final one needed - it looks like it has now removed the internal dependencies from package-locks.

@zchsh zchsh requested a review from brkalow March 9, 2021 20:23
Copy link
Contributor

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🀞

@zchsh zchsh merged commit 6603208 into main Mar 10, 2021
@zchsh zchsh deleted the zs.fix-package-locks-again branch March 10, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants