Skip to content

Conversation

@si-chan
Copy link
Contributor

@si-chan si-chan commented Jun 24, 2024

What

Address the edge case where the monthly cost is exactly $100.

Why

Based on the text description, the policy rule should allow this, hence the decimal comparison function used has been updated accordingly.

Screenshots

N/A


Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

  • One or more labels describe the type of change (e.g. clarification) and associated product (e.g. HCP Terraform ).
  • [N/A] Description links to related pull requests or issues, if any.

Content

  • [N/A] Redirects have been added to website/redirects.js for moved, renamed, or deleted pages.
  • [N/A] API documentation and the API Changelog have been updated.
  • [N/A] Links to related content where appropriate (e.g., API endpoints, permissions, etc.).
  • [N/A] Pages with related content are updated and link to this content when appropriate.
  • [N/A] Sidebar navigation files have been updated for added, deleted, reordered, or renamed pages.
  • [N/A] New pages have metadata (page name and description) at the top.
  • [N/A] New images are 2048 px wide. They have HashiCorp standard annotation color (#F92672) and format (rectangle with rounded corners), blurred sensitive details (e.g. credentials, usernames, user icons), and descriptive alt text in the markdown for accessibility.
  • [N/A] New code blocks have the correct syntax and line breaks to eliminate horizontal scroll bars.
  • [N/A] UI elements (button names, page names, etc.) are bolded.
  • [N/A] The Vercel website preview successfully deployed.

Reviews

  • I or someone else reviewed the content for technical accuracy.
  • I or someone else reviewed the content for typos, punctuation, spelling, and grammar.

si-chan added 2 commits June 24, 2024 09:34
Address the edge case where the monthly cost is exactly $100.
Based on the text description, the policy rule should allow this, hence the decimal comparison function used has been updated accordingly.
@vercel
Copy link

vercel bot commented Jun 24, 2024

@si-chan is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@hashicorp-cla-app
Copy link

hashicorp-cla-app bot commented Jun 24, 2024

CLA assistant check
All committers have signed the CLA.

@si-chan si-chan marked this pull request as ready for review June 24, 2024 08:47
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great catch!

@rkoron007 rkoron007 merged commit cf66748 into hashicorp:main May 27, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants