This repository was archived by the owner on May 6, 2020. It is now read-only.
Do Not Try to Comment on Non-PR Builds (fixes #50) #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Thanks for the work on this! There's a new environment variable named Best to wrap the entire attempt to post a comment around that variable instead. |
Author
|
Ah, excellent. Much nicer to be able to use that. I've just made the requested adjustments. |
In the event of a non-PR workflow, the actions would still attempt to post output to the non-existent PR URL. This change will prevent comments from being published when running the action against a PR.
Author
|
@sudomateo any chance I could get this merged, please? |
sudomateo
approved these changes
Oct 4, 2019
Contributor
|
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of a non-PR workflow, the actions would still attempt to
post output to the non-existent PR URL. This change checks to see if jq
parsed a "null" URL, and doesn't run curl if that is the case.