Tech debt: Reduce tags boilerplate code - Phase 2
#30280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 258b3bf.
This reverts commit 0250103.
Acceptance test output: % make testacc TESTARGS='-run=TestAccSSMDocument_' PKG=ssm ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 3 -run=TestAccSSMDocument_ -timeout 180m === RUN TestAccSSMDocument_basic === PAUSE TestAccSSMDocument_basic === RUN TestAccSSMDocument_name === PAUSE TestAccSSMDocument_name === RUN TestAccSSMDocument_Target_type === PAUSE TestAccSSMDocument_Target_type === RUN TestAccSSMDocument_versionName === PAUSE TestAccSSMDocument_versionName === RUN TestAccSSMDocument_update === PAUSE TestAccSSMDocument_update === RUN TestAccSSMDocument_Permission_public === PAUSE TestAccSSMDocument_Permission_public === RUN TestAccSSMDocument_Permission_private === PAUSE TestAccSSMDocument_Permission_private === RUN TestAccSSMDocument_Permission_batching === PAUSE TestAccSSMDocument_Permission_batching === RUN TestAccSSMDocument_Permission_change === PAUSE TestAccSSMDocument_Permission_change === RUN TestAccSSMDocument_params === PAUSE TestAccSSMDocument_params === RUN TestAccSSMDocument_automation === PAUSE TestAccSSMDocument_automation === RUN TestAccSSMDocument_package === PAUSE TestAccSSMDocument_package === RUN TestAccSSMDocument_SchemaVersion_1 === PAUSE TestAccSSMDocument_SchemaVersion_1 === RUN TestAccSSMDocument_session === PAUSE TestAccSSMDocument_session === RUN TestAccSSMDocument_DocumentFormat_yaml === PAUSE TestAccSSMDocument_DocumentFormat_yaml === RUN TestAccSSMDocument_tags === PAUSE TestAccSSMDocument_tags === RUN TestAccSSMDocument_disappears === PAUSE TestAccSSMDocument_disappears === CONT TestAccSSMDocument_basic === CONT TestAccSSMDocument_params === CONT TestAccSSMDocument_session --- PASS: TestAccSSMDocument_session (19.12s) === CONT TestAccSSMDocument_package --- PASS: TestAccSSMDocument_basic (19.23s) === CONT TestAccSSMDocument_SchemaVersion_1 --- PASS: TestAccSSMDocument_params (19.35s) === CONT TestAccSSMDocument_automation --- PASS: TestAccSSMDocument_SchemaVersion_1 (28.11s) === CONT TestAccSSMDocument_Permission_public --- PASS: TestAccSSMDocument_automation (28.12s) === CONT TestAccSSMDocument_Permission_change --- PASS: TestAccSSMDocument_Permission_public (17.28s) === CONT TestAccSSMDocument_Permission_batching --- PASS: TestAccSSMDocument_package (55.76s) === CONT TestAccSSMDocument_Permission_private --- PASS: TestAccSSMDocument_Permission_batching (17.44s) === CONT TestAccSSMDocument_versionName --- PASS: TestAccSSMDocument_Permission_change (40.52s) === CONT TestAccSSMDocument_update --- PASS: TestAccSSMDocument_Permission_private (17.25s) === CONT TestAccSSMDocument_Target_type --- PASS: TestAccSSMDocument_versionName (28.99s) === CONT TestAccSSMDocument_name --- PASS: TestAccSSMDocument_update (29.04s) === CONT TestAccSSMDocument_tags --- PASS: TestAccSSMDocument_Target_type (29.19s) === CONT TestAccSSMDocument_disappears --- PASS: TestAccSSMDocument_disappears (13.60s) === CONT TestAccSSMDocument_DocumentFormat_yaml --- PASS: TestAccSSMDocument_name (30.75s) --- PASS: TestAccSSMDocument_tags (42.66s) --- PASS: TestAccSSMDocument_DocumentFormat_yaml (29.64s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 169.634s
Acceptance test output: % make testacc TESTARGS='-run=TestAccSSMDocumentDataSource_' PKG=ssm ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 3 -run=TestAccSSMDocumentDataSource_ -timeout 180m === RUN TestAccSSMDocumentDataSource_basic === PAUSE TestAccSSMDocumentDataSource_basic === RUN TestAccSSMDocumentDataSource_managed === PAUSE TestAccSSMDocumentDataSource_managed === CONT TestAccSSMDocumentDataSource_basic === CONT TestAccSSMDocumentDataSource_managed --- PASS: TestAccSSMDocumentDataSource_managed (12.34s) --- PASS: TestAccSSMDocumentDataSource_basic (25.75s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 31.050s
…duce-tags-boilerplate-phase2
… parameter in tags interceptor.
Acceptance test output: % make testacc TESTARGS='-run=TestAccSSMDocument_' PKG=ssm ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2 -run=TestAccSSMDocument_ -timeout 180m === RUN TestAccSSMDocument_basic === PAUSE TestAccSSMDocument_basic === RUN TestAccSSMDocument_name === PAUSE TestAccSSMDocument_name === RUN TestAccSSMDocument_Target_type === PAUSE TestAccSSMDocument_Target_type === RUN TestAccSSMDocument_versionName === PAUSE TestAccSSMDocument_versionName === RUN TestAccSSMDocument_update === PAUSE TestAccSSMDocument_update === RUN TestAccSSMDocument_Permission_public === PAUSE TestAccSSMDocument_Permission_public === RUN TestAccSSMDocument_Permission_private === PAUSE TestAccSSMDocument_Permission_private === RUN TestAccSSMDocument_Permission_batching === PAUSE TestAccSSMDocument_Permission_batching === RUN TestAccSSMDocument_Permission_change === PAUSE TestAccSSMDocument_Permission_change === RUN TestAccSSMDocument_params === PAUSE TestAccSSMDocument_params === RUN TestAccSSMDocument_automation === PAUSE TestAccSSMDocument_automation === RUN TestAccSSMDocument_package === PAUSE TestAccSSMDocument_package === RUN TestAccSSMDocument_SchemaVersion_1 === PAUSE TestAccSSMDocument_SchemaVersion_1 === RUN TestAccSSMDocument_session === PAUSE TestAccSSMDocument_session === RUN TestAccSSMDocument_DocumentFormat_yaml === PAUSE TestAccSSMDocument_DocumentFormat_yaml === RUN TestAccSSMDocument_tags === PAUSE TestAccSSMDocument_tags === RUN TestAccSSMDocument_disappears === PAUSE TestAccSSMDocument_disappears === CONT TestAccSSMDocument_basic === CONT TestAccSSMDocument_disappears === CONT TestAccSSMDocument_tags --- PASS: TestAccSSMDocument_disappears (12.90s) --- PASS: TestAccSSMDocument_basic (17.62s) === CONT TestAccSSMDocument_DocumentFormat_yaml --- PASS: TestAccSSMDocument_DocumentFormat_yaml (27.51s) === CONT TestAccSSMDocument_session --- PASS: TestAccSSMDocument_tags (38.75s) === CONT TestAccSSMDocument_SchemaVersion_1 --- PASS: TestAccSSMDocument_session (16.10s) === CONT TestAccSSMDocument_package --- PASS: TestAccSSMDocument_SchemaVersion_1 (27.03s) === CONT TestAccSSMDocument_automation --- PASS: TestAccSSMDocument_automation (30.10s) === CONT TestAccSSMDocument_params --- PASS: TestAccSSMDocument_package (56.54s) === CONT TestAccSSMDocument_Permission_change --- PASS: TestAccSSMDocument_params (17.94s) === CONT TestAccSSMDocument_Permission_batching --- PASS: TestAccSSMDocument_Permission_batching (16.80s) === CONT TestAccSSMDocument_Permission_private --- PASS: TestAccSSMDocument_Permission_change (38.84s) === CONT TestAccSSMDocument_Permission_public --- PASS: TestAccSSMDocument_Permission_private (16.54s) === CONT TestAccSSMDocument_update --- PASS: TestAccSSMDocument_Permission_public (16.63s) === CONT TestAccSSMDocument_versionName --- PASS: TestAccSSMDocument_update (27.47s) === CONT TestAccSSMDocument_Target_type --- PASS: TestAccSSMDocument_versionName (27.57s) === CONT TestAccSSMDocument_name --- PASS: TestAccSSMDocument_Target_type (27.40s) --- PASS: TestAccSSMDocument_name (27.07s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 233.171s
Acceptance test output: % make testacc TESTARGS='-run=TestAccSSMMaintenanceWindow_' PKG=ssm ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2 -run=TestAccSSMMaintenanceWindow_ -timeout 180m === RUN TestAccSSMMaintenanceWindow_basic === PAUSE TestAccSSMMaintenanceWindow_basic === RUN TestAccSSMMaintenanceWindow_description === PAUSE TestAccSSMMaintenanceWindow_description === RUN TestAccSSMMaintenanceWindow_tags === PAUSE TestAccSSMMaintenanceWindow_tags === RUN TestAccSSMMaintenanceWindow_disappears === PAUSE TestAccSSMMaintenanceWindow_disappears === RUN TestAccSSMMaintenanceWindow_multipleUpdates === PAUSE TestAccSSMMaintenanceWindow_multipleUpdates === RUN TestAccSSMMaintenanceWindow_cutoff === PAUSE TestAccSSMMaintenanceWindow_cutoff === RUN TestAccSSMMaintenanceWindow_duration === PAUSE TestAccSSMMaintenanceWindow_duration === RUN TestAccSSMMaintenanceWindow_enabled === PAUSE TestAccSSMMaintenanceWindow_enabled === RUN TestAccSSMMaintenanceWindow_endDate === PAUSE TestAccSSMMaintenanceWindow_endDate === RUN TestAccSSMMaintenanceWindow_schedule === PAUSE TestAccSSMMaintenanceWindow_schedule === RUN TestAccSSMMaintenanceWindow_scheduleTimezone === PAUSE TestAccSSMMaintenanceWindow_scheduleTimezone === RUN TestAccSSMMaintenanceWindow_scheduleOffset === PAUSE TestAccSSMMaintenanceWindow_scheduleOffset === RUN TestAccSSMMaintenanceWindow_startDate === PAUSE TestAccSSMMaintenanceWindow_startDate === CONT TestAccSSMMaintenanceWindow_basic === CONT TestAccSSMMaintenanceWindow_enabled --- PASS: TestAccSSMMaintenanceWindow_basic (16.61s) === CONT TestAccSSMMaintenanceWindow_multipleUpdates --- PASS: TestAccSSMMaintenanceWindow_enabled (27.97s) === CONT TestAccSSMMaintenanceWindow_duration --- PASS: TestAccSSMMaintenanceWindow_multipleUpdates (24.72s) === CONT TestAccSSMMaintenanceWindow_cutoff --- PASS: TestAccSSMMaintenanceWindow_duration (28.19s) === CONT TestAccSSMMaintenanceWindow_scheduleTimezone --- PASS: TestAccSSMMaintenanceWindow_cutoff (27.22s) === CONT TestAccSSMMaintenanceWindow_startDate --- PASS: TestAccSSMMaintenanceWindow_scheduleTimezone (37.54s) === CONT TestAccSSMMaintenanceWindow_scheduleOffset --- PASS: TestAccSSMMaintenanceWindow_startDate (37.36s) === CONT TestAccSSMMaintenanceWindow_tags --- PASS: TestAccSSMMaintenanceWindow_scheduleOffset (26.69s) --- PASS: TestAccSSMMaintenanceWindow_schedule (27.68s) === CONT TestAccSSMMaintenanceWindow_endDate --- PASS: TestAccSSMMaintenanceWindow_tags (39.59s) === CONT TestAccSSMMaintenanceWindow_disappears --- PASS: TestAccSSMMaintenanceWindow_disappears (13.07s) === CONT TestAccSSMMaintenanceWindow_description --- PASS: TestAccSSMMaintenanceWindow_endDate (39.22s) --- PASS: TestAccSSMMaintenanceWindow_description (26.89s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 190.904s
Acceptance test output: % make testacc TESTARGS='-run=TestAccSSMMaintenanceWindow_' PKG=ssm ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2 -run=TestAccSSMMaintenanceWindow_ -timeout 180m === RUN TestAccSSMMaintenanceWindow_basic === PAUSE TestAccSSMMaintenanceWindow_basic === RUN TestAccSSMMaintenanceWindow_description === PAUSE TestAccSSMMaintenanceWindow_description === RUN TestAccSSMMaintenanceWindow_tags === PAUSE TestAccSSMMaintenanceWindow_tags === RUN TestAccSSMMaintenanceWindow_disappears === PAUSE TestAccSSMMaintenanceWindow_disappears === RUN TestAccSSMMaintenanceWindow_multipleUpdates === PAUSE TestAccSSMMaintenanceWindow_multipleUpdates === RUN TestAccSSMMaintenanceWindow_cutoff === PAUSE TestAccSSMMaintenanceWindow_cutoff === RUN TestAccSSMMaintenanceWindow_duration === PAUSE TestAccSSMMaintenanceWindow_duration === RUN TestAccSSMMaintenanceWindow_enabled === PAUSE TestAccSSMMaintenanceWindow_enabled === RUN TestAccSSMMaintenanceWindow_endDate === PAUSE TestAccSSMMaintenanceWindow_endDate === RUN TestAccSSMMaintenanceWindow_schedule === PAUSE TestAccSSMMaintenanceWindow_schedule === RUN TestAccSSMMaintenanceWindow_scheduleTimezone === PAUSE TestAccSSMMaintenanceWindow_scheduleTimezone === RUN TestAccSSMMaintenanceWindow_scheduleOffset === PAUSE TestAccSSMMaintenanceWindow_scheduleOffset === RUN TestAccSSMMaintenanceWindow_startDate === PAUSE TestAccSSMMaintenanceWindow_startDate === CONT TestAccSSMMaintenanceWindow_basic === CONT TestAccSSMMaintenanceWindow_enabled --- PASS: TestAccSSMMaintenanceWindow_basic (17.37s) === CONT TestAccSSMMaintenanceWindow_multipleUpdates --- PASS: TestAccSSMMaintenanceWindow_enabled (29.06s) === CONT TestAccSSMMaintenanceWindow_duration --- PASS: TestAccSSMMaintenanceWindow_multipleUpdates (24.48s) === CONT TestAccSSMMaintenanceWindow_cutoff --- PASS: TestAccSSMMaintenanceWindow_duration (27.11s) === CONT TestAccSSMMaintenanceWindow_tags --- PASS: TestAccSSMMaintenanceWindow_cutoff (28.07s) === CONT TestAccSSMMaintenanceWindow_disappears === CONT TestAccSSMMaintenanceWindow_description --- PASS: TestAccSSMMaintenanceWindow_disappears (13.48s) --- PASS: TestAccSSMMaintenanceWindow_tags (41.74s) === CONT TestAccSSMMaintenanceWindow_scheduleTimezone --- PASS: TestAccSSMMaintenanceWindow_description (28.12s) === CONT TestAccSSMMaintenanceWindow_startDate --- PASS: TestAccSSMMaintenanceWindow_scheduleTimezone (38.66s) === CONT TestAccSSMMaintenanceWindow_scheduleOffset --- PASS: TestAccSSMMaintenanceWindow_startDate (37.79s) === CONT TestAccSSMMaintenanceWindow_schedule --- PASS: TestAccSSMMaintenanceWindow_scheduleOffset (27.52s) === CONT TestAccSSMMaintenanceWindow_endDate --- PASS: TestAccSSMMaintenanceWindow_schedule (29.60s) --- PASS: TestAccSSMMaintenanceWindow_endDate (37.21s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 206.395s
Community NoteVoting for Prioritization
For Submitters
|
|
This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This was referenced Apr 3, 2023
This was referenced Apr 10, 2023
Merged
Merged
Merged
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the work done in the PoC to services with "non-standard" tagging APIs:
ListTagsandUpdateTagsAPIs (e.g.ssm)iamands3)ec2aws_vpc– PoCiaminspectorlogsresourceexplorer2aws_resourceexplorer2_index– PoCroute53s3servicecatalogsnsaws_sns_topic(sole applicable) – PoCssmssoadminRelations
Relates #29747.
Relates #29838.
Closes #28489.
Closes #26363.
Closes #27952.
Output from Acceptance Testing