Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Reduce tags boilerplate code - Plugin SDK resources e* (Phase 3c) #30533

Merged
merged 24 commits into from
Apr 10, 2023
Merged

Tech debt: Reduce tags boilerplate code - Plugin SDK resources e* (Phase 3c) #30533

merged 24 commits into from
Apr 10, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 7, 2023 •
edited

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.
Relates #30491.
Relates #30509.
Relates #30510.
Relates #30512.
Relates #30516.
Relates #30517.

Output from Acceptance Testing

=== RUN   TestAccECRAuthorizationTokenDataSource_basic
--- PASS: TestAccECRAuthorizationTokenDataSource_basic (43.27s)
=== RUN   TestAccECRImageDataSource_basic
=== PAUSE TestAccECRImageDataSource_basic
=== RUN   TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN   TestAccECRPullThroughCacheRule_basic
=== PAUSE TestAccECRPullThroughCacheRule_basic
=== RUN   TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN   TestAccECRRepositoryPolicy_basic
=== PAUSE TestAccECRRepositoryPolicy_basic
=== RUN   TestAccECRRepositoryPolicy_IAM_basic
=== PAUSE TestAccECRRepositoryPolicy_IAM_basic
=== RUN   TestAccECRRepository_basic
=== PAUSE TestAccECRRepository_basic
=== RUN   TestAccECRRepository_tags
=== PAUSE TestAccECRRepository_tags
=== CONT  TestAccECRImageDataSource_basic
=== CONT  TestAccECRRepositoryPolicy_basic
=== CONT  TestAccECRPullThroughCacheRule_basic
=== CONT  TestAccECRImageDataSource_basic
    image_data_source_test.go:19: Step 1/1 error: Check failed: Check 10/10 error: "data.aws_ecr_image.by_most_recent" error: no TypeSet element "image_tags.*", with value "latest" in state: map[string]string{"%":"9", "id":"sha256:d748bbe0733b25a9d7c86bed33381bc0cee532a0235aa6b9b56f3aee7cfba5bc", "image_digest":"sha256:d748bbe0733b25a9d7c86bed33381bc0cee532a0235aa6b9b56f3aee7cfba5bc", "image_pushed_at":"1680822832", "image_size_in_bytes":"64121512", "image_tags.#":"2", "image_tags.0":"2", "image_tags.1":"2.0.20230404.0", "most_recent":"true", "registry_id":"137112412989", "repository_name":"amazonlinux"}
--- FAIL: TestAccECRImageDataSource_basic (14.92s)
=== CONT  TestAccECRLifecyclePolicy_basic
--- PASS: TestAccECRPullThroughCacheRule_basic (33.80s)
=== CONT  TestAccECRRepository_basic
--- PASS: TestAccECRLifecyclePolicy_basic (39.06s)
=== CONT  TestAccECRRepository_tags
--- PASS: TestAccECRRepositoryPolicy_basic (57.83s)
=== CONT  TestAccECRRepositoryPolicy_IAM_basic
--- PASS: TestAccECRRepository_basic (32.93s)
=== CONT  TestAccECRRepositoryDataSource_basic
--- PASS: TestAccECRRepositoryDataSource_basic (19.66s)
--- PASS: TestAccECRRepositoryPolicy_IAM_basic (37.55s)
--- PASS: TestAccECRRepository_tags (48.27s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	154.276s
=== RUN   TestAccECRPublicAuthorizationTokenDataSource_basic
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccECRPublicAuthorizationTokenDataSource_basic (0.46s)
=== RUN   TestAccECRPublicRepositoryPolicy_basic
=== PAUSE TestAccECRPublicRepositoryPolicy_basic
=== RUN   TestAccECRPublicRepository_basic
=== PAUSE TestAccECRPublicRepository_basic
=== RUN   TestAccECRPublicRepository_tags
=== PAUSE TestAccECRPublicRepository_tags
=== CONT  TestAccECRPublicRepositoryPolicy_basic
=== CONT  TestAccECRPublicRepository_tags
=== CONT  TestAccECRPublicRepository_basic
=== CONT  TestAccECRPublicRepositoryPolicy_basic
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccECRPublicRepositoryPolicy_basic (0.00s)
=== CONT  TestAccECRPublicRepository_basic
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
=== CONT  TestAccECRPublicRepository_tags
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccECRPublicRepository_basic (0.00s)
--- SKIP: TestAccECRPublicRepository_tags (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic	6.107s
% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=ecs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccECSCapacityProvider_basic
=== PAUSE TestAccECSCapacityProvider_basic
=== RUN   TestAccECSCapacityProvider_tags
=== PAUSE TestAccECSCapacityProvider_tags
=== RUN   TestAccECSClusterCapacityProviders_basic
=== PAUSE TestAccECSClusterCapacityProviders_basic
=== RUN   TestAccECSClusterDataSource_tags
=== PAUSE TestAccECSClusterDataSource_tags
=== RUN   TestAccECSCluster_basic
=== PAUSE TestAccECSCluster_basic
=== RUN   TestAccECSCluster_tags
=== PAUSE TestAccECSCluster_tags
=== RUN   TestAccECSServiceDataSource_basic
=== PAUSE TestAccECSServiceDataSource_basic
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN   TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN   TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN   TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN   TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN   TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN   TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN   TestAccECSTag_basic
=== PAUSE TestAccECSTag_basic
=== RUN   TestContainerDefinitionsAreEquivalent_basic
=== PAUSE TestContainerDefinitionsAreEquivalent_basic
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_DockerVolume_basic
=== PAUSE TestAccECSTaskDefinition_DockerVolume_basic
=== RUN   TestAccECSTaskDefinition_EFSVolume_basic
=== PAUSE TestAccECSTaskDefinition_EFSVolume_basic
=== RUN   TestAccECSTaskDefinition_Fargate_basic
=== PAUSE TestAccECSTaskDefinition_Fargate_basic
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== RUN   TestAccECSTaskExecutionDataSource_basic
=== PAUSE TestAccECSTaskExecutionDataSource_basic
=== RUN   TestAccECSTaskExecutionDataSource_tags
=== PAUSE TestAccECSTaskExecutionDataSource_tags
=== RUN   TestAccECSTaskSet_basic
=== PAUSE TestAccECSTaskSet_basic
=== CONT  TestAccECSCapacityProvider_basic
=== CONT  TestAccECSTaskSet_basic
=== CONT  TestAccECSTaskExecutionDataSource_tags
--- PASS: TestAccECSTaskSet_basic (50.25s)
=== CONT  TestAccECSTaskExecutionDataSource_basic
--- PASS: TestAccECSCapacityProvider_basic (52.15s)
=== CONT  TestAccECSTaskDefinition_tags
    task_definition_test.go:959: Step 3/4 error: Error running apply: exit status 1
        
        Error: updating tags for ECS (Elastic Container) Task Definition (tf-acc-test-4027247348140162317): tagging resource (tf-acc-test-4027247348140162317): InvalidParameterException: The ARN provided is invalid.
        
          with aws_ecs_task_definition.test,
          on terraform_plugin_test.tf line 6, in resource "aws_ecs_task_definition" "test":
           6: resource "aws_ecs_task_definition" "test" {
        
--- FAIL: TestAccECSTaskDefinition_tags (30.92s)
=== CONT  TestAccECSTaskDefinition_Fargate_basic
--- PASS: TestAccECSTaskDefinition_Fargate_basic (21.24s)
=== CONT  TestAccECSTaskDefinition_EFSVolume_basic
--- PASS: TestAccECSTaskDefinition_EFSVolume_basic (24.38s)
=== CONT  TestAccECSTaskDefinition_DockerVolume_basic
--- PASS: TestAccECSTaskDefinition_DockerVolume_basic (15.06s)
=== CONT  TestAccECSTaskDefinition_basic
--- PASS: TestAccECSTaskDefinition_basic (26.07s)
=== CONT  TestContainerDefinitionsAreEquivalent_basic
--- PASS: TestContainerDefinitionsAreEquivalent_basic (0.00s)
=== CONT  TestAccECSTag_basic
--- PASS: TestAccECSTag_basic (26.95s)
=== CONT  TestAccECSService_Tags_basic
--- PASS: TestAccECSService_Tags_basic (96.59s)
=== CONT  TestAccECSService_ServiceConnect_basic
--- PASS: TestAccECSTaskExecutionDataSource_tags (302.05s)
=== CONT  TestAccECSService_ServiceRegistries_basic
--- PASS: TestAccECSTaskExecutionDataSource_basic (311.11s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (32.37s)
=== CONT  TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSService_ServiceConnect_basic (172.89s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_ServiceRegistries_basic (166.67s)
=== CONT  TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_PlacementConstraints_basic (85.08s)
=== CONT  TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_PlacementStrategy_basic (94.18s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_LaunchTypeFargate_basic (180.07s)
=== CONT  TestAccECSService_basic
--- PASS: TestAccECSService_DeploymentValues_basic (81.90s)
=== CONT  TestAccECSServiceDataSource_basic
--- PASS: TestAccECSService_basic (93.85s)
=== CONT  TestAccECSCluster_tags
--- PASS: TestAccECSCluster_tags (46.78s)
=== CONT  TestAccECSCluster_basic
--- PASS: TestAccECSServiceDataSource_basic (82.28s)
=== CONT  TestAccECSClusterDataSource_tags
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (172.23s)
=== CONT  TestAccECSClusterCapacityProviders_basic
--- PASS: TestAccECSClusterDataSource_tags (24.35s)
=== CONT  TestAccECSCapacityProvider_tags
--- PASS: TestAccECSCluster_basic (26.64s)
--- PASS: TestAccECSClusterCapacityProviders_basic (48.09s)
--- PASS: TestAccECSCapacityProvider_tags (83.24s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	828.284s
FAIL
make: *** [testacc] Error 1
% make testacc TESTARGS='-run=TestAccECSTaskDefinition_tags\|TestAccECSTaskDefinition_basic' PKG=ecs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=TestAccECSTaskDefinition_tags\|TestAccECSTaskDefinition_basic -timeout 180m
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== RUN   TestAccECSTaskDefinition_tags
=== PAUSE TestAccECSTaskDefinition_tags
=== CONT  TestAccECSTaskDefinition_basic
=== CONT  TestAccECSTaskDefinition_tags
--- PASS: TestAccECSTaskDefinition_basic (43.22s)
--- PASS: TestAccECSTaskDefinition_tags (67.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	76.160s
% make testacc TESTARGS='-run=TestAccEMRCluster_basic$$\|TestAccEMRCluster_tags\|TestAccEMRContainersVirtualCluster_basic$$\|TestAccEMRContainersVirtualCluster_tags\|TestAccEMRServerlessApplication_basic$$\|TestAccEMRServerlessApplication_tags' PKG=emr... ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr.../... -v -count 1 -parallel 3  -run=TestAccEMRCluster_basic$\|TestAccEMRCluster_tags\|TestAccEMRContainersVirtualCluster_basic$\|TestAccEMRContainersVirtualCluster_tags\|TestAccEMRServerlessApplication_basic$\|TestAccEMRServerlessApplication_tags -timeout 180m
q=== RUN   TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== RUN   TestAccEMRCluster_tags
=== PAUSE TestAccEMRCluster_tags
=== CONT  TestAccEMRCluster_basic
=== CONT  TestAccEMRCluster_tags
--- PASS: TestAccEMRCluster_basic (384.07s)
--- PASS: TestAccEMRCluster_tags (712.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	724.867s
=== RUN   TestAccEMRContainersVirtualCluster_basic
=== PAUSE TestAccEMRContainersVirtualCluster_basic
=== RUN   TestAccEMRContainersVirtualCluster_tags
=== PAUSE TestAccEMRContainersVirtualCluster_tags
=== CONT  TestAccEMRContainersVirtualCluster_basic
=== CONT  TestAccEMRContainersVirtualCluster_tags
--- PASS: TestAccEMRContainersVirtualCluster_tags (1029.97s)
--- PASS: TestAccEMRContainersVirtualCluster_basic (1141.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers	1146.948s
=== RUN   TestAccEMRServerlessApplication_basic
=== PAUSE TestAccEMRServerlessApplication_basic
=== RUN   TestAccEMRServerlessApplication_tags
=== PAUSE TestAccEMRServerlessApplication_tags
=== CONT  TestAccEMRServerlessApplication_basic
=== CONT  TestAccEMRServerlessApplication_tags
--- PASS: TestAccEMRServerlessApplication_basic (80.06s)
--- PASS: TestAccEMRServerlessApplication_tags (102.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrserverless	110.808s
% make testacc TESTARGS='-run=TestAccElasticsearchDomain_basic$$\|TestAccElasticsearchDomain_tags' PKG=elasticsearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticsearch/... -v -count 1 -parallel 20  -run=TestAccElasticsearchDomain_basic$\|TestAccElasticsearchDomain_tags -timeout 180m
=== RUN   TestAccElasticsearchDomain_basic
=== PAUSE TestAccElasticsearchDomain_basic
=== RUN   TestAccElasticsearchDomain_tags
=== PAUSE TestAccElasticsearchDomain_tags
=== CONT  TestAccElasticsearchDomain_basic
=== CONT  TestAccElasticsearchDomain_tags
--- PASS: TestAccElasticsearchDomain_basic (1328.35s)
--- PASS: TestAccElasticsearchDomain_tags (1357.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch	1363.304s
% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=ev... ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ev.../... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccEventsAPIDestination_basic
=== PAUSE TestAccEventsAPIDestination_basic
=== RUN   TestAccEventsArchive_basic
=== PAUSE TestAccEventsArchive_basic
=== RUN   TestAccEventsBusDataSource_basic
=== PAUSE TestAccEventsBusDataSource_basic
=== RUN   TestAccEventsBusPolicy_basic
=== PAUSE TestAccEventsBusPolicy_basic
=== RUN   TestAccEventsBus_basic
=== PAUSE TestAccEventsBus_basic
=== RUN   TestAccEventsBus_tags
=== PAUSE TestAccEventsBus_tags
=== RUN   TestAccEventsConnectionDataSource_Connection_basic
=== PAUSE TestAccEventsConnectionDataSource_Connection_basic
=== RUN   TestAccEventsConnection_basic
=== PAUSE TestAccEventsConnection_basic
=== RUN   TestAccEventsPermission_basic
=== PAUSE TestAccEventsPermission_basic
=== RUN   TestAccEventsRule_basic
=== PAUSE TestAccEventsRule_basic
=== RUN   TestAccEventsRule_tags
=== PAUSE TestAccEventsRule_tags
=== RUN   TestAccEventsSourceDataSource_basic
    source_data_source_test.go:19: Environment variable EVENT_BRIDGE_PARTNER_EVENT_SOURCE_NAME is not set
--- SKIP: TestAccEventsSourceDataSource_basic (0.00s)
=== RUN   TestAccEventsTarget_basic
=== PAUSE TestAccEventsTarget_basic
=== CONT  TestAccEventsAPIDestination_basic
=== CONT  TestAccEventsTarget_basic
=== CONT  TestAccEventsRule_tags
--- PASS: TestAccEventsTarget_basic (42.37s)
=== CONT  TestAccEventsRule_basic
--- PASS: TestAccEventsAPIDestination_basic (68.95s)
=== CONT  TestAccEventsPermission_basic
--- PASS: TestAccEventsRule_tags (89.93s)
=== CONT  TestAccEventsConnection_basic
--- PASS: TestAccEventsRule_basic (75.68s)
=== CONT  TestAccEventsConnectionDataSource_Connection_basic
--- PASS: TestAccEventsPermission_basic (70.36s)
=== CONT  TestAccEventsBus_tags
--- PASS: TestAccEventsConnectionDataSource_Connection_basic (27.45s)
=== CONT  TestAccEventsBus_basic
--- PASS: TestAccEventsConnection_basic (62.35s)
=== CONT  TestAccEventsBusPolicy_basic
--- PASS: TestAccEventsBusPolicy_basic (32.30s)
=== CONT  TestAccEventsBusDataSource_basic
--- PASS: TestAccEventsBus_basic (45.66s)
=== CONT  TestAccEventsArchive_basic
--- PASS: TestAccEventsBusDataSource_basic (16.62s)
--- PASS: TestAccEventsBus_tags (62.41s)
--- PASS: TestAccEventsArchive_basic (19.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	218.440s
=== RUN   TestAccEvidentlyFeature_basic
=== PAUSE TestAccEvidentlyFeature_basic
=== RUN   TestAccEvidentlyFeature_tags
=== PAUSE TestAccEvidentlyFeature_tags
=== RUN   TestAccEvidentlyLaunch_basic
=== PAUSE TestAccEvidentlyLaunch_basic
=== RUN   TestAccEvidentlyLaunch_tags
=== PAUSE TestAccEvidentlyLaunch_tags
=== RUN   TestAccEvidentlyProject_basic
=== PAUSE TestAccEvidentlyProject_basic
=== RUN   TestAccEvidentlyProject_tags
=== PAUSE TestAccEvidentlyProject_tags
=== RUN   TestAccEvidentlySegment_basic
=== PAUSE TestAccEvidentlySegment_basic
=== RUN   TestAccEvidentlySegment_tags
=== PAUSE TestAccEvidentlySegment_tags
=== CONT  TestAccEvidentlyFeature_basic
=== CONT  TestAccEvidentlyLaunch_basic
=== CONT  TestAccEvidentlyProject_basic
--- PASS: TestAccEvidentlyFeature_basic (22.45s)
=== CONT  TestAccEvidentlySegment_tags
--- PASS: TestAccEvidentlyLaunch_basic (24.12s)
=== CONT  TestAccEvidentlySegment_basic
--- PASS: TestAccEvidentlyProject_basic (38.06s)
=== CONT  TestAccEvidentlyProject_tags
--- PASS: TestAccEvidentlySegment_basic (26.91s)
=== CONT  TestAccEvidentlyLaunch_tags
--- PASS: TestAccEvidentlySegment_tags (68.26s)
=== CONT  TestAccEvidentlyFeature_tags
--- PASS: TestAccEvidentlyProject_tags (77.47s)
--- PASS: TestAccEvidentlyLaunch_tags (78.32s)
--- PASS: TestAccEvidentlyFeature_tags (69.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/evidently	166.796s
% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=elb... ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb.../... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccELBAppCookieStickinessPolicy_basic
=== PAUSE TestAccELBAppCookieStickinessPolicy_basic
=== RUN   TestAccELBAttachment_basic
=== PAUSE TestAccELBAttachment_basic
=== RUN   TestAccELBBackendServerPolicy_basic
=== PAUSE TestAccELBBackendServerPolicy_basic
=== RUN   TestAccELBHostedZoneIDDataSource_basic
=== PAUSE TestAccELBHostedZoneIDDataSource_basic
=== RUN   TestAccELBCookieStickinessPolicy_basic
=== PAUSE TestAccELBCookieStickinessPolicy_basic
=== RUN   TestAccELBSSLNegotiationPolicy_basic
=== PAUSE TestAccELBSSLNegotiationPolicy_basic
=== RUN   TestAccELBListenerPolicy_basic
=== PAUSE TestAccELBListenerPolicy_basic
=== RUN   TestAccELBLoadBalancerDataSource_basic
=== PAUSE TestAccELBLoadBalancerDataSource_basic
=== RUN   TestAccELBLoadBalancer_basic
=== PAUSE TestAccELBLoadBalancer_basic
=== RUN   TestAccELBLoadBalancer_tags
=== PAUSE TestAccELBLoadBalancer_tags
=== RUN   TestAccELBPolicy_basic
=== PAUSE TestAccELBPolicy_basic
=== RUN   TestAccELBProxyProtocolPolicy_basic
=== PAUSE TestAccELBProxyProtocolPolicy_basic
=== RUN   TestAccELBServiceAccountDataSource_basic
=== PAUSE TestAccELBServiceAccountDataSource_basic
=== CONT  TestAccELBAppCookieStickinessPolicy_basic
=== CONT  TestAccELBLoadBalancerDataSource_basic
=== CONT  TestAccELBCookieStickinessPolicy_basic
--- PASS: TestAccELBLoadBalancerDataSource_basic (45.77s)
=== CONT  TestAccELBListenerPolicy_basic
--- PASS: TestAccELBCookieStickinessPolicy_basic (46.76s)
=== CONT  TestAccELBSSLNegotiationPolicy_basic
--- PASS: TestAccELBAppCookieStickinessPolicy_basic (50.05s)
=== CONT  TestAccELBBackendServerPolicy_basic
--- PASS: TestAccELBListenerPolicy_basic (25.64s)
=== CONT  TestAccELBHostedZoneIDDataSource_basic
--- PASS: TestAccELBBackendServerPolicy_basic (32.77s)
=== CONT  TestAccELBAttachment_basic
--- PASS: TestAccELBSSLNegotiationPolicy_basic (38.63s)
=== CONT  TestAccELBPolicy_basic
--- PASS: TestAccELBHostedZoneIDDataSource_basic (22.70s)
=== CONT  TestAccELBServiceAccountDataSource_basic
--- PASS: TestAccELBServiceAccountDataSource_basic (12.64s)
=== CONT  TestAccELBProxyProtocolPolicy_basic
--- PASS: TestAccELBPolicy_basic (23.29s)
=== CONT  TestAccELBLoadBalancer_tags
--- PASS: TestAccELBProxyProtocolPolicy_basic (41.66s)
=== CONT  TestAccELBLoadBalancer_basic
--- PASS: TestAccELBLoadBalancer_tags (61.16s)
--- PASS: TestAccELBLoadBalancer_basic (25.51s)
--- PASS: TestAccELBAttachment_basic (179.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	267.436s
=== RUN   TestAccELBV2HostedZoneIDDataSource_basic
=== PAUSE TestAccELBV2HostedZoneIDDataSource_basic
=== RUN   TestAccELBV2ListenerCertificate_basic
=== PAUSE TestAccELBV2ListenerCertificate_basic
=== RUN   TestAccELBV2ListenerDataSource_basic
=== PAUSE TestAccELBV2ListenerDataSource_basic
=== RUN   TestAccELBV2ListenerRule_basic
=== PAUSE TestAccELBV2ListenerRule_basic
=== RUN   TestAccELBV2ListenerRule_tags
=== PAUSE TestAccELBV2ListenerRule_tags
=== RUN   TestAccELBV2Listener_basic
=== PAUSE TestAccELBV2Listener_basic
=== RUN   TestAccELBV2Listener_tags
=== PAUSE TestAccELBV2Listener_tags
=== RUN   TestAccELBV2LoadBalancerDataSource_basic
=== PAUSE TestAccELBV2LoadBalancerDataSource_basic
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_tags
=== PAUSE TestAccELBV2LoadBalancer_tags
=== RUN   TestAccELBV2LoadBalancersDataSource_basic
=== PAUSE TestAccELBV2LoadBalancersDataSource_basic
=== RUN   TestAccELBV2TargetGroupAttachment_basic
=== PAUSE TestAccELBV2TargetGroupAttachment_basic
=== RUN   TestAccELBV2TargetGroupDataSource_basic
=== PAUSE TestAccELBV2TargetGroupDataSource_basic
=== RUN   TestAccELBV2TargetGroupDataSource_tags
=== PAUSE TestAccELBV2TargetGroupDataSource_tags
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_basic
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_basic
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== RUN   TestAccELBV2TargetGroup_Geneve_basic
=== PAUSE TestAccELBV2TargetGroup_Geneve_basic
=== RUN   TestAccELBV2TargetGroup_tags
=== PAUSE TestAccELBV2TargetGroup_tags
=== RUN   TestAccELBV2TargetGroup_ALBAlias_basic
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_basic
=== RUN   TestAccELBV2TargetGroup_ALBAlias_tags
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_tags
=== CONT  TestAccELBV2HostedZoneIDDataSource_basic
=== CONT  TestAccELBV2LoadBalancersDataSource_basic
=== CONT  TestAccELBV2TargetGroup_ALBAlias_tags
--- PASS: TestAccELBV2TargetGroup_ALBAlias_tags (42.62s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_basic
--- PASS: TestAccELBV2HostedZoneIDDataSource_basic (47.69s)
=== CONT  TestAccELBV2TargetGroup_tags
--- PASS: TestAccELBV2TargetGroup_ALBAlias_basic (24.39s)
=== CONT  TestAccELBV2TargetGroup_Geneve_basic
--- PASS: TestAccELBV2TargetGroup_Geneve_basic (25.86s)
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_tags (56.97s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_basic
--- PASS: TestAccELBV2TargetGroup_basic (22.11s)
=== CONT  TestAccELBV2TargetGroupDataSource_tags
--- PASS: TestAccELBV2TargetGroupDataSource_tags (21.59s)
=== CONT  TestAccELBV2TargetGroupDataSource_basic
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (41.14s)
=== CONT  TestAccELBV2TargetGroupAttachment_basic
--- PASS: TestAccELBV2LoadBalancersDataSource_basic (170.87s)
=== CONT  TestAccELBV2Listener_tags
--- PASS: TestAccELBV2TargetGroupAttachment_basic (91.59s)
=== CONT  TestAccELBV2LoadBalancer_tags
--- PASS: TestAccELBV2TargetGroupDataSource_basic (159.13s)
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2Listener_tags (199.81s)
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
--- PASS: TestAccELBV2LoadBalancer_tags (245.01s)
=== CONT  TestAccELBV2LoadBalancerDataSource_basic
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (231.74s)
=== CONT  TestAccELBV2ListenerRule_basic
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (165.05s)
=== CONT  TestAccELBV2Listener_basic
--- PASS: TestAccELBV2LoadBalancerDataSource_basic (159.74s)
=== CONT  TestAccELBV2ListenerRule_tags
--- PASS: TestAccELBV2ListenerRule_basic (157.59s)
=== CONT  TestAccELBV2ListenerDataSource_basic
--- PASS: TestAccELBV2Listener_basic (158.59s)
=== CONT  TestAccELBV2ListenerCertificate_basic
--- PASS: TestAccELBV2ListenerRule_tags (181.46s)
--- PASS: TestAccELBV2ListenerDataSource_basic (157.91s)
--- PASS: TestAccELBV2ListenerCertificate_basic (166.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	869.109s

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=efs ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccEFSAccessPointDataSource_basic
=== PAUSE TestAccEFSAccessPointDataSource_basic
=== RUN   TestAccEFSAccessPoint_basic
=== PAUSE TestAccEFSAccessPoint_basic
=== RUN   TestAccEFSAccessPoint_tags
=== PAUSE TestAccEFSAccessPoint_tags
=== RUN   TestAccEFSAccessPointsDataSource_basic
=== PAUSE TestAccEFSAccessPointsDataSource_basic
=== RUN   TestAccEFSBackupPolicy_basic
=== PAUSE TestAccEFSBackupPolicy_basic
=== RUN   TestAccEFSFileSystemDataSource_tags
=== PAUSE TestAccEFSFileSystemDataSource_tags
=== RUN   TestAccEFSFileSystemDataSource_nonExistent_tags
=== PAUSE TestAccEFSFileSystemDataSource_nonExistent_tags
=== RUN   TestAccEFSFileSystemPolicy_basic
=== PAUSE TestAccEFSFileSystemPolicy_basic
=== RUN   TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN   TestAccEFSFileSystem_tags
=== PAUSE TestAccEFSFileSystem_tags
=== RUN   TestAccEFSMountTargetDataSource_basic
=== PAUSE TestAccEFSMountTargetDataSource_basic
=== RUN   TestAccEFSMountTarget_basic
=== PAUSE TestAccEFSMountTarget_basic
=== RUN   TestAccEFSReplicationConfiguration_basic
=== PAUSE TestAccEFSReplicationConfiguration_basic
=== CONT  TestAccEFSAccessPointDataSource_basic
=== CONT  TestAccEFSFileSystemPolicy_basic
=== CONT  TestAccEFSMountTargetDataSource_basic
--- PASS: TestAccEFSAccessPointDataSource_basic (28.46s)
=== CONT  TestAccEFSReplicationConfiguration_basic
--- PASS: TestAccEFSFileSystemPolicy_basic (38.60s)
=== CONT  TestAccEFSFileSystem_tags
--- PASS: TestAccEFSFileSystem_tags (66.91s)
=== CONT  TestAccEFSFileSystem_basic
--- PASS: TestAccEFSFileSystem_basic (23.46s)
=== CONT  TestAccEFSBackupPolicy_basic
--- PASS: TestAccEFSMountTargetDataSource_basic (134.26s)
=== CONT  TestAccEFSFileSystemDataSource_nonExistent_tags
--- PASS: TestAccEFSFileSystemDataSource_nonExistent_tags (21.88s)
=== CONT  TestAccEFSFileSystemDataSource_tags
--- PASS: TestAccEFSBackupPolicy_basic (27.36s)
=== CONT  TestAccEFSMountTarget_basic
--- PASS: TestAccEFSFileSystemDataSource_tags (21.56s)
=== CONT  TestAccEFSAccessPoint_tags
--- PASS: TestAccEFSAccessPoint_tags (49.16s)
=== CONT  TestAccEFSAccessPointsDataSource_basic
--- PASS: TestAccEFSAccessPointsDataSource_basic (25.45s)
=== CONT  TestAccEFSAccessPoint_basic
--- PASS: TestAccEFSAccessPoint_basic (28.49s)
--- PASS: TestAccEFSMountTarget_basic (234.97s)
--- PASS: TestAccEFSReplicationConfiguration_basic (543.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	577.811s
% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=eks ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccEKSAddonDataSource_basic
=== PAUSE TestAccEKSAddonDataSource_basic
=== RUN   TestAccEKSAddon_basic
=== PAUSE TestAccEKSAddon_basic
=== RUN   TestAccEKSAddon_tags
=== PAUSE TestAccEKSAddon_tags
=== RUN   TestAccEKSAddonVersionDataSource_basic
=== PAUSE TestAccEKSAddonVersionDataSource_basic
=== RUN   TestAccEKSClusterAuthDataSource_basic
=== PAUSE TestAccEKSClusterAuthDataSource_basic
=== RUN   TestAccEKSClusterDataSource_basic
=== PAUSE TestAccEKSClusterDataSource_basic
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN   TestAccEKSClustersDataSource_basic
=== PAUSE TestAccEKSClustersDataSource_basic
=== RUN   TestAccEKSFargateProfile_basic
=== PAUSE TestAccEKSFargateProfile_basic
=== RUN   TestAccEKSFargateProfile_tags
=== PAUSE TestAccEKSFargateProfile_tags
=== RUN   TestAccEKSIdentityProviderConfig_basic
=== PAUSE TestAccEKSIdentityProviderConfig_basic
=== RUN   TestAccEKSIdentityProviderConfig_tags
=== PAUSE TestAccEKSIdentityProviderConfig_tags
=== RUN   TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (1101.32s)
=== RUN   TestAccEKSNodeGroup_basic
=== PAUSE TestAccEKSNodeGroup_basic
=== RUN   TestAccEKSNodeGroup_tags
=== PAUSE TestAccEKSNodeGroup_tags
=== RUN   TestAccEKSNodeGroupsDataSource_basic
--- PASS: TestAccEKSNodeGroupsDataSource_basic (884.71s)
=== CONT  TestAccEKSAddonDataSource_basic
=== CONT  TestAccEKSClustersDataSource_basic
=== CONT  TestAccEKSClusterAuthDataSource_basic
--- PASS: TestAccEKSClusterAuthDataSource_basic (9.89s)
=== CONT  TestAccEKSCluster_basic
--- PASS: TestAccEKSCluster_basic (720.34s)
=== CONT  TestAccEKSCluster_tags
--- PASS: TestAccEKSClustersDataSource_basic (766.98s)
=== CONT  TestAccEKSAddon_tags
--- PASS: TestAccEKSAddonDataSource_basic (773.11s)
=== CONT  TestAccEKSAddonVersionDataSource_basic
--- PASS: TestAccEKSAddon_tags (690.38s)
=== CONT  TestAccEKSAddon_basic
--- PASS: TestAccEKSAddonVersionDataSource_basic (752.40s)
=== CONT  TestAccEKSIdentityProviderConfig_tags
--- PASS: TestAccEKSCluster_tags (817.22s)
=== CONT  TestAccEKSClusterDataSource_basic
--- PASS: TestAccEKSAddon_basic (754.48s)
=== CONT  TestAccEKSNodeGroup_tags
--- PASS: TestAccEKSClusterDataSource_basic (730.86s)
=== CONT  TestAccEKSFargateProfile_tags
--- PASS: TestAccEKSIdentityProviderConfig_tags (1582.79s)
=== CONT  TestAccEKSNodeGroup_basic
--- PASS: TestAccEKSNodeGroup_tags (1124.87s)
=== CONT  TestAccEKSIdentityProviderConfig_basic
--- PASS: TestAccEKSFargateProfile_tags (1089.71s)
=== CONT  TestAccEKSFargateProfile_basic
--- PASS: TestAccEKSNodeGroup_basic (1174.47s)
--- PASS: TestAccEKSFargateProfile_basic (1043.77s)
--- PASS: TestAccEKSIdentityProviderConfig_basic (1557.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	6885.174s
% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=elasticache ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccElastiCacheClusterDataSource_Data_basic
=== PAUSE TestAccElastiCacheClusterDataSource_Data_basic
=== RUN   TestAccElastiCacheCluster_tags
=== PAUSE TestAccElastiCacheCluster_tags
=== RUN   TestAccElastiCacheGlobalReplicationGroup_basic
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_basic
=== RUN   TestAccElastiCacheGlobalReplicationGroup_clusterMode_basic
=== PAUSE TestAccElastiCacheGlobalReplicationGroup_clusterMode_basic
=== RUN   TestAccElastiCacheParameterGroup_basic
=== PAUSE TestAccElastiCacheParameterGroup_basic
=== RUN   TestAccElastiCacheParameterGroup_tags
=== PAUSE TestAccElastiCacheParameterGroup_tags
=== RUN   TestAccElastiCacheReplicationGroupDataSource_basic
=== PAUSE TestAccElastiCacheReplicationGroupDataSource_basic
=== RUN   TestAccElastiCacheReplicationGroup_basic
=== PAUSE TestAccElastiCacheReplicationGroup_basic
=== RUN   TestAccElastiCacheReplicationGroup_ClusterMode_basic
=== PAUSE TestAccElastiCacheReplicationGroup_ClusterMode_basic
=== RUN   TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic
=== PAUSE TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic
=== RUN   TestAccElastiCacheReplicationGroup_tags
=== PAUSE TestAccElastiCacheReplicationGroup_tags
=== RUN   TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic
=== PAUSE TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic
=== RUN   TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
=== PAUSE TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
=== RUN   TestAccElastiCacheSubnetGroupDataSource_basic
=== PAUSE TestAccElastiCacheSubnetGroupDataSource_basic
=== RUN   TestAccElastiCacheSubnetGroup_basic
=== PAUSE TestAccElastiCacheSubnetGroup_basic
=== RUN   TestAccElastiCacheSubnetGroup_tags
=== PAUSE TestAccElastiCacheSubnetGroup_tags
=== RUN   TestAccElastiCacheUserDataSource_basic
=== PAUSE TestAccElastiCacheUserDataSource_basic
=== RUN   TestAccElastiCacheUserGroupAssociation_basic
=== PAUSE TestAccElastiCacheUserGroupAssociation_basic
=== RUN   TestAccElastiCacheUserGroup_basic
=== PAUSE TestAccElastiCacheUserGroup_basic
=== RUN   TestAccElastiCacheUserGroup_tags
=== PAUSE TestAccElastiCacheUserGroup_tags
=== RUN   TestAccElastiCacheUser_basic
=== PAUSE TestAccElastiCacheUser_basic
=== RUN   TestAccElastiCacheUser_tags
=== PAUSE TestAccElastiCacheUser_tags
=== CONT  TestAccElastiCacheClusterDataSource_Data_basic
=== CONT  TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic
=== CONT  TestAccElastiCacheReplicationGroupDataSource_basic
--- PASS: TestAccElastiCacheClusterDataSource_Data_basic (493.63s)
=== CONT  TestAccElastiCacheReplicationGroup_tags
--- PASS: TestAccElastiCacheReplicationGroupDataSource_basic (835.95s)
=== CONT  TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic
--- PASS: TestAccElastiCacheReplicationGroup_tags (958.16s)
=== CONT  TestAccElastiCacheReplicationGroup_ClusterMode_basic
    replication_group_test.go:844: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating ElastiCache Replication Group (tf-acc-test-8157821005691262992): InsufficientCacheClusterCapacity: Cannot create a cache cluster because there is no availability zone corresponding to the subnets in the cache subnet group with sufficient capacity.
        	status code: 400, request id: 0b9a8128-f1ec-4057-aada-bd77554cc00e
        
          with aws_elasticache_replication_group.test,
          on terraform_plugin_test.tf line 68, in resource "aws_elasticache_replication_group" "test":
          68: resource "aws_elasticache_replication_group" "test" {
        
--- FAIL: TestAccElastiCacheReplicationGroup_ClusterMode_basic (14.29s)
=== CONT  TestAccElastiCacheReplicationGroup_basic
--- PASS: TestAccElastiCacheReplicationGroup_basic (701.36s)
=== CONT  TestAccElastiCacheUserGroupAssociation_basic
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupID_basic (2179.18s)
=== CONT  TestAccElastiCacheUser_tags
=== CONT  TestAccElastiCacheUserGroupAssociation_basic
    user_group_association_test.go:29: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_elasticache_user_group.test will be updated in-place
          ~ resource "aws_elasticache_user_group" "test" {
                id            = "tf-acc-test-6886862716508271850"
              + tags_all      = (known after apply)
                # (4 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
=== CONT  TestAccElastiCacheUser_tags
    user_test.go:234: Step 3/3 error: Error running apply: exit status 1
        
        Error: updating ElastiCache User (arn:aws:elasticache:us-west-2:187416307283:user:tf-acc-3993335464908762191) tags: untagging resource (arn:aws:elasticache:us-west-2:187416307283:user:tf-acc-3993335464908762191): TagNotFound: Failing request. These tags are not present : tagKey
        	status code: 404, request id: 1da01320-c4e5-43f7-ac42-190d2ea8d205
        
          with aws_elasticache_user.test,
          on terraform_plugin_test.tf line 2, in resource "aws_elasticache_user" "test":
           2: resource "aws_elasticache_user" "test" {
        
--- FAIL: TestAccElastiCacheUser_tags (131.14s)
=== CONT  TestAccElastiCacheUser_basic
--- PASS: TestAccElastiCacheUser_basic (60.84s)
=== CONT  TestAccElastiCacheUserGroup_tags
--- PASS: TestAccElastiCacheReplicationGroup_NumberCacheClusters_basic (1572.73s)
=== CONT  TestAccElastiCacheUserGroup_basic
--- FAIL: TestAccElastiCacheUserGroupAssociation_basic (267.60s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_clusterMode_basic
=== CONT  TestAccElastiCacheUserGroup_basic
    user_group_test.go:25: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_elasticache_user_group.test will be updated in-place
          ~ resource "aws_elasticache_user_group" "test" {
                id            = "tf-acc-3778340698101280489"
              + tags_all      = (known after apply)
                # (4 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccElastiCacheUserGroup_basic (149.16s)
=== CONT  TestAccElastiCacheParameterGroup_tags
--- PASS: TestAccElastiCacheUserGroup_tags (187.61s)
=== CONT  TestAccElastiCacheParameterGroup_basic
--- PASS: TestAccElastiCacheParameterGroup_basic (16.56s)
=== CONT  TestAccElastiCacheSubnetGroup_basic
--- PASS: TestAccElastiCacheParameterGroup_tags (39.15s)
=== CONT  TestAccElastiCacheUserDataSource_basic
--- PASS: TestAccElastiCacheSubnetGroup_basic (24.19s)
=== CONT  TestAccElastiCacheSubnetGroup_tags
--- PASS: TestAccElastiCacheSubnetGroup_tags (55.66s)
=== CONT  TestAccElastiCacheGlobalReplicationGroup_basic
--- PASS: TestAccElastiCacheUserDataSource_basic (79.66s)
=== CONT  TestAccElastiCacheSubnetGroupDataSource_basic
--- PASS: TestAccElastiCacheSubnetGroupDataSource_basic (23.15s)
=== CONT  TestAccElastiCacheCluster_tags
--- PASS: TestAccElastiCacheCluster_tags (505.71s)
=== CONT  TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic
--- PASS: TestAccElastiCacheGlobalReplicationGroup_basic (815.23s)
--- PASS: TestAccElastiCacheGlobalReplicationGroup_clusterMode_basic (1170.69s)
--- PASS: TestAccElastiCacheReplicationGroup_GlobalReplicationGroupIDClusterMode_basic (3491.62s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	6702.209s
FAIL
make: *** [testacc] Error 1
% make testacc TESTARGS='-run=TestAccElastiCacheUser_\|TestAccElastiCacheUserGroup_\|TestAccElastiCacheUserGroupAssociation_' PKG=elasticache ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 3  -run=TestAccElastiCacheUser_\|TestAccElastiCacheUserGroup_\|TestAccElastiCacheUserGroupAssociation_ -timeout 180m
=== RUN   TestAccElastiCacheUserGroupAssociation_basic
=== PAUSE TestAccElastiCacheUserGroupAssociation_basic
=== RUN   TestAccElastiCacheUserGroupAssociation_update
=== PAUSE TestAccElastiCacheUserGroupAssociation_update
=== RUN   TestAccElastiCacheUserGroupAssociation_disappears
=== PAUSE TestAccElastiCacheUserGroupAssociation_disappears
=== RUN   TestAccElastiCacheUserGroupAssociation_multiple
=== PAUSE TestAccElastiCacheUserGroupAssociation_multiple
=== RUN   TestAccElastiCacheUserGroup_basic
=== PAUSE TestAccElastiCacheUserGroup_basic
=== RUN   TestAccElastiCacheUserGroup_update
=== PAUSE TestAccElastiCacheUserGroup_update
=== RUN   TestAccElastiCacheUserGroup_tags
=== PAUSE TestAccElastiCacheUserGroup_tags
=== RUN   TestAccElastiCacheUserGroup_disappears
=== PAUSE TestAccElastiCacheUserGroup_disappears
=== RUN   TestAccElastiCacheUser_basic
=== PAUSE TestAccElastiCacheUser_basic
=== RUN   TestAccElastiCacheUser_password_auth_mode
=== PAUSE TestAccElastiCacheUser_password_auth_mode
=== RUN   TestAccElastiCacheUser_iam_auth_mode
=== PAUSE TestAccElastiCacheUser_iam_auth_mode
=== RUN   TestAccElastiCacheUser_update
=== PAUSE TestAccElastiCacheUser_update
=== RUN   TestAccElastiCacheUser_update_password_auth_mode
=== PAUSE TestAccElastiCacheUser_update_password_auth_mode
=== RUN   TestAccElastiCacheUser_tags
=== PAUSE TestAccElastiCacheUser_tags
=== RUN   TestAccElastiCacheUser_disappears
=== PAUSE TestAccElastiCacheUser_disappears
=== CONT  TestAccElastiCacheUserGroupAssociation_basic
=== CONT  TestAccElastiCacheUser_basic
=== CONT  TestAccElastiCacheUserGroup_basic
--- PASS: TestAccElastiCacheUser_basic (24.98s)
=== CONT  TestAccElastiCacheUserGroup_disappears
--- PASS: TestAccElastiCacheUserGroup_basic (146.06s)
=== CONT  TestAccElastiCacheUserGroup_tags
--- PASS: TestAccElastiCacheUserGroup_disappears (186.12s)
=== CONT  TestAccElastiCacheUserGroup_update
--- PASS: TestAccElastiCacheUserGroupAssociation_basic (270.34s)
=== CONT  TestAccElastiCacheUserGroupAssociation_disappears
--- PASS: TestAccElastiCacheUserGroup_tags (189.44s)
=== CONT  TestAccElastiCacheUserGroupAssociation_multiple
--- PASS: TestAccElastiCacheUserGroup_update (302.18s)
=== CONT  TestAccElastiCacheUserGroupAssociation_update
--- PASS: TestAccElastiCacheUserGroupAssociation_disappears (297.51s)
=== CONT  TestAccElastiCacheUser_iam_auth_mode
--- PASS: TestAccElastiCacheUser_iam_auth_mode (60.49s)
=== CONT  TestAccElastiCacheUser_update
--- PASS: TestAccElastiCacheUserGroupAssociation_multiple (417.40s)
=== CONT  TestAccElastiCacheUser_password_auth_mode
--- PASS: TestAccElastiCacheUser_update (127.39s)
=== CONT  TestAccElastiCacheUser_disappears
--- PASS: TestAccElastiCacheUser_password_auth_mode (60.57s)
=== CONT  TestAccElastiCacheUser_tags
--- PASS: TestAccElastiCacheUser_disappears (66.40s)
=== CONT  TestAccElastiCacheUser_update_password_auth_mode
--- PASS: TestAccElastiCacheUser_tags (59.41s)
--- PASS: TestAccElastiCacheUserGroupAssociation_update (423.01s)
--- PASS: TestAccElastiCacheUser_update_password_auth_mode (177.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	1004.964s
% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=elasticbeanstalk ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticbeanstalk/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccElasticBeanstalkApplicationDataSource_basic
=== PAUSE TestAccElasticBeanstalkApplicationDataSource_basic
=== RUN   TestAccElasticBeanstalkApplication_BeanstalkApp_basic
=== PAUSE TestAccElasticBeanstalkApplication_BeanstalkApp_basic
=== RUN   TestAccElasticBeanstalkApplication_BeanstalkApp_tags
=== PAUSE TestAccElasticBeanstalkApplication_BeanstalkApp_tags
=== RUN   TestAccElasticBeanstalkApplicationVersion_BeanstalkApp_basic
=== PAUSE TestAccElasticBeanstalkApplicationVersion_BeanstalkApp_basic
=== RUN   TestAccElasticBeanstalkApplicationVersion_BeanstalkApp_tags
=== PAUSE TestAccElasticBeanstalkApplicationVersion_BeanstalkApp_tags
=== RUN   TestAccElasticBeanstalkConfigurationTemplate_basic
=== PAUSE TestAccElasticBeanstalkConfigurationTemplate_basic
=== RUN   TestAccElasticBeanstalkEnvironment_basic
=== PAUSE TestAccElasticBeanstalkEnvironment_basic
=== RUN   TestAccElasticBeanstalkEnvironment_tags
=== PAUSE TestAccElasticBeanstalkEnvironment_tags
=== RUN   TestAccElasticBeanstalkHostedZoneDataSource_basic
=== PAUSE TestAccElasticBeanstalkHostedZoneDataSource_basic
=== RUN   TestAccElasticBeanstalkSolutionStackDataSource_basic
=== PAUSE TestAccElasticBeanstalkSolutionStackDataSource_basic
=== CONT  TestAccElasticBeanstalkApplicationDataSource_basic
=== CONT  TestAccElasticBeanstalkConfigurationTemplate_basic
=== CONT  TestAccElasticBeanstalkHostedZoneDataSource_basic
--- PASS: TestAccElasticBeanstalkHostedZoneDataSource_basic (12.42s)
=== CONT  TestAccElasticBeanstalkSolutionStackDataSource_basic
    solution_stack_data_source_test.go:16: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: Your query returned no results. Please change your search criteria and try again.
        
          with data.aws_elastic_beanstalk_solution_stack.multi_docker,
          on terraform_plugin_test.tf line 2, in data "aws_elastic_beanstalk_solution_stack" "multi_docker":
           2: data "aws_elastic_beanstalk_solution_stack" "multi_docker" {
        
--- FAIL: TestAccElasticBeanstalkSolutionStackDataSource_basic (2.95s)
=== CONT  TestAccElasticBeanstalkEnvironment_tags
--- PASS: TestAccElasticBeanstalkApplicationDataSource_basic (20.30s)
=== CONT  TestAccElasticBeanstalkEnvironment_basic
--- PASS: TestAccElasticBeanstalkConfigurationTemplate_basic (24.69s)
=== CONT  TestAccElasticBeanstalkApplicationVersion_BeanstalkApp_basic
--- PASS: TestAccElasticBeanstalkApplicationVersion_BeanstalkApp_basic (20.73s)
=== CONT  TestAccElasticBeanstalkApplicationVersion_BeanstalkApp_tags
--- PASS: TestAccElasticBeanstalkApplicationVersion_BeanstalkApp_tags (76.51s)
=== CONT  TestAccElasticBeanstalkApplication_BeanstalkApp_tags
--- PASS: TestAccElasticBeanstalkApplication_BeanstalkApp_tags (53.53s)
=== CONT  TestAccElasticBeanstalkApplication_BeanstalkApp_basic
=== CONT  TestAccElasticBeanstalkEnvironment_tags
    environment_test.go:240: Step 3/4 error: Check failed: Check 2/4 error: aws_elastic_beanstalk_environment.test: Attribute 'tags.%' expected "2", got "1"
--- PASS: TestAccElasticBeanstalkApplication_BeanstalkApp_basic (21.38s)
--- PASS: TestAccElasticBeanstalkEnvironment_basic (311.28s)
--- FAIL: TestAccElasticBeanstalkEnvironment_tags (386.38s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	407.209s
FAIL
make: *** [testacc] Error 1
% make testacc TESTARGS='-run=TestAccElasticBeanstalkSolutionStackDataSource_' PKG=elasticbeanstalk ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticbeanstalk/... -v -count 1 -parallel 3  -run=TestAccElasticBeanstalkSolutionStackDataSource_ -timeout 180m
=== RUN   TestAccElasticBeanstalkSolutionStackDataSource_basic
=== PAUSE TestAccElasticBeanstalkSolutionStackDataSource_basic
=== CONT  TestAccElasticBeanstalkSolutionStackDataSource_basic
--- PASS: TestAccElasticBeanstalkSolutionStackDataSource_basic (13.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	19.004s
% make testacc TESTARGS='-run=TestAccElasticBeanstalkEnvironment_' PKG=elasticbeanstalk ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticbeanstalk/... -v -count 1 -parallel 3  -run=TestAccElasticBeanstalkEnvironment_ -timeout 180m
=== RUN   TestAccElasticBeanstalkEnvironment_basic
=== PAUSE TestAccElasticBeanstalkEnvironment_basic
=== RUN   TestAccElasticBeanstalkEnvironment_disappears
=== PAUSE TestAccElasticBeanstalkEnvironment_disappears
=== RUN   TestAccElasticBeanstalkEnvironment_tier
=== PAUSE TestAccElasticBeanstalkEnvironment_tier
=== RUN   TestAccElasticBeanstalkEnvironment_cnamePrefix
=== PAUSE TestAccElasticBeanstalkEnvironment_cnamePrefix
=== RUN   TestAccElasticBeanstalkEnvironment_beanstalkEnv
=== PAUSE TestAccElasticBeanstalkEnvironment_beanstalkEnv
=== RUN   TestAccElasticBeanstalkEnvironment_resource
=== PAUSE TestAccElasticBeanstalkEnvironment_resource
=== RUN   TestAccElasticBeanstalkEnvironment_tags
=== PAUSE TestAccElasticBeanstalkEnvironment_tags
=== RUN   TestAccElasticBeanstalkEnvironment_changeStack
=== PAUSE TestAccElasticBeanstalkEnvironment_changeStack
=== RUN   TestAccElasticBeanstalkEnvironment_update
=== PAUSE TestAccElasticBeanstalkEnvironment_update
=== RUN   TestAccElasticBeanstalkEnvironment_label
=== PAUSE TestAccElasticBeanstalkEnvironment_label
=== RUN   TestAccElasticBeanstalkEnvironment_settingWithJSONValue
=== PAUSE TestAccElasticBeanstalkEnvironment_settingWithJSONValue
=== RUN   TestAccElasticBeanstalkEnvironment_platformARN
=== PAUSE TestAccElasticBeanstalkEnvironment_platformARN
=== CONT  TestAccElasticBeanstalkEnvironment_basic
=== CONT  TestAccElasticBeanstalkEnvironment_tags
=== CONT  TestAccElasticBeanstalkEnvironment_label
--- PASS: TestAccElasticBeanstalkEnvironment_basic (318.93s)
=== CONT  TestAccElasticBeanstalkEnvironment_update
--- PASS: TestAccElasticBeanstalkEnvironment_label (430.79s)
=== CONT  TestAccElasticBeanstalkEnvironment_changeStack
--- PASS: TestAccElasticBeanstalkEnvironment_tags (532.28s)
=== CONT  TestAccElasticBeanstalkEnvironment_cnamePrefix
--- PASS: TestAccElasticBeanstalkEnvironment_update (524.56s)
=== CONT  TestAccElasticBeanstalkEnvironment_resource
--- PASS: TestAccElasticBeanstalkEnvironment_changeStack (446.89s)
=== CONT  TestAccElasticBeanstalkEnvironment_beanstalkEnv
--- PASS: TestAccElasticBeanstalkEnvironment_cnamePrefix (350.23s)
=== CONT  TestAccElasticBeanstalkEnvironment_tier
--- PASS: TestAccElasticBeanstalkEnvironment_resource (289.14s)
=== CONT  TestAccElasticBeanstalkEnvironment_platformARN
--- PASS: TestAccElasticBeanstalkEnvironment_beanstalkEnv (441.72s)
=== CONT  TestAccElasticBeanstalkEnvironment_settingWithJSONValue
--- PASS: TestAccElasticBeanstalkEnvironment_platformARN (340.31s)
=== CONT  TestAccElasticBeanstalkEnvironment_disappears
--- PASS: TestAccElasticBeanstalkEnvironment_tier (628.75s)
--- PASS: TestAccElasticBeanstalkEnvironment_settingWithJSONValue (342.66s)
--- PASS: TestAccElasticBeanstalkEnvironment_disappears (362.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	1843.556s

@ewbankkit
Ignore RDS and ElasticBeanstalk system tags.
376fb48
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - ecr.
086684f
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - ecrpublic.
221a500
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - ecs.
e0d6a5c
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - efs.
48a4a6e
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - eks.
bb8b71c
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - elasticache.
a84c5d7
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - elasticbeanstalk.
e5b4833
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - elasticsearch.
a274b49
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - elb.
626b5e3
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - elbv2.
b4da577
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - emr.
699e3b4
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - emrcontainers.
ba4cd9b
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - emrserverless.
9a885a9
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - events.
0d66040
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - evidently.
1e244bb
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecr Issues and PRs that pertain to the ecr service. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Apr 7, 2023
@github-actions github-actions bot added service/emrcontainers Issues and PRs that pertain to the emrcontainers service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/events Issues and PRs that pertain to the events service. service/evidently Issues and PRs that pertain to the evidently service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 7, 2023
@ewbankkit ewbankkit mentioned this pull request Apr 7, 2023
Merged
@github-actions github-actions bot added the tags Pertains to resource tagging. label Apr 7, 2023
@ewbankkit ewbankkit merged commit 95eda84 into main Apr 10, 2023
38 checks passed
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3c-e branch April 10, 2023 14:26
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 10, 2023
github-actions bot pushed a commit that referenced this pull request Apr 10, 2023
Update CHANGELOG.md for #30533
28ed8b0
This was referenced Apr 10, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Apr 19, 2023
Closed
@mikhailshilkov mikhailshilkov mentioned this pull request Apr 21, 2023
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecr Issues and PRs that pertain to the ecr service. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/events Issues and PRs that pertain to the events service. service/evidently Issues and PRs that pertain to the evidently service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.63.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ewbankkit