Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Reduce tags boilerplate code - Plugin SDK resources i* (Phase 3c) #30517

Merged
merged 5 commits into from
Apr 7, 2023
Merged

Tech debt: Reduce tags boilerplate code - Plugin SDK resources i* (Phase 3c) #30517

merged 5 commits into from
Apr 7, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 6, 2023 •
edited

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.
Relates #30491.
Relates #30509.
Relates #30510.
Relates #30512.
Relates #30516.

Output from Acceptance Testing

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=i... ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/i.../... -v -count 1 -parallel 2  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccIAMAccessKey_basic
=== PAUSE TestAccIAMAccessKey_basic
=== RUN   TestAccIAMGroupDataSource_basic
=== PAUSE TestAccIAMGroupDataSource_basic
=== RUN   TestAccIAMGroupMembership_basic
=== PAUSE TestAccIAMGroupMembership_basic
=== RUN   TestAccIAMGroupPolicyAttachment_basic
=== PAUSE TestAccIAMGroupPolicyAttachment_basic
=== RUN   TestAccIAMGroupPolicy_basic
=== PAUSE TestAccIAMGroupPolicy_basic
=== RUN   TestAccIAMGroup_basic
=== PAUSE TestAccIAMGroup_basic
=== RUN   TestAccIAMInstanceProfileDataSource_basic
=== PAUSE TestAccIAMInstanceProfileDataSource_basic
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfilesDataSource_basic
=== PAUSE TestAccIAMInstanceProfilesDataSource_basic
=== RUN   TestAccIAMOpenidConnectProviderDataSource_basic
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_basic
=== RUN   TestAccIAMOpenidConnectProviderDataSource_tags
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_tags
=== RUN   TestAccIAMOpenIDConnectProvider_basic
=== PAUSE TestAccIAMOpenIDConnectProvider_basic
=== RUN   TestAccIAMOpenIDConnectProvider_tags
=== PAUSE TestAccIAMOpenIDConnectProvider_tags
=== RUN   TestAccIAMPolicyAttachment_basic
=== PAUSE TestAccIAMPolicyAttachment_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_basic
=== PAUSE TestAccIAMPolicyDocumentDataSource_basic
=== RUN   TestAccIAMPolicy_basic
=== PAUSE TestAccIAMPolicy_basic
=== RUN   TestAccIAMPolicy_tags
=== PAUSE TestAccIAMPolicy_tags
=== RUN   TestAccIAMRoleDataSource_basic
=== PAUSE TestAccIAMRoleDataSource_basic
=== RUN   TestAccIAMRoleDataSource_tags
=== PAUSE TestAccIAMRoleDataSource_tags
=== RUN   TestAccIAMRolePolicyAttachment_basic
=== PAUSE TestAccIAMRolePolicyAttachment_basic
=== RUN   TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN   TestAccIAMRole_basic
=== PAUSE TestAccIAMRole_basic
=== RUN   TestAccIAMRole_tags
=== PAUSE TestAccIAMRole_tags
=== RUN   TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== RUN   TestAccIAMRole_ManagedPolicy_basic
=== PAUSE TestAccIAMRole_ManagedPolicy_basic
=== RUN   TestAccIAMRolesDataSource_basic
=== PAUSE TestAccIAMRolesDataSource_basic
=== RUN   TestAccIAMSAMLProviderDataSource_basic
=== PAUSE TestAccIAMSAMLProviderDataSource_basic
=== RUN   TestAccIAMSAMLProvider_basic
=== PAUSE TestAccIAMSAMLProvider_basic
=== RUN   TestAccIAMSAMLProvider_tags
=== PAUSE TestAccIAMSAMLProvider_tags
=== RUN   TestAccIAMServerCertificateDataSource_basic
=== PAUSE TestAccIAMServerCertificateDataSource_basic
=== RUN   TestAccIAMServerCertificate_basic
=== PAUSE TestAccIAMServerCertificate_basic
=== RUN   TestAccIAMServerCertificate_tags
=== PAUSE TestAccIAMServerCertificate_tags
=== RUN   TestAccIAMServiceLinkedRole_basic
=== PAUSE TestAccIAMServiceLinkedRole_basic
=== RUN   TestAccIAMServiceLinkedRole_tags
=== PAUSE TestAccIAMServiceLinkedRole_tags
=== RUN   TestAccIAMServiceSpecificCredential_basic
=== PAUSE TestAccIAMServiceSpecificCredential_basic
=== RUN   TestAccIAMSessionContextDataSource_basic
=== PAUSE TestAccIAMSessionContextDataSource_basic
=== RUN   TestAccIAMSigningCertificate_basic
=== PAUSE TestAccIAMSigningCertificate_basic
=== RUN   TestAccIAMUserDataSource_basic
=== PAUSE TestAccIAMUserDataSource_basic
=== RUN   TestAccIAMUserDataSource_tags
=== PAUSE TestAccIAMUserDataSource_tags
=== RUN   TestAccIAMUserGroupMembership_basic
=== PAUSE TestAccIAMUserGroupMembership_basic
=== RUN   TestAccIAMUserLoginProfile_basic
=== PAUSE TestAccIAMUserLoginProfile_basic
=== RUN   TestAccIAMUserPolicyAttachment_basic
=== PAUSE TestAccIAMUserPolicyAttachment_basic
=== RUN   TestAccIAMUserPolicy_basic
=== PAUSE TestAccIAMUserPolicy_basic
=== RUN   TestAccIAMUserSSHKeyDataSource_basic
=== PAUSE TestAccIAMUserSSHKeyDataSource_basic
=== RUN   TestAccIAMUserSSHKey_basic
=== PAUSE TestAccIAMUserSSHKey_basic
=== RUN   TestAccIAMUser_basic
=== PAUSE TestAccIAMUser_basic
=== RUN   TestAccIAMUser_tags
=== PAUSE TestAccIAMUser_tags
=== RUN   TestAccIAMVirtualMFADevice_basic
=== PAUSE TestAccIAMVirtualMFADevice_basic
=== RUN   TestAccIAMVirtualMFADevice_tags
=== PAUSE TestAccIAMVirtualMFADevice_tags
=== CONT  TestAccIAMAccessKey_basic
=== CONT  TestAccIAMRole_ManagedPolicy_basic
--- PASS: TestAccIAMAccessKey_basic (33.14s)
=== CONT  TestAccIAMVirtualMFADevice_tags
--- PASS: TestAccIAMRole_ManagedPolicy_basic (114.83s)
=== CONT  TestAccIAMVirtualMFADevice_basic
--- PASS: TestAccIAMVirtualMFADevice_basic (58.59s)
=== CONT  TestAccIAMUser_tags
--- PASS: TestAccIAMVirtualMFADevice_tags (145.35s)
=== CONT  TestAccIAMUser_basic
--- PASS: TestAccIAMUser_tags (93.22s)
=== CONT  TestAccIAMUserSSHKey_basic
--- PASS: TestAccIAMUser_basic (92.08s)
=== CONT  TestAccIAMUserSSHKeyDataSource_basic
--- PASS: TestAccIAMUserSSHKeyDataSource_basic (34.87s)
=== CONT  TestAccIAMUserPolicy_basic
--- PASS: TestAccIAMUserSSHKey_basic (42.82s)
=== CONT  TestAccIAMUserPolicyAttachment_basic
--- PASS: TestAccIAMUserPolicy_basic (57.33s)
=== CONT  TestAccIAMUserLoginProfile_basic
--- PASS: TestAccIAMUserPolicyAttachment_basic (56.99s)
=== CONT  TestAccIAMUserGroupMembership_basic
--- PASS: TestAccIAMUserLoginProfile_basic (47.32s)
=== CONT  TestAccIAMUserDataSource_tags
--- PASS: TestAccIAMUserDataSource_tags (26.75s)
=== CONT  TestAccIAMUserDataSource_basic
--- PASS: TestAccIAMUserDataSource_basic (24.16s)
=== CONT  TestAccIAMSigningCertificate_basic
--- PASS: TestAccIAMSigningCertificate_basic (33.13s)
=== CONT  TestAccIAMSessionContextDataSource_basic
--- PASS: TestAccIAMUserGroupMembership_basic (129.04s)
=== CONT  TestAccIAMServiceSpecificCredential_basic
--- PASS: TestAccIAMSessionContextDataSource_basic (27.33s)
=== CONT  TestAccIAMServiceLinkedRole_tags
--- PASS: TestAccIAMServiceSpecificCredential_basic (32.83s)
=== CONT  TestAccIAMServiceLinkedRole_basic
--- PASS: TestAccIAMServiceLinkedRole_basic (41.82s)
=== CONT  TestAccIAMServerCertificate_tags
--- PASS: TestAccIAMServiceLinkedRole_tags (83.77s)
=== CONT  TestAccIAMServerCertificate_basic
--- PASS: TestAccIAMServerCertificate_basic (32.54s)
=== CONT  TestAccIAMServerCertificateDataSource_basic
--- PASS: TestAccIAMServerCertificate_tags (74.06s)
=== CONT  TestAccIAMSAMLProvider_tags
--- PASS: TestAccIAMServerCertificateDataSource_basic (32.53s)
=== CONT  TestAccIAMSAMLProvider_basic
--- PASS: TestAccIAMSAMLProvider_tags (76.81s)
=== CONT  TestAccIAMSAMLProviderDataSource_basic
--- PASS: TestAccIAMSAMLProvider_basic (53.41s)
=== CONT  TestAccIAMRolesDataSource_basic
--- PASS: TestAccIAMRolesDataSource_basic (27.95s)
=== CONT  TestAccIAMRoleDataSource_tags
--- PASS: TestAccIAMSAMLProviderDataSource_basic (29.30s)
=== CONT  TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMRoleDataSource_tags
    role_data_source_test.go:48: Step 1/1 error: Check failed: 1 error occurred:
        	* Check 2/11 error: data.aws_iam_role.test: Attribute 'assume_role_policy' expected "{\"Statement\":[{\"Action\":\"sts:AssumeRole\",\"Effect\":\"Allow\",\"Principal\":{\"Service\":\"ec2.amazonaws.com\"},\"Sid\":\"\"}],\"Version\":\"2012-10-17\"}", got "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Sid\":\"\",\"Effect\":\"Allow\",\"Principal\":{\"Service\":\"ec2.amazonaws.com\"},\"Action\":\"sts:AssumeRole\"}]}"
        
--- FAIL: TestAccIAMRoleDataSource_tags (15.41s)
=== CONT  TestAccIAMRole_tags
--- PASS: TestAccIAMRole_tags (54.40s)
=== CONT  TestAccIAMOpenIDConnectProvider_tags
--- PASS: TestAccIAMRole_InlinePolicy_basic (76.10s)
=== CONT  TestAccIAMRoleDataSource_basic
    role_data_source_test.go:19: Step 1/1 error: Check failed: 1 error occurred:
        	* Check 2/9 error: data.aws_iam_role.test: Attribute 'assume_role_policy' expected "{\"Statement\":[{\"Action\":\"sts:AssumeRole\",\"Effect\":\"Allow\",\"Principal\":{\"Service\":\"ec2.amazonaws.com\"},\"Sid\":\"\"}],\"Version\":\"2012-10-17\"}", got "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Sid\":\"\",\"Effect\":\"Allow\",\"Principal\":{\"Service\":\"ec2.amazonaws.com\"},\"Action\":\"sts:AssumeRole\"}]}"
        
--- FAIL: TestAccIAMRoleDataSource_basic (14.28s)
=== CONT  TestAccIAMPolicy_tags
--- PASS: TestAccIAMOpenIDConnectProvider_tags (66.25s)
=== CONT  TestAccIAMPolicy_basic
--- PASS: TestAccIAMPolicy_tags (62.00s)
=== CONT  TestAccIAMPolicyDocumentDataSource_basic
--- PASS: TestAccIAMPolicy_basic (21.04s)
=== CONT  TestAccIAMRole_basic
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (13.24s)
=== CONT  TestAccIAMRolePolicy_basic
--- PASS: TestAccIAMRole_basic (18.70s)
=== CONT  TestAccIAMRolePolicyAttachment_basic
--- PASS: TestAccIAMRolePolicy_basic (31.84s)
=== CONT  TestAccIAMInstanceProfile_basic
--- PASS: TestAccIAMRolePolicyAttachment_basic (31.42s)
=== CONT  TestAccIAMPolicyAttachment_basic
--- PASS: TestAccIAMInstanceProfile_basic (18.61s)
=== CONT  TestAccIAMGroupPolicy_basic
--- PASS: TestAccIAMPolicyAttachment_basic (30.06s)
=== CONT  TestAccIAMInstanceProfileDataSource_basic
--- PASS: TestAccIAMGroupPolicy_basic (33.11s)
=== CONT  TestAccIAMGroup_basic
--- PASS: TestAccIAMInstanceProfileDataSource_basic (16.40s)
=== CONT  TestAccIAMOpenIDConnectProvider_basic
--- PASS: TestAccIAMGroup_basic (21.01s)
=== CONT  TestAccIAMOpenidConnectProviderDataSource_basic
    openid_connect_provider_data_source_test.go:19: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating IAM OIDC Provider: InvalidInput: Thumbprint list must contain at least one entry.
        	status code: 400, request id: b35b610a-4ee8-4245-b7df-0f739b63b123
        
          with aws_iam_openid_connect_provider.test,
          on terraform_plugin_test.tf line 2, in resource "aws_iam_openid_connect_provider" "test":
           2: resource "aws_iam_openid_connect_provider" "test" {
        
--- FAIL: TestAccIAMOpenidConnectProviderDataSource_basic (6.72s)
=== CONT  TestAccIAMInstanceProfilesDataSource_basic
--- PASS: TestAccIAMOpenIDConnectProvider_basic (32.48s)
=== CONT  TestAccIAMOpenidConnectProviderDataSource_tags
    openid_connect_provider_data_source_test.go:73: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating IAM OIDC Provider: InvalidInput: Thumbprint list must contain at least one entry.
        	status code: 400, request id: 00ef37fd-7c67-4397-ba7e-606afd02666c
        
          with aws_iam_openid_connect_provider.test,
          on terraform_plugin_test.tf line 2, in resource "aws_iam_openid_connect_provider" "test":
           2: resource "aws_iam_openid_connect_provider" "test" {
        
--- FAIL: TestAccIAMOpenidConnectProviderDataSource_tags (5.28s)
=== CONT  TestAccIAMInstanceProfile_tags
--- PASS: TestAccIAMInstanceProfilesDataSource_basic (14.43s)
=== CONT  TestAccIAMGroupPolicyAttachment_basic
--- PASS: TestAccIAMGroupPolicyAttachment_basic (25.49s)
=== CONT  TestAccIAMGroupDataSource_basic
--- PASS: TestAccIAMInstanceProfile_tags (36.98s)
=== CONT  TestAccIAMGroupMembership_basic
--- PASS: TestAccIAMGroupDataSource_basic (12.71s)
--- PASS: TestAccIAMGroupMembership_basic (30.14s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/iam	1128.263s
=== RUN   TestAccIdentityStoreGroupMembership_basic
=== PAUSE TestAccIdentityStoreGroupMembership_basic
=== RUN   TestAccIdentityStoreGroup_basic
=== PAUSE TestAccIdentityStoreGroup_basic
=== RUN   TestAccIdentityStoreUserDataSource_basic
=== PAUSE TestAccIdentityStoreUserDataSource_basic
=== RUN   TestAccIdentityStoreUser_basic
=== PAUSE TestAccIdentityStoreUser_basic
=== CONT  TestAccIdentityStoreGroupMembership_basic
=== CONT  TestAccIdentityStoreUserDataSource_basic
    group_data_source_test.go:463: skipping acceptance testing: AccessDeniedException: User: arn:aws:sts::123456789012:assumed-role/tf_aws_provider2_test-admin/kewbank@hashicorp.com is not authorized to perform: sso:ListInstances
--- SKIP: TestAccIdentityStoreUserDataSource_basic (0.91s)
=== CONT  TestAccIdentityStoreGroup_basic
=== CONT  TestAccIdentityStoreGroupMembership_basic
    user_test.go:1038: skipping acceptance testing: AccessDeniedException: User: arn:aws:sts::123456789012:assumed-role/tf_aws_provider2_test-admin/kewbank@hashicorp.com is not authorized to perform: sso:ListInstances
--- SKIP: TestAccIdentityStoreGroupMembership_basic (0.91s)
=== CONT  TestAccIdentityStoreUser_basic
    user_test.go:1038: skipping acceptance testing: AccessDeniedException: User: arn:aws:sts::123456789012:assumed-role/tf_aws_provider2_test-admin/kewbank@hashicorp.com is not authorized to perform: sso:ListInstances
--- SKIP: TestAccIdentityStoreUser_basic (0.11s)
=== CONT  TestAccIdentityStoreGroup_basic
    user_test.go:1038: skipping acceptance testing: AccessDeniedException: User: arn:aws:sts::123456789012:assumed-role/tf_aws_provider2_test-admin/kewbank@hashicorp.com is not authorized to perform: sso:ListInstances
--- SKIP: TestAccIdentityStoreGroup_basic (0.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	39.871s
=== RUN   TestAccImageBuilderComponent_basic
=== PAUSE TestAccImageBuilderComponent_basic
=== RUN   TestAccImageBuilderComponent_tags
=== PAUSE TestAccImageBuilderComponent_tags
=== RUN   TestAccImageBuilderContainerRecipe_basic
=== PAUSE TestAccImageBuilderContainerRecipe_basic
=== RUN   TestAccImageBuilderContainerRecipe_tags
=== PAUSE TestAccImageBuilderContainerRecipe_tags
=== RUN   TestAccImageBuilderDistributionConfiguration_basic
=== PAUSE TestAccImageBuilderDistributionConfiguration_basic
=== RUN   TestAccImageBuilderDistributionConfiguration_tags
=== PAUSE TestAccImageBuilderDistributionConfiguration_tags
=== RUN   TestAccImageBuilderImagePipeline_basic
=== PAUSE TestAccImageBuilderImagePipeline_basic
=== RUN   TestAccImageBuilderImagePipeline_tags
=== PAUSE TestAccImageBuilderImagePipeline_tags
=== RUN   TestAccImageBuilderImageRecipe_basic
=== PAUSE TestAccImageBuilderImageRecipe_basic
=== RUN   TestAccImageBuilderImageRecipe_tags
=== PAUSE TestAccImageBuilderImageRecipe_tags
=== RUN   TestAccImageBuilderImage_basic
=== PAUSE TestAccImageBuilderImage_basic
=== RUN   TestAccImageBuilderImage_tags
=== PAUSE TestAccImageBuilderImage_tags
=== RUN   TestAccImageBuilderInfrastructureConfiguration_basic
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_basic
=== RUN   TestAccImageBuilderInfrastructureConfiguration_tags
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_tags
=== CONT  TestAccImageBuilderComponent_basic
=== CONT  TestAccImageBuilderImagePipeline_tags
--- PASS: TestAccImageBuilderComponent_basic (72.94s)
=== CONT  TestAccImageBuilderDistributionConfiguration_basic
--- PASS: TestAccImageBuilderDistributionConfiguration_basic (63.77s)
=== CONT  TestAccImageBuilderImagePipeline_basic
--- PASS: TestAccImageBuilderImagePipeline_tags (167.49s)
=== CONT  TestAccImageBuilderDistributionConfiguration_tags
--- PASS: TestAccImageBuilderImagePipeline_basic (74.45s)
=== CONT  TestAccImageBuilderImage_tags
--- PASS: TestAccImageBuilderDistributionConfiguration_tags (104.13s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_tags
--- PASS: TestAccImageBuilderInfrastructureConfiguration_tags (87.54s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_basic
--- PASS: TestAccImageBuilderInfrastructureConfiguration_basic (48.10s)
=== CONT  TestAccImageBuilderContainerRecipe_basic
--- PASS: TestAccImageBuilderContainerRecipe_basic (41.21s)
=== CONT  TestAccImageBuilderContainerRecipe_tags
--- PASS: TestAccImageBuilderContainerRecipe_tags (87.33s)
=== CONT  TestAccImageBuilderComponent_tags
--- PASS: TestAccImageBuilderComponent_tags (91.05s)
=== CONT  TestAccImageBuilderImageRecipe_tags
--- PASS: TestAccImageBuilderImageRecipe_tags (92.33s)
=== CONT  TestAccImageBuilderImage_basic
--- PASS: TestAccImageBuilderImage_tags (947.57s)
=== CONT  TestAccImageBuilderImageRecipe_basic
--- PASS: TestAccImageBuilderImageRecipe_basic (23.75s)
--- PASS: TestAccImageBuilderImage_basic (888.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	1656.696s
=== RUN   TestAccInspectorAssessmentTarget_basic
=== PAUSE TestAccInspectorAssessmentTarget_basic
=== RUN   TestAccInspectorAssessmentTemplate_basic
=== PAUSE TestAccInspectorAssessmentTemplate_basic
=== RUN   TestAccInspectorAssessmentTemplate_tags
=== PAUSE TestAccInspectorAssessmentTemplate_tags
=== RUN   TestAccInspectorResourceGroup_basic
=== PAUSE TestAccInspectorResourceGroup_basic
=== RUN   TestAccInspectorRulesPackagesDataSource_basic
=== PAUSE TestAccInspectorRulesPackagesDataSource_basic
=== CONT  TestAccInspectorAssessmentTarget_basic
=== CONT  TestAccInspectorResourceGroup_basic
--- PASS: TestAccInspectorAssessmentTarget_basic (63.37s)
=== CONT  TestAccInspectorAssessmentTemplate_tags
--- PASS: TestAccInspectorResourceGroup_basic (91.92s)
=== CONT  TestAccInspectorAssessmentTemplate_basic
--- PASS: TestAccInspectorAssessmentTemplate_basic (62.48s)
=== CONT  TestAccInspectorRulesPackagesDataSource_basic
--- PASS: TestAccInspectorRulesPackagesDataSource_basic (43.15s)
--- PASS: TestAccInspectorAssessmentTemplate_tags (180.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector	262.231s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector2	28.392s [no tests to run]
=== RUN   TestAccIoTAuthorizer_basic
=== PAUSE TestAccIoTAuthorizer_basic
=== RUN   TestAccIoTEndpointDataSource_basic
=== PAUSE TestAccIoTEndpointDataSource_basic
=== RUN   TestAccIoTPolicyAttachment_basic
--- PASS: TestAccIoTPolicyAttachment_basic (163.23s)
=== RUN   TestAccIoTPolicy_basic
=== PAUSE TestAccIoTPolicy_basic
=== RUN   TestAccIoTProvisioningTemplate_basic
=== PAUSE TestAccIoTProvisioningTemplate_basic
=== RUN   TestAccIoTProvisioningTemplate_tags
=== PAUSE TestAccIoTProvisioningTemplate_tags
=== RUN   TestAccIoTRoleAlias_basic
=== PAUSE TestAccIoTRoleAlias_basic
=== RUN   TestAccIoTThingGroupMembership_basic
=== PAUSE TestAccIoTThingGroupMembership_basic
=== RUN   TestAccIoTThingGroup_basic
=== PAUSE TestAccIoTThingGroup_basic
=== RUN   TestAccIoTThingGroup_tags
=== PAUSE TestAccIoTThingGroup_tags
=== RUN   TestAccIoTThingPrincipalAttachment_basic
--- PASS: TestAccIoTThingPrincipalAttachment_basic (130.85s)
=== RUN   TestAccIoTThing_basic
=== PAUSE TestAccIoTThing_basic
=== RUN   TestAccIoTThingType_basic
=== PAUSE TestAccIoTThingType_basic
=== RUN   TestAccIoTThingType_tags
=== PAUSE TestAccIoTThingType_tags
=== RUN   TestAccIoTTopicRuleDestination_basic
=== PAUSE TestAccIoTTopicRuleDestination_basic
=== RUN   TestAccIoTTopicRule_basic
=== PAUSE TestAccIoTTopicRule_basic
=== RUN   TestAccIoTTopicRule_tags
=== PAUSE TestAccIoTTopicRule_tags
=== CONT  TestAccIoTAuthorizer_basic
=== CONT  TestAccIoTThingGroup_tags
--- PASS: TestAccIoTAuthorizer_basic (56.79s)
=== CONT  TestAccIoTProvisioningTemplate_tags
--- PASS: TestAccIoTThingGroup_tags (72.33s)
=== CONT  TestAccIoTThingGroup_basic
--- PASS: TestAccIoTThingGroup_basic (32.47s)
=== CONT  TestAccIoTThingGroupMembership_basic
--- PASS: TestAccIoTThingGroupMembership_basic (33.20s)
=== CONT  TestAccIoTRoleAlias_basic
--- PASS: TestAccIoTProvisioningTemplate_tags (87.29s)
=== CONT  TestAccIoTTopicRule_tags
--- PASS: TestAccIoTTopicRule_tags (77.77s)
=== CONT  TestAccIoTTopicRule_basic
--- PASS: TestAccIoTTopicRule_basic (33.39s)
=== CONT  TestAccIoTTopicRuleDestination_basic
--- PASS: TestAccIoTRoleAlias_basic (133.16s)
=== CONT  TestAccIoTPolicy_basic
--- PASS: TestAccIoTPolicy_basic (37.00s)
=== CONT  TestAccIoTProvisioningTemplate_basic
--- PASS: TestAccIoTProvisioningTemplate_basic (52.28s)
=== CONT  TestAccIoTEndpointDataSource_basic
--- PASS: TestAccIoTEndpointDataSource_basic (25.29s)
=== CONT  TestAccIoTThingType_basic
--- PASS: TestAccIoTThingType_basic (345.20s)
=== CONT  TestAccIoTThingType_tags
--- PASS: TestAccIoTTopicRuleDestination_basic (645.31s)
=== CONT  TestAccIoTThing_basic
--- PASS: TestAccIoTThing_basic (15.20s)
--- PASS: TestAccIoTThingType_tags (345.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	1427.404s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotevents	[no test files]
=== RUN   TestAccIVSChannel_basic
=== PAUSE TestAccIVSChannel_basic
=== RUN   TestAccIVSChannel_tags
=== PAUSE TestAccIVSChannel_tags
=== RUN   TestAccIVSRecordingConfiguration_basic
=== PAUSE TestAccIVSRecordingConfiguration_basic
=== RUN   TestAccIVSRecordingConfiguration_tags
=== PAUSE TestAccIVSRecordingConfiguration_tags
=== RUN   TestAccIVSStreamKeyDataSource_basic
=== PAUSE TestAccIVSStreamKeyDataSource_basic
=== CONT  TestAccIVSChannel_basic
=== CONT  TestAccIVSRecordingConfiguration_tags
--- PASS: TestAccIVSChannel_basic (63.83s)
=== CONT  TestAccIVSStreamKeyDataSource_basic
--- PASS: TestAccIVSStreamKeyDataSource_basic (51.41s)
=== CONT  TestAccIVSRecordingConfiguration_basic
--- PASS: TestAccIVSRecordingConfiguration_tags (164.18s)
=== CONT  TestAccIVSChannel_tags
--- PASS: TestAccIVSRecordingConfiguration_basic (63.63s)
--- PASS: TestAccIVSChannel_tags (89.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ivs	320.658s
=== RUN   TestAccIVSChatLoggingConfiguration_tags
=== PAUSE TestAccIVSChatLoggingConfiguration_tags
=== RUN   TestAccIVSChatRoom_basic
=== PAUSE TestAccIVSChatRoom_basic
=== RUN   TestAccIVSChatRoom_tags
=== PAUSE TestAccIVSChatRoom_tags
=== CONT  TestAccIVSChatLoggingConfiguration_tags
=== CONT  TestAccIVSChatRoom_tags
--- PASS: TestAccIVSChatRoom_tags (139.61s)
=== CONT  TestAccIVSChatRoom_basic
--- PASS: TestAccIVSChatLoggingConfiguration_tags (155.30s)
--- PASS: TestAccIVSChatRoom_basic (48.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ivschat	254.761s
FAIL
make: *** [testacc] Error 1

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added generators Relates to code generators. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/iot Issues and PRs that pertain to the iot service. service/ivs Issues and PRs that pertain to the ivs service. service/ivschat Issues and PRs that pertain to the ivschat service. size/XL Managed by automation to categorize the size of a PR. labels Apr 6, 2023
@ewbankkit ewbankkit merged commit adfc22c into main Apr 7, 2023
34 checks passed
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3c-i branch April 7, 2023 15:40
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 7, 2023
github-actions bot pushed a commit that referenced this pull request Apr 7, 2023
Update CHANGELOG.md for #30517
e3eab67
This was referenced Apr 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/iot Issues and PRs that pertain to the iot service. service/ivs Issues and PRs that pertain to the ivs service. service/ivschat Issues and PRs that pertain to the ivschat service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.63.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ewbankkit