Tech debt: Reduce tags boilerplate code - Plugin SDK resources f* (Phase 3c)

[ewbankkit]

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.
Relates #30491.
Relates #30509.
Relates #30510.
Relates #30512.
Relates #30516.
Relates #30517.
Relates #30533.

Output from Acceptance Testing

=== RUN   TestAccFISExperimentTemplate_basic
=== PAUSE TestAccFISExperimentTemplate_basic
=== CONT  TestAccFISExperimentTemplate_basic
--- PASS: TestAccFISExperimentTemplate_basic (24.02s)
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_basic\|TestAccFirehoseDeliveryStream_tags' PKG=firehose ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 2  -run=TestAccFirehoseDeliveryStream_basic\|TestAccFirehoseDeliveryStream_tags -timeout 180m
=== RUN   TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== RUN   TestAccFirehoseDeliveryStream_tags
=== PAUSE TestAccFirehoseDeliveryStream_tags
=== CONT  TestAccFirehoseDeliveryStream_basic
=== CONT  TestAccFirehoseDeliveryStream_tags
--- PASS: TestAccFirehoseDeliveryStream_tags (169.82s)
--- PASS: TestAccFirehoseDeliveryStream_basic (172.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	178.976s

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=fsx ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 360m
=== RUN   TestAccFSxBackup_basic
=== PAUSE TestAccFSxBackup_basic
=== RUN   TestAccFSxBackup_tags
=== PAUSE TestAccFSxBackup_tags
=== RUN   TestAccFSxDataRepositoryAssociation_basic
=== PAUSE TestAccFSxDataRepositoryAssociation_basic
=== RUN   TestAccFSxFileCache_basic
    file_cache_test.go:52: Step 1/2 error: Error running apply: exit status 1
        
        Error: setting Amazon FSx File Cache (fc-08be138dfd98c7965): empty result
        
          with aws_fsx_file_cache.test,
          on terraform_plugin_test.tf line 21, in resource "aws_fsx_file_cache" "test":
          21: resource "aws_fsx_file_cache" "test" {
        
--- FAIL: TestAccFSxFileCache_basic (903.25s)
=== RUN   TestAccFSxLustreFileSystem_basic
=== PAUSE TestAccFSxLustreFileSystem_basic
=== RUN   TestAccFSxLustreFileSystem_tags
=== PAUSE TestAccFSxLustreFileSystem_tags
=== RUN   TestAccFSxOntapFileSystem_basic
=== PAUSE TestAccFSxOntapFileSystem_basic
=== RUN   TestAccFSxOntapFileSystem_tags
=== PAUSE TestAccFSxOntapFileSystem_tags
=== RUN   TestAccFSxOntapStorageVirtualMachine_basic
=== PAUSE TestAccFSxOntapStorageVirtualMachine_basic
=== RUN   TestAccFSxOntapStorageVirtualMachine_tags
=== PAUSE TestAccFSxOntapStorageVirtualMachine_tags
=== RUN   TestAccFSxOntapVolume_basic
=== PAUSE TestAccFSxOntapVolume_basic
=== RUN   TestAccFSxOntapVolume_tags
=== PAUSE TestAccFSxOntapVolume_tags
=== RUN   TestAccFSxOpenzfsFileSystem_basic
=== PAUSE TestAccFSxOpenzfsFileSystem_basic
=== RUN   TestAccFSxOpenzfsFileSystem_tags
=== PAUSE TestAccFSxOpenzfsFileSystem_tags
=== RUN   TestAccFSxOpenzfsSnapshotDataSource_basic
=== PAUSE TestAccFSxOpenzfsSnapshotDataSource_basic
=== RUN   TestAccFSxOpenzfsSnapshot_basic
=== PAUSE TestAccFSxOpenzfsSnapshot_basic
=== RUN   TestAccFSxOpenzfsSnapshot_tags
=== PAUSE TestAccFSxOpenzfsSnapshot_tags
=== RUN   TestAccFSxOpenzfsVolume_basic
=== PAUSE TestAccFSxOpenzfsVolume_basic
=== RUN   TestAccFSxOpenzfsVolume_tags
=== PAUSE TestAccFSxOpenzfsVolume_tags
=== RUN   TestAccFSxWindowsFileSystem_basic
=== PAUSE TestAccFSxWindowsFileSystem_basic
=== RUN   TestAccFSxWindowsFileSystem_tags
=== PAUSE TestAccFSxWindowsFileSystem_tags
=== CONT  TestAccFSxBackup_basic
=== CONT  TestAccFSxOntapVolume_tags
=== CONT  TestAccFSxOpenzfsSnapshot_tags
--- PASS: TestAccFSxOpenzfsSnapshot_tags (825.15s)
=== CONT  TestAccFSxWindowsFileSystem_basic
--- PASS: TestAccFSxBackup_basic (865.76s)
=== CONT  TestAccFSxWindowsFileSystem_tags
--- PASS: TestAccFSxOntapVolume_tags (3400.73s)
=== CONT  TestAccFSxOntapFileSystem_basic
--- PASS: TestAccFSxWindowsFileSystem_tags (3485.48s)
=== CONT  TestAccFSxOntapVolume_basic
--- PASS: TestAccFSxWindowsFileSystem_basic (3563.36s)
=== CONT  TestAccFSxOntapStorageVirtualMachine_tags
--- PASS: TestAccFSxOntapFileSystem_basic (2436.74s)
=== CONT  TestAccFSxOntapStorageVirtualMachine_basic
--- PASS: TestAccFSxOntapStorageVirtualMachine_tags (3194.00s)
=== CONT  TestAccFSxOntapFileSystem_tags
--- PASS: TestAccFSxOntapVolume_basic (3384.68s)
=== CONT  TestAccFSxOpenzfsVolume_tags
--- PASS: TestAccFSxOpenzfsVolume_tags (867.00s)
=== CONT  TestAccFSxOpenzfsVolume_basic
--- PASS: TestAccFSxOntapStorageVirtualMachine_basic (3179.20s)
=== CONT  TestAccFSxOpenzfsSnapshotDataSource_basic
    openzfs_snapshot_data_source_test.go:21: Step 5/7 error: Check failed: Check 5/6 error: data.aws_fsx_openzfs_snapshot.test: Attribute "tags.%" is "1", but "tags.%" is not set in aws_fsx_openzfs_snapshot.test
--- PASS: TestAccFSxOpenzfsVolume_basic (820.26s)
=== CONT  TestAccFSxOpenzfsSnapshot_basic
--- FAIL: TestAccFSxOpenzfsSnapshotDataSource_basic (911.42s)
=== CONT  TestAccFSxOpenzfsFileSystem_tags
--- PASS: TestAccFSxOpenzfsSnapshot_basic (849.93s)
=== CONT  TestAccFSxOpenzfsFileSystem_basic
--- PASS: TestAccFSxOntapFileSystem_tags (2737.60s)
=== CONT  TestAccFSxLustreFileSystem_basic
--- PASS: TestAccFSxOpenzfsFileSystem_tags (728.96s)
=== CONT  TestAccFSxLustreFileSystem_tags
--- PASS: TestAccFSxOpenzfsFileSystem_basic (714.40s)
=== CONT  TestAccFSxDataRepositoryAssociation_basic
--- PASS: TestAccFSxLustreFileSystem_basic (690.74s)
=== CONT  TestAccFSxBackup_tags
=== CONT  TestAccFSxDataRepositoryAssociation_basic
    data_repository_association_test.go:34: Step 1/2 error: Error running apply: exit status 1
        
        Error: error creating S3 bucket ACL for tf-acc-test-6065719612061232000: AccessControlListNotSupported: The bucket does not allow ACLs
        	status code: 400, request id: AF1KEKC0TWP6RYCH, host id: wrIzSkw6jKJT2gZlPGC6Z8Q+poyD7BwdvCj+kCkNhKHEWEwKbapE/QHZQdeY2/BSxlAFmJF19tk=
        
          with aws_s3_bucket_acl.test,
          on terraform_plugin_test.tf line 34, in resource "aws_s3_bucket_acl" "test":
          34: resource "aws_s3_bucket_acl" "test" {
        
--- PASS: TestAccFSxLustreFileSystem_tags (704.48s)
--- FAIL: TestAccFSxDataRepositoryAssociation_basic (823.05s)
--- PASS: TestAccFSxBackup_tags (849.08s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	12768.605s
FAIL
make: *** [testacc] Error 1

 % ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccFSxFileCache_serial/basic\|TestAccFSxFileCache_serial/tags\|TestAccFSxDataRepositoryAssociation_basic' PKG=fsx ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxFileCache_serial/basic\|TestAccFSxFileCache_serial/tags\|TestAccFSxDataRepositoryAssociation_basic -timeout 360m
=== RUN   TestAccFSxDataRepositoryAssociation_basic
=== PAUSE TestAccFSxDataRepositoryAssociation_basic
=== RUN   TestAccFSxFileCache_serial
=== PAUSE TestAccFSxFileCache_serial
=== CONT  TestAccFSxDataRepositoryAssociation_basic
=== CONT  TestAccFSxFileCache_serial
--- PASS: TestAccFSxFileCache_serial (0.00s)
--- PASS: TestAccFSxDataRepositoryAssociation_basic (668.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	673.585s

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccFSxFileCache_serial/FSxFileCache/basic\|TestAccFSxFileCache_serial/FSxFileCache/tags' PKG=fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20  -run=TestAccFSxFileCache_serial/FSxFileCache/basic\|TestAccFSxFileCache_serial/FSxFileCache/tags -timeout 360m
=== RUN   TestAccFSxFileCache_serial
=== PAUSE TestAccFSxFileCache_serial
=== CONT  TestAccFSxFileCache_serial
=== RUN   TestAccFSxFileCache_serial/FSxFileCache
=== RUN   TestAccFSxFileCache_serial/FSxFileCache/tags
=== RUN   TestAccFSxFileCache_serial/FSxFileCache/copy_tags_to_data_repository_associations
=== RUN   TestAccFSxFileCache_serial/FSxFileCache/basic
--- PASS: TestAccFSxFileCache_serial (2838.36s)
    --- PASS: TestAccFSxFileCache_serial/FSxFileCache (2838.36s)
        --- PASS: TestAccFSxFileCache_serial/FSxFileCache/tags (1052.77s)
        --- PASS: TestAccFSxFileCache_serial/FSxFileCache/copy_tags_to_data_repository_associations (873.11s)
        --- PASS: TestAccFSxFileCache_serial/FSxFileCache/basic (912.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2843.388s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.