Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Reduce tags boilerplate code - Plugin SDK resources, the stragglers and oddballs #30677

Merged
merged 27 commits into from
Apr 13, 2023
Merged

Tech debt: Reduce tags boilerplate code - Plugin SDK resources, the stragglers and oddballs #30677

merged 27 commits into from
Apr 13, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 12, 2023 •
edited

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.
Relates #30491.
Relates #30509.
Relates #30510.
Relates #30512.
Relates #30516.
Relates #30517.
Relates #30533.
Relates #30534.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAPIGatewayV2API_' PKG=apigatewayv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 3  -run=TestAccAPIGatewayV2API_ -timeout 180m
=== RUN   TestAccAPIGatewayV2API_basicWebSocket
=== PAUSE TestAccAPIGatewayV2API_basicWebSocket
=== RUN   TestAccAPIGatewayV2API_basicHTTP
=== PAUSE TestAccAPIGatewayV2API_basicHTTP
=== RUN   TestAccAPIGatewayV2API_disappears
=== PAUSE TestAccAPIGatewayV2API_disappears
=== RUN   TestAccAPIGatewayV2API_allAttributesWebSocket
=== PAUSE TestAccAPIGatewayV2API_allAttributesWebSocket
=== RUN   TestAccAPIGatewayV2API_allAttributesHTTP
=== PAUSE TestAccAPIGatewayV2API_allAttributesHTTP
=== RUN   TestAccAPIGatewayV2API_openAPI
=== PAUSE TestAccAPIGatewayV2API_openAPI
=== RUN   TestAccAPIGatewayV2API_OpenAPI_withTags
=== PAUSE TestAccAPIGatewayV2API_OpenAPI_withTags
=== RUN   TestAccAPIGatewayV2API_OpenAPI_withCors
=== PAUSE TestAccAPIGatewayV2API_OpenAPI_withCors
=== RUN   TestAccAPIGatewayV2API_OpenAPI_withMoreFields
=== PAUSE TestAccAPIGatewayV2API_OpenAPI_withMoreFields
=== RUN   TestAccAPIGatewayV2API_OpenAPI_failOnWarnings
=== PAUSE TestAccAPIGatewayV2API_OpenAPI_failOnWarnings
=== RUN   TestAccAPIGatewayV2API_tags
=== PAUSE TestAccAPIGatewayV2API_tags
=== RUN   TestAccAPIGatewayV2API_cors
=== PAUSE TestAccAPIGatewayV2API_cors
=== RUN   TestAccAPIGatewayV2API_quickCreate
=== PAUSE TestAccAPIGatewayV2API_quickCreate
=== CONT  TestAccAPIGatewayV2API_basicWebSocket
=== CONT  TestAccAPIGatewayV2API_OpenAPI_withCors
=== CONT  TestAccAPIGatewayV2API_tags
--- PASS: TestAccAPIGatewayV2API_basicWebSocket (25.13s)
=== CONT  TestAccAPIGatewayV2API_OpenAPI_failOnWarnings
--- PASS: TestAccAPIGatewayV2API_tags (39.94s)
=== CONT  TestAccAPIGatewayV2API_quickCreate
--- PASS: TestAccAPIGatewayV2API_OpenAPI_withCors (60.79s)
=== CONT  TestAccAPIGatewayV2API_OpenAPI_withMoreFields
--- PASS: TestAccAPIGatewayV2API_quickCreate (26.52s)
=== CONT  TestAccAPIGatewayV2API_allAttributesHTTP
--- PASS: TestAccAPIGatewayV2API_OpenAPI_failOnWarnings (57.07s)
=== CONT  TestAccAPIGatewayV2API_OpenAPI_withTags
--- PASS: TestAccAPIGatewayV2API_OpenAPI_withMoreFields (51.02s)
=== CONT  TestAccAPIGatewayV2API_openAPI
--- PASS: TestAccAPIGatewayV2API_OpenAPI_withTags (50.25s)
=== CONT  TestAccAPIGatewayV2API_disappears
--- PASS: TestAccAPIGatewayV2API_allAttributesHTTP (74.23s)
=== CONT  TestAccAPIGatewayV2API_allAttributesWebSocket
--- PASS: TestAccAPIGatewayV2API_disappears (20.04s)
=== CONT  TestAccAPIGatewayV2API_cors
--- PASS: TestAccAPIGatewayV2API_openAPI (47.10s)
=== CONT  TestAccAPIGatewayV2API_basicHTTP
--- PASS: TestAccAPIGatewayV2API_basicHTTP (23.53s)
--- PASS: TestAccAPIGatewayV2API_cors (51.70s)
--- PASS: TestAccAPIGatewayV2API_allAttributesWebSocket (65.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	212.443s
% make testacc TESTARGS='-run=TestAccAppFlowFlow_' PKG=appflow ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 3  -run=TestAccAppFlowFlow_ -timeout 180m
=== RUN   TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN   TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== PAUSE TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
=== RUN   TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN   TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN   TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN   TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT  TestAccAppFlowFlow_basic
=== CONT  TestAccAppFlowFlow_TaskProperties
=== CONT  TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_TaskProperties (23.79s)
=== CONT  TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_disappears (23.91s)
=== CONT  TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_basic (27.52s)
=== CONT  TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType
--- PASS: TestAccAppFlowFlow_update (39.43s)
--- PASS: TestAccAppFlowFlow_S3_outputFormatConfig_ParquetFileType (39.60s)
--- PASS: TestAccAppFlowFlow_tags (58.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	87.880s
% make testacc TESTARGS='-run=TestAccEC2Tag_\|TestAccEC2AMICopy_tags\|TestAccEC2AMICopy_basic\|TestAccEC2AMI_basic\|TestAccEC2AMI_tags\|TestAccEC2Instance_basic\|TestAccEC2Instance_BlockDeviceTags\|TestAccVPCDefaultRouteTable_basic\|TestAccVPCDefaultRouteTable_tags\|TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount' PKG=ec2 ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2Tag_\|TestAccEC2AMICopy_tags\|TestAccEC2AMICopy_basic\|TestAccEC2AMI_basic\|TestAccEC2AMI_tags\|TestAccEC2Instance_basic\|TestAccEC2Instance_BlockDeviceTags\|TestAccVPCDefaultRouteTable_basic\|TestAccVPCDefaultRouteTable_tags\|TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount -timeout 180m
=== RUN   TestAccEC2AMICopy_basic
=== PAUSE TestAccEC2AMICopy_basic
=== RUN   TestAccEC2AMICopy_tags
=== PAUSE TestAccEC2AMICopy_tags
=== RUN   TestAccEC2AMI_basic
=== PAUSE TestAccEC2AMI_basic
=== RUN   TestAccEC2AMI_tags
=== PAUSE TestAccEC2AMI_tags
=== RUN   TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN   TestAccEC2Instance_BlockDeviceTags_volumeTags
=== PAUSE TestAccEC2Instance_BlockDeviceTags_volumeTags
=== RUN   TestAccEC2Instance_BlockDeviceTags_withAttachedVolume
=== PAUSE TestAccEC2Instance_BlockDeviceTags_withAttachedVolume
=== RUN   TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== PAUSE TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== RUN   TestAccEC2Tag_basic
=== PAUSE TestAccEC2Tag_basic
=== RUN   TestAccEC2Tag_disappears
=== PAUSE TestAccEC2Tag_disappears
=== RUN   TestAccEC2Tag_value
=== PAUSE TestAccEC2Tag_value
=== RUN   TestAccVPCDefaultRouteTable_basic
=== PAUSE TestAccVPCDefaultRouteTable_basic
=== RUN   TestAccVPCDefaultRouteTable_tags
=== PAUSE TestAccVPCDefaultRouteTable_tags
=== RUN   TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount
=== PAUSE TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount
=== CONT  TestAccEC2AMICopy_basic
=== CONT  TestAccEC2Instance_BlockDeviceTags_ebsAndRoot
=== CONT  TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount
--- PASS: TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount (48.45s)
=== CONT  TestAccVPCDefaultRouteTable_tags
--- PASS: TestAccVPCDefaultRouteTable_tags (56.80s)
=== CONT  TestAccVPCDefaultRouteTable_basic
--- PASS: TestAccVPCDefaultRouteTable_basic (36.81s)
=== CONT  TestAccEC2Tag_value
--- PASS: TestAccEC2AMICopy_basic (157.51s)
=== CONT  TestAccEC2Tag_disappears
--- PASS: TestAccEC2Instance_BlockDeviceTags_ebsAndRoot (198.29s)
=== CONT  TestAccEC2Tag_basic
--- PASS: TestAccEC2Tag_disappears (414.24s)
=== CONT  TestAccEC2Instance_basic
--- PASS: TestAccEC2Tag_value (452.85s)
=== CONT  TestAccEC2Instance_BlockDeviceTags_withAttachedVolume
--- PASS: TestAccEC2Tag_basic (398.25s)
=== CONT  TestAccEC2Instance_BlockDeviceTags_volumeTags
--- PASS: TestAccEC2Instance_basic (138.96s)
=== CONT  TestAccEC2AMI_basic
--- PASS: TestAccEC2AMI_basic (89.31s)
=== CONT  TestAccEC2AMI_tags
--- PASS: TestAccEC2Instance_BlockDeviceTags_withAttachedVolume (226.95s)
=== CONT  TestAccEC2AMICopy_tags
--- PASS: TestAccEC2Instance_BlockDeviceTags_volumeTags (303.83s)
--- PASS: TestAccEC2AMI_tags (117.85s)
--- PASS: TestAccEC2AMICopy_tags (190.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1025.822s
--- PASS: TestAccDSRegion_tags (8984.93s)
--- PASS: TestAccDSRegion_basic (8999.00s)

% make testacc TESTARGS='-run=TestAccVPCRouteTable_basic\|TestAccVPCRouteTable_tags\|TestAccVPCDefaultRouteTable_basic\|TestAccVPCDefaultRouteTable_tags' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCRouteTable_basic\|TestAccVPCRouteTable_tags\|TestAccVPCDefaultRouteTable_basic\|TestAccVPCDefaultRouteTable_tags -timeout 180m
=== RUN   TestAccVPCDefaultRouteTable_basic
=== PAUSE TestAccVPCDefaultRouteTable_basic
=== RUN   TestAccVPCDefaultRouteTable_tags
=== PAUSE TestAccVPCDefaultRouteTable_tags
=== RUN   TestAccVPCRouteTable_basic
=== PAUSE TestAccVPCRouteTable_basic
=== RUN   TestAccVPCRouteTable_tags
=== PAUSE TestAccVPCRouteTable_tags
=== CONT  TestAccVPCDefaultRouteTable_basic
=== CONT  TestAccVPCRouteTable_basic
--- PASS: TestAccVPCRouteTable_basic (22.70s)
=== CONT  TestAccVPCRouteTable_tags
--- PASS: TestAccVPCDefaultRouteTable_basic (30.63s)
=== CONT  TestAccVPCDefaultRouteTable_tags
--- PASS: TestAccVPCRouteTable_tags (48.39s)
--- PASS: TestAccVPCDefaultRouteTable_tags (42.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	79.043s
% make testacc TESTARGS='-run=TestAccImageBuilderImagePipeline_basic\|TestAccImageBuilderImagePipeline_tags' PKG=imagebuilder ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/imagebuilder/... -v -count 1 -parallel 2  -run=TestAccImageBuilderImagePipeline_basic\|TestAccImageBuilderImagePipeline_tags -timeout 180m
=== RUN   TestAccImageBuilderImagePipeline_basic
=== PAUSE TestAccImageBuilderImagePipeline_basic
=== RUN   TestAccImageBuilderImagePipeline_tags
=== PAUSE TestAccImageBuilderImagePipeline_tags
=== CONT  TestAccImageBuilderImagePipeline_basic
=== CONT  TestAccImageBuilderImagePipeline_tags
--- PASS: TestAccImageBuilderImagePipeline_basic (30.72s)
--- PASS: TestAccImageBuilderImagePipeline_tags (55.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	60.548s
% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccLightsailDistribution_serial/distribution' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDistribution_serial/distribution -timeout 180m
=== RUN   TestAccLightsailDistribution_serial
=== PAUSE TestAccLightsailDistribution_serial
=== CONT  TestAccLightsailDistribution_serial
=== RUN   TestAccLightsailDistribution_serial/distribution
=== RUN   TestAccLightsailDistribution_serial/distribution/cache_behavior
=== RUN   TestAccLightsailDistribution_serial/distribution/cache_behavior_settings
=== RUN   TestAccLightsailDistribution_serial/distribution/default_cache_behavior
=== RUN   TestAccLightsailDistribution_serial/distribution/ip_address_type
=== RUN   TestAccLightsailDistribution_serial/distribution/tags
=== RUN   TestAccLightsailDistribution_serial/distribution/basic
=== RUN   TestAccLightsailDistribution_serial/distribution/disappears
=== RUN   TestAccLightsailDistribution_serial/distribution/is_enabled
--- PASS: TestAccLightsailDistribution_serial (5018.80s)
    --- PASS: TestAccLightsailDistribution_serial/distribution (5018.80s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior (654.38s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/cache_behavior_settings (706.84s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/default_cache_behavior (696.37s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/ip_address_type (656.62s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/tags (360.67s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/basic (340.19s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/disappears (344.79s)
        --- PASS: TestAccLightsailDistribution_serial/distribution/is_enabled (1258.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	5024.093s
% make testacc TESTARGS='-run=TestAccMemoryDBUser_basic\|TestAccMemoryDBUser_tags' PKG=memorydb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/memorydb/... -v -count 1 -parallel 2  -run=TestAccMemoryDBUser_basic\|TestAccMemoryDBUser_tags -timeout 180m
=== RUN   TestAccMemoryDBUser_basic
=== PAUSE TestAccMemoryDBUser_basic
=== RUN   TestAccMemoryDBUser_tags
=== PAUSE TestAccMemoryDBUser_tags
=== CONT  TestAccMemoryDBUser_basic
=== CONT  TestAccMemoryDBUser_tags
--- PASS: TestAccMemoryDBUser_basic (24.13s)
--- PASS: TestAccMemoryDBUser_tags (84.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	89.152s
% make testacc TESTARGS='-run=TestAccWAFRegionalWebACL_basic\|TestAccWAFRegionalWebACL_tags' PKG=wafregional ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/wafregional/... -v -count 1 -parallel 2  -run=TestAccWAFRegionalWebACL_basic\|TestAccWAFRegionalWebACL_tags -timeout 180m
=== RUN   TestAccWAFRegionalWebACL_basic
=== PAUSE TestAccWAFRegionalWebACL_basic
=== RUN   TestAccWAFRegionalWebACL_tags
=== PAUSE TestAccWAFRegionalWebACL_tags
=== CONT  TestAccWAFRegionalWebACL_basic
=== CONT  TestAccWAFRegionalWebACL_tags
--- PASS: TestAccWAFRegionalWebACL_basic (36.04s)
--- PASS: TestAccWAFRegionalWebACL_tags (75.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafregional	81.618s
% make testacc TESTARGS='-run=TestAccRDSParameterGroup_basic\|TestAccRDSParameterGroup_tags\|TestAccRDSClusterParameterGroup_tags\|TestAccRDSClusterParameterGroup_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSParameterGroup_basic\|TestAccRDSParameterGroup_tags\|TestAccRDSClusterParameterGroup_tags\|TestAccRDSClusterParameterGroup_basic -timeout 180m
=== RUN   TestAccRDSClusterParameterGroup_basic
=== PAUSE TestAccRDSClusterParameterGroup_basic
=== RUN   TestAccRDSClusterParameterGroup_tags
=== PAUSE TestAccRDSClusterParameterGroup_tags
=== RUN   TestAccRDSParameterGroup_basic
=== PAUSE TestAccRDSParameterGroup_basic
=== RUN   TestAccRDSParameterGroup_tags
=== PAUSE TestAccRDSParameterGroup_tags
=== CONT  TestAccRDSClusterParameterGroup_basic
=== CONT  TestAccRDSParameterGroup_basic
--- PASS: TestAccRDSClusterParameterGroup_basic (48.10s)
=== CONT  TestAccRDSClusterParameterGroup_tags
--- PASS: TestAccRDSParameterGroup_basic (52.56s)
=== CONT  TestAccRDSParameterGroup_tags
--- PASS: TestAccRDSClusterParameterGroup_tags (41.76s)
--- PASS: TestAccRDSParameterGroup_tags (47.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	105.285s
% make testacc TESTARGS='-run=TestAccRDSClusterParameterGroup_' PKG=rds ACCTEST_PARALLELISM=2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterParameterGroup_ -timeout 180m
=== RUN   TestAccRDSClusterParameterGroup_basic
=== PAUSE TestAccRDSClusterParameterGroup_basic
=== RUN   TestAccRDSClusterParameterGroup_disappears
=== PAUSE TestAccRDSClusterParameterGroup_disappears
=== RUN   TestAccRDSClusterParameterGroup_tags
=== PAUSE TestAccRDSClusterParameterGroup_tags
=== RUN   TestAccRDSClusterParameterGroup_withApplyMethod
=== PAUSE TestAccRDSClusterParameterGroup_withApplyMethod
=== RUN   TestAccRDSClusterParameterGroup_namePrefix
=== PAUSE TestAccRDSClusterParameterGroup_namePrefix
=== RUN   TestAccRDSClusterParameterGroup_NamePrefix_parameter
=== PAUSE TestAccRDSClusterParameterGroup_NamePrefix_parameter
=== RUN   TestAccRDSClusterParameterGroup_generatedName
=== PAUSE TestAccRDSClusterParameterGroup_generatedName
=== RUN   TestAccRDSClusterParameterGroup_GeneratedName_parameter
=== PAUSE TestAccRDSClusterParameterGroup_GeneratedName_parameter
=== RUN   TestAccRDSClusterParameterGroup_only
=== PAUSE TestAccRDSClusterParameterGroup_only
=== RUN   TestAccRDSClusterParameterGroup_updateParameters
=== PAUSE TestAccRDSClusterParameterGroup_updateParameters
=== RUN   TestAccRDSClusterParameterGroup_caseParameters
=== PAUSE TestAccRDSClusterParameterGroup_caseParameters
=== RUN   TestAccRDSClusterParameterGroup_dynamicDiffs
=== PAUSE TestAccRDSClusterParameterGroup_dynamicDiffs
=== CONT  TestAccRDSClusterParameterGroup_basic
=== CONT  TestAccRDSClusterParameterGroup_generatedName
--- PASS: TestAccRDSClusterParameterGroup_generatedName (23.32s)
=== CONT  TestAccRDSClusterParameterGroup_withApplyMethod
--- PASS: TestAccRDSClusterParameterGroup_withApplyMethod (23.32s)
=== CONT  TestAccRDSClusterParameterGroup_NamePrefix_parameter
--- PASS: TestAccRDSClusterParameterGroup_NamePrefix_parameter (20.27s)
=== CONT  TestAccRDSClusterParameterGroup_namePrefix
--- PASS: TestAccRDSClusterParameterGroup_basic (72.97s)
=== CONT  TestAccRDSClusterParameterGroup_tags
--- PASS: TestAccRDSClusterParameterGroup_namePrefix (20.65s)
=== CONT  TestAccRDSClusterParameterGroup_updateParameters
--- PASS: TestAccRDSClusterParameterGroup_tags (46.60s)
=== CONT  TestAccRDSClusterParameterGroup_dynamicDiffs
--- PASS: TestAccRDSClusterParameterGroup_updateParameters (32.62s)
=== CONT  TestAccRDSClusterParameterGroup_caseParameters
--- PASS: TestAccRDSClusterParameterGroup_dynamicDiffs (16.62s)
=== CONT  TestAccRDSClusterParameterGroup_disappears
--- PASS: TestAccRDSClusterParameterGroup_disappears (17.65s)
=== CONT  TestAccRDSClusterParameterGroup_only
--- PASS: TestAccRDSClusterParameterGroup_caseParameters (36.49s)
=== CONT  TestAccRDSClusterParameterGroup_GeneratedName_parameter
--- PASS: TestAccRDSClusterParameterGroup_only (21.85s)
--- PASS: TestAccRDSClusterParameterGroup_GeneratedName_parameter (21.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	185.855s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Apr 12, 2023
@github-actions github-actions bot added generators Relates to code generators. service/appflow Issues and PRs that pertain to the appflow service. labels Apr 12, 2023
@github-actions github-actions bot added service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ecs Issues and PRs that pertain to the ecs service. service/transfer Issues and PRs that pertain to the transfer service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpc Issues and PRs that pertain to the vpc service. tags Pertains to resource tagging. labels Apr 12, 2023
@github-actions github-actions bot added the service/ds Issues and PRs that pertain to the ds service. label Apr 13, 2023
@github-actions github-actions bot added service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/lightsail Issues and PRs that pertain to the lightsail service. service/memorydb Issues and PRs that pertain to the memorydb service. labels Apr 13, 2023
@github-actions github-actions bot added service/iam Issues and PRs that pertain to the iam service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/wafregional Issues and PRs that pertain to the wafregional service. labels Apr 13, 2023
@ewbankkit ewbankkit force-pushed the td-transparent-tagging-phase3-mopping-up branch from 6454973 to 99b6237 Compare April 13, 2023 16:03
@ewbankkit ewbankkit marked this pull request as ready for review April 13, 2023 16:11
@ewbankkit ewbankkit merged commit 050237e into main Apr 13, 2023
39 checks passed
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3-mopping-up branch April 13, 2023 16:53
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 13, 2023
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appflow Issues and PRs that pertain to the appflow service. service/ds Issues and PRs that pertain to the ds service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/lightsail Issues and PRs that pertain to the lightsail service. service/memorydb Issues and PRs that pertain to the memorydb service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/transfer Issues and PRs that pertain to the transfer service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/vpc Issues and PRs that pertain to the vpc service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/wafregional Issues and PRs that pertain to the wafregional service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.63.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ewbankkit