Tech debt: Reduce tags boilerplate code - Plugin SDK resources n* (Phase 3c)

[ewbankkit]

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.

Output from Acceptance Testing

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=n... ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/n.../... -v -count 1 -parallel 2  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccNeptuneClusterEndpoint_basic
=== PAUSE TestAccNeptuneClusterEndpoint_basic
=== RUN   TestAccNeptuneClusterEndpoint_tags
=== PAUSE TestAccNeptuneClusterEndpoint_tags
=== RUN   TestAccNeptuneClusterInstance_basic
=== PAUSE TestAccNeptuneClusterInstance_basic
=== RUN   TestAccNeptuneClusterInstance_tags
=== PAUSE TestAccNeptuneClusterInstance_tags
=== RUN   TestAccNeptuneClusterParameterGroup_basic
=== PAUSE TestAccNeptuneClusterParameterGroup_basic
=== RUN   TestAccNeptuneClusterParameterGroup_tags
=== PAUSE TestAccNeptuneClusterParameterGroup_tags
=== RUN   TestAccNeptuneClusterSnapshot_basic
=== PAUSE TestAccNeptuneClusterSnapshot_basic
=== RUN   TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN   TestAccNeptuneCluster_tags
=== PAUSE TestAccNeptuneCluster_tags
=== RUN   TestAccNeptuneEngineVersionDataSource_basic
=== PAUSE TestAccNeptuneEngineVersionDataSource_basic
=== RUN   TestAccNeptuneEventSubscription_basic
=== PAUSE TestAccNeptuneEventSubscription_basic
=== RUN   TestAccNeptuneGlobalCluster_basic
=== PAUSE TestAccNeptuneGlobalCluster_basic
=== RUN   TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
=== PAUSE TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
=== RUN   TestAccNeptuneOrderableDBInstanceDataSource_basic
=== PAUSE TestAccNeptuneOrderableDBInstanceDataSource_basic
=== RUN   TestAccNeptuneParameterGroup_basic
=== PAUSE TestAccNeptuneParameterGroup_basic
=== RUN   TestAccNeptuneParameterGroup_tags
=== PAUSE TestAccNeptuneParameterGroup_tags
=== RUN   TestAccNeptuneSubnetGroup_basic
=== PAUSE TestAccNeptuneSubnetGroup_basic
=== RUN   TestAccNeptuneSubnetGroup_tags
=== PAUSE TestAccNeptuneSubnetGroup_tags
=== CONT  TestAccNeptuneClusterEndpoint_basic
=== CONT  TestAccNeptuneEngineVersionDataSource_basic
    engine_version_data_source_test.go:21: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: no Neptune engine versions found
        
          with data.aws_neptune_engine_version.test,
          on terraform_plugin_test.tf line 2, in data "aws_neptune_engine_version" "test":
           2: data "aws_neptune_engine_version" "test" {
        
--- FAIL: TestAccNeptuneEngineVersionDataSource_basic (8.00s)
=== CONT  TestAccNeptuneClusterParameterGroup_tags
=== CONT  TestAccNeptuneClusterEndpoint_basic
    cluster_endpoint_test.go:27: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating Neptune Cluster (tf-acc-1944049885460282947): InvalidParameterCombination: The Parameter Group default.neptune1 with DBParameterGroupFamily neptune1 cannot be used for this instance. Please use a Parameter Group with DBParameterGroupFamily neptune1.2
        	status code: 400, request id: df5f1acb-f77c-49ef-8721-cdcd08076467
        
          with aws_neptune_cluster.test,
          on terraform_plugin_test.tf line 15, in resource "aws_neptune_cluster" "test":
          15: resource "aws_neptune_cluster" "test" {
        
=== CONT  TestAccNeptuneCluster_tags
--- FAIL: TestAccNeptuneClusterEndpoint_basic (15.83s)
--- PASS: TestAccNeptuneClusterParameterGroup_tags (57.91s)
=== CONT  TestAccNeptuneCluster_basic
--- PASS: TestAccNeptuneCluster_basic (142.32s)
=== CONT  TestAccNeptuneClusterSnapshot_basic
--- PASS: TestAccNeptuneCluster_tags (196.80s)
=== CONT  TestAccNeptuneClusterInstance_tags
--- PASS: TestAccNeptuneClusterSnapshot_basic (258.47s)
=== CONT  TestAccNeptuneClusterParameterGroup_basic
--- PASS: TestAccNeptuneClusterParameterGroup_basic (15.74s)
=== CONT  TestAccNeptuneClusterInstance_basic
--- PASS: TestAccNeptuneClusterInstance_tags (1160.27s)
=== CONT  TestAccNeptuneParameterGroup_basic
--- PASS: TestAccNeptuneParameterGroup_basic (15.74s)
=== CONT  TestAccNeptuneSubnetGroup_tags
--- PASS: TestAccNeptuneSubnetGroup_tags (55.98s)
=== CONT  TestAccNeptuneSubnetGroup_basic
--- PASS: TestAccNeptuneSubnetGroup_basic (23.85s)
=== CONT  TestAccNeptuneParameterGroup_tags
--- PASS: TestAccNeptuneParameterGroup_tags (36.97s)
=== CONT  TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic
--- PASS: TestAccNeptuneGlobalCluster_SourceDBClusterIdentifier_basic (160.96s)
=== CONT  TestAccNeptuneOrderableDBInstanceDataSource_basic
    orderable_db_instance_data_source_test.go:23: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: reading Neptune orderable DB instance options: InvalidParameterCombination: Cannot find version 1.0.2.2 for neptune
        	status code: 400, request id: 6ba6230f-cb4c-4642-aee9-516fa968a627
        
          with data.aws_neptune_orderable_db_instance.test,
          on terraform_plugin_test.tf line 2, in data "aws_neptune_orderable_db_instance" "test":
           2: data "aws_neptune_orderable_db_instance" "test" {
        
--- FAIL: TestAccNeptuneOrderableDBInstanceDataSource_basic (3.38s)
=== CONT  TestAccNeptuneGlobalCluster_basic
--- PASS: TestAccNeptuneGlobalCluster_basic (16.67s)
=== CONT  TestAccNeptuneClusterEndpoint_tags
    cluster_endpoint_test.go:65: Step 1/4 error: Error running apply: exit status 1
        
        Error: creating Neptune Cluster (tf-acc-8278715406083454647): InvalidParameterCombination: The Parameter Group default.neptune1 with DBParameterGroupFamily neptune1 cannot be used for this instance. Please use a Parameter Group with DBParameterGroupFamily neptune1.2
        	status code: 400, request id: c8792a31-7e2f-4839-80f9-71c716c2ef57
        
          with aws_neptune_cluster.test,
          on terraform_plugin_test.tf line 15, in resource "aws_neptune_cluster" "test":
          15: resource "aws_neptune_cluster" "test" {
        
--- FAIL: TestAccNeptuneClusterEndpoint_tags (7.57s)
=== CONT  TestAccNeptuneEventSubscription_basic
--- PASS: TestAccNeptuneClusterInstance_basic (1262.35s)
--- PASS: TestAccNeptuneEventSubscription_basic (118.98s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	1822.026s
=== RUN   TestAccNetworkFirewallFirewallPolicy_basic
=== PAUSE TestAccNetworkFirewallFirewallPolicy_basic
=== RUN   TestAccNetworkFirewallFirewallPolicy_tags
=== PAUSE TestAccNetworkFirewallFirewallPolicy_tags
=== RUN   TestAccNetworkFirewallFirewall_basic
=== PAUSE TestAccNetworkFirewallFirewall_basic
=== RUN   TestAccNetworkFirewallFirewall_tags
=== PAUSE TestAccNetworkFirewallFirewall_tags
=== RUN   TestAccNetworkFirewallResourcePolicy_basic
=== PAUSE TestAccNetworkFirewallResourcePolicy_basic
=== RUN   TestAccNetworkFirewallRuleGroup_tags
=== PAUSE TestAccNetworkFirewallRuleGroup_tags
=== CONT  TestAccNetworkFirewallFirewallPolicy_basic
=== CONT  TestAccNetworkFirewallFirewall_tags
--- PASS: TestAccNetworkFirewallFirewallPolicy_basic (154.69s)
=== CONT  TestAccNetworkFirewallRuleGroup_tags
--- PASS: TestAccNetworkFirewallRuleGroup_tags (161.33s)
=== CONT  TestAccNetworkFirewallFirewall_basic
--- PASS: TestAccNetworkFirewallFirewall_tags (1104.95s)
=== CONT  TestAccNetworkFirewallResourcePolicy_basic
    acctest.go:1300: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: error putting NetworkFirewall Resource Policy (for resource: arn:aws:network-firewall:us-west-2:123456789012:firewall-policy/tf-acc-test-2116292379653672618): InvalidResourcePolicyException: The supplied policy does not match RAM managed permissions.
        
          with aws_networkfirewall_resource_policy.test,
          on terraform_plugin_test.tf line 14, in resource "aws_networkfirewall_resource_policy" "test":
          14: resource "aws_networkfirewall_resource_policy" "test" {
        
--- SKIP: TestAccNetworkFirewallResourcePolicy_basic (144.33s)
=== CONT  TestAccNetworkFirewallFirewallPolicy_tags
--- PASS: TestAccNetworkFirewallFirewallPolicy_tags (162.22s)
--- PASS: TestAccNetworkFirewallFirewall_basic (1105.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	1430.243s
=== RUN   TestAccNetworkManagerConnectAttachment_basic
=== PAUSE TestAccNetworkManagerConnectAttachment_basic
=== RUN   TestAccNetworkManagerConnectAttachment_tags
=== PAUSE TestAccNetworkManagerConnectAttachment_tags
=== RUN   TestAccNetworkManagerConnectPeer_basic
=== PAUSE TestAccNetworkManagerConnectPeer_basic
=== RUN   TestAccNetworkManagerConnectPeer_tags
=== PAUSE TestAccNetworkManagerConnectPeer_tags
=== RUN   TestAccNetworkManagerConnectionDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionDataSource_basic
=== RUN   TestAccNetworkManagerConnectionsDataSource_basic
=== PAUSE TestAccNetworkManagerConnectionsDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== RUN   TestAccNetworkManagerCoreNetwork_basic
=== PAUSE TestAccNetworkManagerCoreNetwork_basic
=== RUN   TestAccNetworkManagerCoreNetwork_tags
=== PAUSE TestAccNetworkManagerCoreNetwork_tags
=== RUN   TestAccNetworkManagerDeviceDataSource_basic
=== PAUSE TestAccNetworkManagerDeviceDataSource_basic
=== RUN   TestAccNetworkManagerDevice_basic
=== PAUSE TestAccNetworkManagerDevice_basic
=== RUN   TestAccNetworkManagerDevice_tags
=== PAUSE TestAccNetworkManagerDevice_tags
=== RUN   TestAccNetworkManagerDevicesDataSource_basic
=== PAUSE TestAccNetworkManagerDevicesDataSource_basic
=== RUN   TestAccNetworkManagerGlobalNetworkDataSource_basic
=== PAUSE TestAccNetworkManagerGlobalNetworkDataSource_basic
=== RUN   TestAccNetworkManagerGlobalNetwork_basic
=== PAUSE TestAccNetworkManagerGlobalNetwork_basic
=== RUN   TestAccNetworkManagerGlobalNetwork_tags
=== PAUSE TestAccNetworkManagerGlobalNetwork_tags
=== RUN   TestAccNetworkManagerGlobalNetworksDataSource_basic
=== PAUSE TestAccNetworkManagerGlobalNetworksDataSource_basic
=== RUN   TestAccNetworkManagerLinkAssociation_basic
=== PAUSE TestAccNetworkManagerLinkAssociation_basic
=== RUN   TestAccNetworkManagerLinkDataSource_basic
=== PAUSE TestAccNetworkManagerLinkDataSource_basic
=== RUN   TestAccNetworkManagerLink_basic
=== PAUSE TestAccNetworkManagerLink_basic
=== RUN   TestAccNetworkManagerLink_tags
=== PAUSE TestAccNetworkManagerLink_tags
=== RUN   TestAccNetworkManagerLinksDataSource_basic
=== PAUSE TestAccNetworkManagerLinksDataSource_basic
=== RUN   TestAccNetworkManagerSiteDataSource_basic
=== PAUSE TestAccNetworkManagerSiteDataSource_basic
=== RUN   TestAccNetworkManagerSite_basic
=== PAUSE TestAccNetworkManagerSite_basic
=== RUN   TestAccNetworkManagerSite_tags
=== PAUSE TestAccNetworkManagerSite_tags
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_basic
=== RUN   TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== PAUSE TestAccNetworkManagerSiteToSiteVPNAttachment_tags
=== RUN   TestAccNetworkManagerSitesDataSource_basic
=== PAUSE TestAccNetworkManagerSitesDataSource_basic
=== RUN   TestAccNetworkManagerTransitGatewayPeering_basic
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_basic
=== RUN   TestAccNetworkManagerTransitGatewayPeering_tags
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_tags
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== RUN   TestAccNetworkManagerVPCAttachment_basic
=== PAUSE TestAccNetworkManagerVPCAttachment_basic
=== RUN   TestAccNetworkManagerVPCAttachment_tags
=== PAUSE TestAccNetworkManagerVPCAttachment_tags
=== CONT  TestAccNetworkManagerConnectAttachment_basic
=== CONT  TestAccNetworkManagerVPCAttachment_tags
--- PASS: TestAccNetworkManagerVPCAttachment_tags (957.19s)
=== CONT  TestAccNetworkManagerGlobalNetworksDataSource_basic
--- PASS: TestAccNetworkManagerGlobalNetworksDataSource_basic (17.25s)
=== CONT  TestAccNetworkManagerVPCAttachment_basic
--- PASS: TestAccNetworkManagerConnectAttachment_basic (1208.36s)
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
--- PASS: TestAccNetworkManagerVPCAttachment_basic (852.21s)
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags (1432.14s)
=== CONT  TestAccNetworkManagerTransitGatewayPeering_tags
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (1502.52s)
=== CONT  TestAccNetworkManagerTransitGatewayPeering_basic
--- PASS: TestAccNetworkManagerTransitGatewayPeering_tags (1214.13s)
=== CONT  TestAccNetworkManagerSitesDataSource_basic
    sites_data_source_test.go:19: Step 1/1 error: Error running apply: exit status 1
        
        Error: error creating Network Manager Site: ValidationException: Resource already exists with ID: site-01fccffd312177278
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "685fbece-cc07-4bcd-8e1a-5ac5576949d4"
          },
          Message_: "Resource already exists with ID: site-01fccffd312177278",
          Reason: "Other"
        }
        
          with aws_networkmanager_site.test1,
          on terraform_plugin_test.tf line 8, in resource "aws_networkmanager_site" "test1":
           8: resource "aws_networkmanager_site" "test1" {
        
--- FAIL: TestAccNetworkManagerSitesDataSource_basic (11.05s)
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_tags
--- PASS: TestAccNetworkManagerTransitGatewayPeering_basic (971.69s)
=== CONT  TestAccNetworkManagerSiteToSiteVPNAttachment_basic
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_tags (1235.67s)
=== CONT  TestAccNetworkManagerSite_tags
--- PASS: TestAccNetworkManagerSite_tags (42.58s)
=== CONT  TestAccNetworkManagerSite_basic
--- PASS: TestAccNetworkManagerSite_basic (19.85s)
=== CONT  TestAccNetworkManagerSiteDataSource_basic
--- PASS: TestAccNetworkManagerSiteDataSource_basic (18.89s)
=== CONT  TestAccNetworkManagerLinksDataSource_basic
--- PASS: TestAccNetworkManagerLinksDataSource_basic (21.35s)
=== CONT  TestAccNetworkManagerLink_tags
--- PASS: TestAccNetworkManagerLink_tags (46.13s)
=== CONT  TestAccNetworkManagerLink_basic
--- PASS: TestAccNetworkManagerLink_basic (21.55s)
=== CONT  TestAccNetworkManagerLinkDataSource_basic
--- PASS: TestAccNetworkManagerLinkDataSource_basic (18.98s)
=== CONT  TestAccNetworkManagerLinkAssociation_basic
    link_association_test.go:23: Step 1/2 error: Error running apply: exit status 1
        
        Error: error creating Network Manager Link: ValidationException: Resource already exists with ID: link-07020b60190aa0669
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "e5b1fe57-ed3c-4ce5-ad3b-0d92e1bf8833"
          },
          Message_: "Resource already exists with ID: link-07020b60190aa0669",
          Reason: "Other"
        }
        
          with aws_networkmanager_link.test,
          on terraform_plugin_test.tf line 16, in resource "aws_networkmanager_link" "test":
          16: resource "aws_networkmanager_link" "test" {
        
--- FAIL: TestAccNetworkManagerLinkAssociation_basic (12.73s)
=== CONT  TestAccNetworkManagerConnectionsDataSource_basic
--- PASS: TestAccNetworkManagerConnectionsDataSource_basic (26.75s)
=== CONT  TestAccNetworkManagerCoreNetwork_basic
--- PASS: TestAccNetworkManagerCoreNetwork_basic (45.21s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (9.05s)
=== CONT  TestAccNetworkManagerCoreNetworkPolicyAttachment_basic
--- PASS: TestAccNetworkManagerSiteToSiteVPNAttachment_basic (1489.69s)
=== CONT  TestAccNetworkManagerDevicesDataSource_basic
--- PASS: TestAccNetworkManagerDevicesDataSource_basic (17.75s)
=== CONT  TestAccNetworkManagerGlobalNetwork_tags
--- PASS: TestAccNetworkManagerGlobalNetwork_tags (37.90s)
=== CONT  TestAccNetworkManagerCoreNetwork_tags
--- PASS: TestAccNetworkManagerCoreNetwork_tags (76.26s)
=== CONT  TestAccNetworkManagerDevice_tags
--- PASS: TestAccNetworkManagerDevice_tags (40.83s)
=== CONT  TestAccNetworkManagerDevice_basic
--- PASS: TestAccNetworkManagerDevice_basic (18.43s)
=== CONT  TestAccNetworkManagerDeviceDataSource_basic
--- PASS: TestAccNetworkManagerDeviceDataSource_basic (17.68s)
=== CONT  TestAccNetworkManagerGlobalNetwork_basic
--- PASS: TestAccNetworkManagerGlobalNetwork_basic (17.11s)
=== CONT  TestAccNetworkManagerConnectPeer_tags
--- PASS: TestAccNetworkManagerCoreNetworkPolicyAttachment_basic (732.32s)
=== CONT  TestAccNetworkManagerConnectionDataSource_basic
--- PASS: TestAccNetworkManagerConnectionDataSource_basic (26.51s)
=== CONT  TestAccNetworkManagerConnectPeer_basic
--- PASS: TestAccNetworkManagerConnectPeer_tags (1474.26s)
=== CONT  TestAccNetworkManagerConnectAttachment_tags
--- PASS: TestAccNetworkManagerConnectPeer_basic (1513.37s)
=== CONT  TestAccNetworkManagerGlobalNetworkDataSource_basic
--- PASS: TestAccNetworkManagerGlobalNetworkDataSource_basic (15.26s)
--- PASS: TestAccNetworkManagerConnectAttachment_tags (1258.15s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	8764.441s
FAIL
make: *** [testacc] Error 1

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.