Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Reduce tags boilerplate code - Plugin SDK resources l* (Phase 3c) #30512

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 6, 2023

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.
Relates #30491.
Relates #30509.
Relates #30510.

Output from Acceptance Testing

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=l... ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/l.../... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccLakeFormationResourceDataSource_basic
=== PAUSE TestAccLakeFormationResourceDataSource_basic
=== RUN   TestAccLakeFormationResource_basic
=== PAUSE TestAccLakeFormationResource_basic
=== CONT  TestAccLakeFormationResourceDataSource_basic
=== CONT  TestAccLakeFormationResource_basic
--- PASS: TestAccLakeFormationResource_basic (34.08s)
--- PASS: TestAccLakeFormationResourceDataSource_basic (37.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	50.878s
=== RUN   TestAccLambdaAliasDataSource_basic
=== PAUSE TestAccLambdaAliasDataSource_basic
=== RUN   TestAccLambdaAlias_basic
=== PAUSE TestAccLambdaAlias_basic
=== RUN   TestAccLambdaCodeSigningConfigDataSource_basic
=== PAUSE TestAccLambdaCodeSigningConfigDataSource_basic
=== RUN   TestAccLambdaCodeSigningConfig_basic
=== PAUSE TestAccLambdaCodeSigningConfig_basic
=== RUN   TestAccLambdaEventSourceMapping_Kinesis_basic
=== PAUSE TestAccLambdaEventSourceMapping_Kinesis_basic
=== RUN   TestAccLambdaEventSourceMapping_SQS_basic
=== PAUSE TestAccLambdaEventSourceMapping_SQS_basic
=== RUN   TestAccLambdaEventSourceMapping_DynamoDB_basic
=== PAUSE TestAccLambdaEventSourceMapping_DynamoDB_basic
=== RUN   TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN   TestAccLambdaFunctionEventInvokeConfig_basic
=== PAUSE TestAccLambdaFunctionEventInvokeConfig_basic
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_tags
=== PAUSE TestAccLambdaFunction_tags
=== RUN   TestAccLambdaFunction_S3Update_basic
=== PAUSE TestAccLambdaFunction_S3Update_basic
=== RUN   TestAccLambdaFunctionURLDataSource_basic
=== PAUSE TestAccLambdaFunctionURLDataSource_basic
=== RUN   TestAccLambdaFunctionURL_basic
=== PAUSE TestAccLambdaFunctionURL_basic
=== RUN   TestAccLambdaFunctionsDataSource_basic
=== PAUSE TestAccLambdaFunctionsDataSource_basic
=== RUN   TestAccLambdaInvocationDataSource_basic
=== PAUSE TestAccLambdaInvocationDataSource_basic
=== RUN   TestAccLambdaInvocation_basic
=== PAUSE TestAccLambdaInvocation_basic
=== RUN   TestAccLambdaLayerVersionDataSource_basic
=== PAUSE TestAccLambdaLayerVersionDataSource_basic
=== RUN   TestAccLambdaLayerVersion_basic
=== PAUSE TestAccLambdaLayerVersion_basic
=== RUN   TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== RUN   TestAccLambdaProvisionedConcurrencyConfig_basic
=== PAUSE TestAccLambdaProvisionedConcurrencyConfig_basic
=== CONT  TestAccLambdaAliasDataSource_basic
=== CONT  TestAccLambdaFunction_S3Update_basic
=== CONT  TestAccLambdaEventSourceMapping_Kinesis_basic
=== CONT  TestAccLambdaFunction_S3Update_basic
    function_test.go:1928: Step 1/3 error: Error running apply: exit status 1
        
        Error: error creating S3 bucket ACL for tf-acc-test-813466319680070139: AccessControlListNotSupported: The bucket does not allow ACLs
        	status code: 400, request id: WYBJH0GPJ4MMRSXY, host id: DhQ77g/XA4k3Dzwzj3sSkCZDJEP+ai2gAN/e+CbfjhEI1GiPGxPNUAv2gJQ06/BPxGcZjLZ8Lmk=
        
          with aws_s3_bucket_acl.artifacts,
          on terraform_plugin_test.tf line 7, in resource "aws_s3_bucket_acl" "artifacts":
           7: resource "aws_s3_bucket_acl" "artifacts" {
        
--- FAIL: TestAccLambdaFunction_S3Update_basic (61.01s)
=== CONT  TestAccLambdaCodeSigningConfig_basic
--- PASS: TestAccLambdaAliasDataSource_basic (99.10s)
=== CONT  TestAccLambdaEventSourceMapping_DynamoDB_basic
--- PASS: TestAccLambdaCodeSigningConfig_basic (88.46s)
=== CONT  TestAccLambdaEventSourceMapping_SQS_basic
--- PASS: TestAccLambdaEventSourceMapping_Kinesis_basic (204.95s)
=== CONT  TestAccLambdaInvocation_basic
--- PASS: TestAccLambdaEventSourceMapping_DynamoDB_basic (112.52s)
=== CONT  TestAccLambdaProvisionedConcurrencyConfig_basic
--- PASS: TestAccLambdaInvocation_basic (80.24s)
=== CONT  TestAccLambdaPermission_basic
--- PASS: TestAccLambdaEventSourceMapping_SQS_basic (215.54s)
=== CONT  TestAccLambdaLayerVersion_basic
--- PASS: TestAccLambdaPermission_basic (88.18s)
=== CONT  TestAccLambdaLayerVersionDataSource_basic
--- PASS: TestAccLambdaLayerVersion_basic (66.61s)
=== CONT  TestAccLambdaCodeSigningConfigDataSource_basic
--- PASS: TestAccLambdaLayerVersionDataSource_basic (60.26s)
=== CONT  TestAccLambdaAlias_basic
--- PASS: TestAccLambdaProvisionedConcurrencyConfig_basic (249.93s)
=== CONT  TestAccLambdaFunction_basic
--- PASS: TestAccLambdaCodeSigningConfigDataSource_basic (47.06s)
=== CONT  TestAccLambdaFunction_tags
--- PASS: TestAccLambdaFunction_basic (57.79s)
=== CONT  TestAccLambdaFunctionsDataSource_basic
--- PASS: TestAccLambdaAlias_basic (87.46s)
=== CONT  TestAccLambdaInvocationDataSource_basic
--- PASS: TestAccLambdaFunctionsDataSource_basic (40.28s)
=== CONT  TestAccLambdaFunctionURL_basic
--- PASS: TestAccLambdaFunction_tags (93.51s)
=== CONT  TestAccLambdaFunctionURLDataSource_basic
--- PASS: TestAccLambdaInvocationDataSource_basic (52.13s)
=== CONT  TestAccLambdaFunctionEventInvokeConfig_basic
--- PASS: TestAccLambdaFunctionURL_basic (44.29s)
=== CONT  TestAccLambdaFunctionDataSource_basic
--- PASS: TestAccLambdaFunctionURLDataSource_basic (37.47s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_basic (44.17s)
--- PASS: TestAccLambdaFunctionDataSource_basic (46.44s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	691.243s
=== RUN   TestAccLexModelsBotAlias_basic
=== PAUSE TestAccLexModelsBotAlias_basic
=== RUN   TestAccLexModelsBotDataSource_basic
=== PAUSE TestAccLexModelsBotDataSource_basic
=== RUN   TestAccLexModelsBot_basic
=== PAUSE TestAccLexModelsBot_basic
=== RUN   TestAccLexModelsIntentDataSource_basic
=== PAUSE TestAccLexModelsIntentDataSource_basic
=== RUN   TestAccLexModelsIntent_basic
=== PAUSE TestAccLexModelsIntent_basic
=== RUN   TestAccLexModelsSlotTypeDataSource_basic
=== PAUSE TestAccLexModelsSlotTypeDataSource_basic
=== RUN   TestAccLexModelsSlotType_basic
=== PAUSE TestAccLexModelsSlotType_basic
=== CONT  TestAccLexModelsBotAlias_basic
=== CONT  TestAccLexModelsIntent_basic
=== CONT  TestAccLexModelsBot_basic
=== CONT  TestAccLexModelsIntent_basic
    intent_test.go:28: Step 1/2 error: Check failed: 8 errors occurred:
        	* Check 5/19 error: aws_lex_intent.test: list or set attribute 'conclusion_statement' must be checked by element count key (conclusion_statement.#) or element value keys (e.g. conclusion_statement.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 6/19 error: aws_lex_intent.test: list or set attribute 'confirmation_prompt' must be checked by element count key (confirmation_prompt.#) or element value keys (e.g. confirmation_prompt.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 10/19 error: aws_lex_intent.test: list or set attribute 'dialog_code_hook' must be checked by element count key (dialog_code_hook.#) or element value keys (e.g. dialog_code_hook.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 11/19 error: aws_lex_intent.test: list or set attribute 'follow_up_prompt' must be checked by element count key (follow_up_prompt.#) or element value keys (e.g. follow_up_prompt.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 12/19 error: aws_lex_intent.test: list or set attribute 'fulfillment_activity' must be checked by element count key (fulfillment_activity.#) or element value keys (e.g. fulfillment_activity.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 15/19 error: aws_lex_intent.test: Attribute 'parent_intent_signature' found when not expected
        	* Check 16/19 error: aws_lex_intent.test: list or set attribute 'rejection_statement' must be checked by element count key (rejection_statement.#) or element value keys (e.g. rejection_statement.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 18/19 error: aws_lex_intent.test: list or set attribute 'slot' must be checked by element count key (slot.#) or element value keys (e.g. slot.0). Set element value checks should use TestCheckTypeSet functions instead.
        
=== CONT  TestAccLexModelsBot_basic
    bot_test.go:35: Step 1/2 error: Check failed: 4 errors occurred:
        	* Check 3/23 error: aws_lex_bot.test: list or set attribute 'abort_statement' must be checked by element count key (abort_statement.#) or element value keys (e.g. abort_statement.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 7/23 error: aws_lex_bot.test: list or set attribute 'clarification_prompt' must be checked by element count key (clarification_prompt.#) or element value keys (e.g. clarification_prompt.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 15/23 error: aws_lex_bot.test: list or set attribute 'intent' must be checked by element count key (intent.#) or element value keys (e.g. intent.0). Set element value checks should use TestCheckTypeSet functions instead.
        	* Check 23/23 error: aws_lex_bot.test: Attribute 'voice_id' found when not expected
        
--- FAIL: TestAccLexModelsIntent_basic (44.51s)
=== CONT  TestAccLexModelsIntentDataSource_basic
--- FAIL: TestAccLexModelsBot_basic (45.96s)
=== CONT  TestAccLexModelsSlotType_basic
--- PASS: TestAccLexModelsBotAlias_basic (99.86s)
=== CONT  TestAccLexModelsSlotTypeDataSource_basic
--- PASS: TestAccLexModelsIntentDataSource_basic (79.26s)
=== CONT  TestAccLexModelsBotDataSource_basic
--- PASS: TestAccLexModelsSlotType_basic (96.03s)
--- PASS: TestAccLexModelsSlotTypeDataSource_basic (70.62s)
--- PASS: TestAccLexModelsBotDataSource_basic (62.94s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels	205.131s
=== RUN   TestAccLicenseManagerAssociation_basic
=== PAUSE TestAccLicenseManagerAssociation_basic
=== RUN   TestAccLicenseManagerLicenseConfiguration_basic
=== PAUSE TestAccLicenseManagerLicenseConfiguration_basic
=== RUN   TestAccLicenseManagerLicenseConfiguration_tags
=== PAUSE TestAccLicenseManagerLicenseConfiguration_tags
=== RUN   TestAccLicenseManagerReceivedLicenseDataSource_basic
    received_license_data_source_test.go:16: skipping test; environment variable TF_AWS_LICENSE_MANAGER_GRANT_LICENSE_ARN must be set. Usage: ARN for a license imported into the current account.
--- SKIP: TestAccLicenseManagerReceivedLicenseDataSource_basic (0.00s)
=== RUN   TestAccLicenseManagerReceivedLicensesDataSource_basic
    received_licenses_data_source_test.go:16: skipping test; environment variable TF_AWS_LICENSE_MANAGER_GRANT_LICENSE_ARN must be set. Usage: ARN for a license imported into the current account.
--- SKIP: TestAccLicenseManagerReceivedLicensesDataSource_basic (0.00s)
=== CONT  TestAccLicenseManagerAssociation_basic
=== CONT  TestAccLicenseManagerLicenseConfiguration_tags
=== CONT  TestAccLicenseManagerLicenseConfiguration_basic
--- PASS: TestAccLicenseManagerLicenseConfiguration_basic (87.40s)
--- PASS: TestAccLicenseManagerAssociation_basic (171.37s)
--- PASS: TestAccLicenseManagerLicenseConfiguration_tags (196.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager	205.919s
=== RUN   TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN   TestAccLightsailBucketResourceAccess_basic
=== PAUSE TestAccLightsailBucketResourceAccess_basic
=== RUN   TestAccLightsailBucket_basic
=== PAUSE TestAccLightsailBucket_basic
=== RUN   TestAccLightsailBucket_tags
=== PAUSE TestAccLightsailBucket_tags
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailCertificate_tags
=== PAUSE TestAccLightsailCertificate_tags
=== RUN   TestAccLightsailContainerService_basic
=== PAUSE TestAccLightsailContainerService_basic
=== RUN   TestAccLightsailContainerService_tags
=== PAUSE TestAccLightsailContainerService_tags
=== RUN   TestAccLightsailDatabase_basic
=== PAUSE TestAccLightsailDatabase_basic
=== RUN   TestAccLightsailDatabase_tags
=== PAUSE TestAccLightsailDatabase_tags
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomain_basic
=== PAUSE TestAccLightsailDomain_basic
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailInstance_tags
=== PAUSE TestAccLightsailInstance_tags
=== RUN   TestAccLightsailKeyPair_basic
=== PAUSE TestAccLightsailKeyPair_basic
=== RUN   TestAccLightsailStaticIPAttachment_basic
=== PAUSE TestAccLightsailStaticIPAttachment_basic
=== RUN   TestAccLightsailStaticIP_basic
=== PAUSE TestAccLightsailStaticIP_basic
=== CONT  TestAccLightsailBucketAccessKey_basic
=== CONT  TestAccLightsailDisk_basic
=== CONT  TestAccLightsailStaticIP_basic
--- PASS: TestAccLightsailStaticIP_basic (80.39s)
=== CONT  TestAccLightsailStaticIPAttachment_basic
--- PASS: TestAccLightsailBucketAccessKey_basic (126.07s)
=== CONT  TestAccLightsailKeyPair_basic
--- PASS: TestAccLightsailDisk_basic (143.52s)
=== CONT  TestAccLightsailInstance_tags
--- PASS: TestAccLightsailKeyPair_basic (67.92s)
=== CONT  TestAccLightsailInstance_basic
--- PASS: TestAccLightsailStaticIPAttachment_basic (134.76s)
=== CONT  TestAccLightsailInstancePublicPorts_basic
--- PASS: TestAccLightsailInstance_tags (124.52s)
=== CONT  TestAccLightsailDomain_basic
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomain_basic (0.00s)
=== CONT  TestAccLightsailBucket_basic
--- PASS: TestAccLightsailInstance_basic (99.67s)
=== CONT  TestAccLightsailDomainEntry_basic
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomainEntry_basic (0.00s)
=== CONT  TestAccLightsailContainerService_basic
--- PASS: TestAccLightsailInstancePublicPorts_basic (94.01s)
=== CONT  TestAccLightsailDiskAttachment_basic
--- PASS: TestAccLightsailBucket_basic (82.40s)
=== CONT  TestAccLightsailDatabase_tags
--- PASS: TestAccLightsailContainerService_basic (187.65s)
=== CONT  TestAccLightsailDatabase_basic
--- PASS: TestAccLightsailDiskAttachment_basic (259.44s)
=== CONT  TestAccLightsailContainerService_tags
--- PASS: TestAccLightsailContainerService_tags (114.01s)
=== CONT  TestAccLightsailCertificate_basic
--- PASS: TestAccLightsailCertificate_basic (55.14s)
=== CONT  TestAccLightsailCertificate_tags
--- PASS: TestAccLightsailCertificate_tags (96.00s)
=== CONT  TestAccLightsailBucket_tags
--- PASS: TestAccLightsailBucket_tags (66.11s)
=== CONT  TestAccLightsailBucketResourceAccess_basic
--- PASS: TestAccLightsailBucketResourceAccess_basic (70.73s)
--- PASS: TestAccLightsailDatabase_basic (761.30s)
--- PASS: TestAccLightsailDatabase_tags (999.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	1378.354s
=== RUN   TestAccLocationGeofenceCollectionDataSource_basic
=== PAUSE TestAccLocationGeofenceCollectionDataSource_basic
=== RUN   TestAccLocationGeofenceCollection_basic
=== PAUSE TestAccLocationGeofenceCollection_basic
=== RUN   TestAccLocationGeofenceCollection_tags
=== PAUSE TestAccLocationGeofenceCollection_tags
=== RUN   TestAccLocationMap_basic
=== PAUSE TestAccLocationMap_basic
=== RUN   TestAccLocationMap_tags
=== PAUSE TestAccLocationMap_tags
=== RUN   TestAccLocationPlaceIndex_basic
=== PAUSE TestAccLocationPlaceIndex_basic
=== RUN   TestAccLocationPlaceIndex_tags
=== PAUSE TestAccLocationPlaceIndex_tags
=== RUN   TestAccLocationRouteCalculatorDataSource_basic
=== PAUSE TestAccLocationRouteCalculatorDataSource_basic
=== RUN   TestAccLocationRouteCalculator_basic
=== PAUSE TestAccLocationRouteCalculator_basic
=== RUN   TestAccLocationRouteCalculator_tags
=== PAUSE TestAccLocationRouteCalculator_tags
=== RUN   TestAccLocationTrackerAssociationDataSource_basic
=== PAUSE TestAccLocationTrackerAssociationDataSource_basic
=== RUN   TestAccLocationTrackerAssociation_basic
=== PAUSE TestAccLocationTrackerAssociation_basic
=== RUN   TestAccLocationTrackerAssociationsDataSource_basic
=== PAUSE TestAccLocationTrackerAssociationsDataSource_basic
=== RUN   TestAccLocationTracker_basic
=== PAUSE TestAccLocationTracker_basic
=== RUN   TestAccLocationTracker_tags
=== PAUSE TestAccLocationTracker_tags
=== CONT  TestAccLocationGeofenceCollectionDataSource_basic
=== CONT  TestAccLocationTrackerAssociationsDataSource_basic
=== CONT  TestAccLocationRouteCalculator_basic
--- PASS: TestAccLocationGeofenceCollectionDataSource_basic (76.67s)
=== CONT  TestAccLocationTrackerAssociation_basic
--- PASS: TestAccLocationTrackerAssociationsDataSource_basic (77.50s)
=== CONT  TestAccLocationTrackerAssociationDataSource_basic
--- PASS: TestAccLocationRouteCalculator_basic (94.96s)
=== CONT  TestAccLocationRouteCalculator_tags
--- PASS: TestAccLocationTrackerAssociationDataSource_basic (67.98s)
=== CONT  TestAccLocationMap_tags
--- PASS: TestAccLocationTrackerAssociation_basic (78.59s)
=== CONT  TestAccLocationRouteCalculatorDataSource_basic
--- PASS: TestAccLocationRouteCalculatorDataSource_basic (42.61s)
=== CONT  TestAccLocationPlaceIndex_tags
--- PASS: TestAccLocationRouteCalculator_tags (142.53s)
=== CONT  TestAccLocationPlaceIndex_basic
--- PASS: TestAccLocationMap_tags (133.44s)
=== CONT  TestAccLocationGeofenceCollection_tags
--- PASS: TestAccLocationPlaceIndex_basic (69.56s)
=== CONT  TestAccLocationMap_basic
=== CONT  TestAccLocationTracker_tags
--- PASS: TestAccLocationPlaceIndex_tags (147.72s)
--- PASS: TestAccLocationMap_basic (62.24s)
=== CONT  TestAccLocationGeofenceCollection_basic
--- PASS: TestAccLocationGeofenceCollection_tags (152.49s)
=== CONT  TestAccLocationTracker_basic
--- PASS: TestAccLocationGeofenceCollection_basic (67.45s)
--- PASS: TestAccLocationTracker_basic (51.03s)
--- PASS: TestAccLocationTracker_tags (139.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	537.104s
=== RUN   TestAccLogsDataProtectionPolicyDocumentDataSource_basic
=== PAUSE TestAccLogsDataProtectionPolicyDocumentDataSource_basic
=== RUN   TestAccLogsDataProtectionPolicy_basic
=== PAUSE TestAccLogsDataProtectionPolicy_basic
=== RUN   TestAccLogsDestinationPolicy_basic
=== PAUSE TestAccLogsDestinationPolicy_basic
=== RUN   TestAccLogsDestination_basic
=== PAUSE TestAccLogsDestination_basic
=== RUN   TestAccLogsDestination_tags
=== PAUSE TestAccLogsDestination_tags
=== RUN   TestAccLogsGroupDataSource_basic
=== PAUSE TestAccLogsGroupDataSource_basic
=== RUN   TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN   TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== RUN   TestAccLogsGroupsDataSource_basic
=== PAUSE TestAccLogsGroupsDataSource_basic
=== RUN   TestAccLogsMetricFilter_basic
=== PAUSE TestAccLogsMetricFilter_basic
=== RUN   TestAccLogsQueryDefinition_basic
=== PAUSE TestAccLogsQueryDefinition_basic
=== RUN   TestAccLogsResourcePolicy_basic
=== PAUSE TestAccLogsResourcePolicy_basic
=== RUN   TestAccLogsStream_basic
=== PAUSE TestAccLogsStream_basic
=== RUN   TestAccLogsSubscriptionFilter_basic
=== PAUSE TestAccLogsSubscriptionFilter_basic
=== CONT  TestAccLogsDataProtectionPolicyDocumentDataSource_basic
=== CONT  TestAccLogsGroup_tags
=== CONT  TestAccLogsDestination_tags
--- PASS: TestAccLogsGroup_tags (172.31s)
=== CONT  TestAccLogsResourcePolicy_basic
--- PASS: TestAccLogsDataProtectionPolicyDocumentDataSource_basic (182.87s)
=== CONT  TestAccLogsSubscriptionFilter_basic
--- PASS: TestAccLogsDestination_tags (199.81s)
=== CONT  TestAccLogsStream_basic
--- PASS: TestAccLogsStream_basic (64.44s)
=== CONT  TestAccLogsMetricFilter_basic
--- PASS: TestAccLogsResourcePolicy_basic (99.44s)
=== CONT  TestAccLogsQueryDefinition_basic
--- PASS: TestAccLogsSubscriptionFilter_basic (91.67s)
=== CONT  TestAccLogsGroup_basic
--- PASS: TestAccLogsMetricFilter_basic (61.51s)
=== CONT  TestAccLogsGroupDataSource_basic
--- PASS: TestAccLogsQueryDefinition_basic (60.73s)
=== CONT  TestAccLogsDestinationPolicy_basic
--- PASS: TestAccLogsGroup_basic (68.78s)
=== CONT  TestAccLogsDestination_basic
--- PASS: TestAccLogsGroupDataSource_basic (53.26s)
=== CONT  TestAccLogsGroupsDataSource_basic
--- PASS: TestAccLogsGroupsDataSource_basic (56.55s)
=== CONT  TestAccLogsDataProtectionPolicy_basic
--- PASS: TestAccLogsDestination_basic (111.10s)
--- PASS: TestAccLogsDestinationPolicy_basic (144.20s)
--- PASS: TestAccLogsDataProtectionPolicy_basic (50.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	548.544s
FAIL
make: *** [testacc] Error 1

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. service/licensemanager Issues and PRs that pertain to the licensemanager service. service/lightsail Issues and PRs that pertain to the lightsail service. service/location Issues and PRs that pertain to the location service. labels Apr 6, 2023
@github-actions github-actions bot added the generators Relates to code generators. label Apr 6, 2023
@ewbankkit ewbankkit merged commit db265e9 into main Apr 6, 2023
34 checks passed
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3c-l branch April 6, 2023 18:16
@github-actions github-actions bot added this to the v4.62.0 milestone Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
generators Relates to code generators. service/lambda Issues and PRs that pertain to the lambda service. service/licensemanager Issues and PRs that pertain to the licensemanager service. service/lightsail Issues and PRs that pertain to the lightsail service. service/location Issues and PRs that pertain to the location service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant