Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Reduce tags boilerplate code - Plugin SDK resources r* (Phase 3c) #30461

Merged
merged 14 commits into from
Apr 5, 2023
Merged

Tech debt: Reduce tags boilerplate code - Plugin SDK resources r* (Phase 3c) #30461

merged 14 commits into from
Apr 5, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 4, 2023 •
edited

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.

Output from Acceptance Testing

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=r... ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/r.../... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccRAMPrincipalAssociation_basic
=== PAUSE TestAccRAMPrincipalAssociation_basic
=== RUN   TestAccRAMResourceAssociation_basic
=== PAUSE TestAccRAMResourceAssociation_basic
=== RUN   TestAccRAMResourceShareAccepter_basic
=== PAUSE TestAccRAMResourceShareAccepter_basic
=== RUN   TestAccRAMResourceShareDataSource_basic
=== PAUSE TestAccRAMResourceShareDataSource_basic
=== RUN   TestAccRAMResourceShareDataSource_tags
=== PAUSE TestAccRAMResourceShareDataSource_tags
=== RUN   TestAccRAMResourceShare_basic
=== PAUSE TestAccRAMResourceShare_basic
=== RUN   TestAccRAMResourceShare_tags
=== PAUSE TestAccRAMResourceShare_tags
=== CONT  TestAccRAMPrincipalAssociation_basic
=== CONT  TestAccRAMResourceShareDataSource_tags
=== CONT  TestAccRAMResourceShare_tags
--- PASS: TestAccRAMResourceShareDataSource_tags (66.08s)
=== CONT  TestAccRAMResourceShare_basic
--- PASS: TestAccRAMPrincipalAssociation_basic (68.91s)
=== CONT  TestAccRAMResourceShareAccepter_basic
    acctest.go:772: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRAMResourceShareAccepter_basic (0.00s)
=== CONT  TestAccRAMResourceShareDataSource_basic
--- PASS: TestAccRAMResourceShareDataSource_basic (47.91s)
=== CONT  TestAccRAMResourceAssociation_basic
--- PASS: TestAccRAMResourceShare_basic (54.74s)
--- PASS: TestAccRAMResourceShare_tags (137.24s)
--- PASS: TestAccRAMResourceAssociation_basic (40.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	167.339s
=== RUN   TestAccRBinRule_basic
=== PAUSE TestAccRBinRule_basic
=== RUN   TestAccRBinRule_tags
=== PAUSE TestAccRBinRule_tags
=== CONT  TestAccRBinRule_basic
=== CONT  TestAccRBinRule_tags
--- PASS: TestAccRBinRule_basic (69.33s)
--- PASS: TestAccRBinRule_tags (122.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rbin	141.542s
=== RUN   TestAccRDSClusterActivityStream_basic
=== PAUSE TestAccRDSClusterActivityStream_basic
=== RUN   TestAccRDSClusterDataSource_basic
=== PAUSE TestAccRDSClusterDataSource_basic
=== RUN   TestAccRDSClusterEndpoint_basic
=== PAUSE TestAccRDSClusterEndpoint_basic
=== RUN   TestAccRDSClusterEndpoint_tags
=== PAUSE TestAccRDSClusterEndpoint_tags
=== RUN   TestAccRDSClusterInstance_basic
=== PAUSE TestAccRDSClusterInstance_basic
=== RUN   TestAccRDSClusterInstance_tags
=== PAUSE TestAccRDSClusterInstance_tags
=== RUN   TestAccRDSClusterParameterGroup_basic
=== PAUSE TestAccRDSClusterParameterGroup_basic
=== RUN   TestAccRDSClusterParameterGroup_tags
=== PAUSE TestAccRDSClusterParameterGroup_tags
=== RUN   TestAccRDSClusterRoleAssociation_basic
=== PAUSE TestAccRDSClusterRoleAssociation_basic
=== RUN   TestAccRDSClusterSnapshot_basic
=== PAUSE TestAccRDSClusterSnapshot_basic
=== RUN   TestAccRDSClusterSnapshot_tags
=== PAUSE TestAccRDSClusterSnapshot_tags
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_tags
=== PAUSE TestAccRDSCluster_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifier_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifier_tags
=== RUN   TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== PAUSE TestAccRDSCluster_SnapshotIdentifierVPCSecurityGroupIDs_tags
=== RUN   TestAccRDSEngineVersionDataSource_basic
=== PAUSE TestAccRDSEngineVersionDataSource_basic
=== RUN   TestAccRDSEventCategoriesDataSource_basic
=== PAUSE TestAccRDSEventCategoriesDataSource_basic
=== RUN   TestAccRDSEventSubscription_basic
=== PAUSE TestAccRDSEventSubscription_basic
=== RUN   TestAccRDSEventSubscription_tags
=== PAUSE TestAccRDSEventSubscription_tags
=== RUN   TestAccRDSExportTask_basic
=== PAUSE TestAccRDSExportTask_basic
=== RUN   TestAccRDSGlobalCluster_basic
=== PAUSE TestAccRDSGlobalCluster_basic
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_basic
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_basic
=== RUN   TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== RUN   TestAccRDSInstanceRoleAssociation_basic
=== PAUSE TestAccRDSInstanceRoleAssociation_basic
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_tags
=== PAUSE TestAccRDSInstance_tags
=== RUN   TestAccRDSInstance_ReplicateSourceDB_basic
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_basic
=== RUN   TestAccRDSInstance_S3Import_basic
    acctest.go:76: RestoreDBInstanceFromS3 cannot restore from MySQL version 5.6
--- SKIP: TestAccRDSInstance_S3Import_basic (0.00s)
=== RUN   TestAccRDSInstance_SnapshotIdentifier_basic
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_basic
=== RUN   TestAccRDSInstance_SnapshotIdentifier_tags
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_tags
=== RUN   TestAccRDSInstance_BlueGreenDeployment_tags
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_tags
=== RUN   TestAccRDSOptionGroup_basic
=== PAUSE TestAccRDSOptionGroup_basic
=== RUN   TestAccRDSOptionGroup_tags
=== PAUSE TestAccRDSOptionGroup_tags
=== RUN   TestAccRDSOrderableInstanceDataSource_basic
=== PAUSE TestAccRDSOrderableInstanceDataSource_basic
=== RUN   TestAccRDSParameterGroup_basic
=== PAUSE TestAccRDSParameterGroup_basic
=== RUN   TestAccRDSProxyDataSource_basic
=== PAUSE TestAccRDSProxyDataSource_basic
=== RUN   TestAccRDSProxyDefaultTargetGroup_basic
=== PAUSE TestAccRDSProxyDefaultTargetGroup_basic
=== RUN   TestAccRDSProxyEndpoint_basic
=== PAUSE TestAccRDSProxyEndpoint_basic
=== RUN   TestAccRDSProxyEndpoint_tags
=== PAUSE TestAccRDSProxyEndpoint_tags
=== RUN   TestAccRDSProxy_basic
=== PAUSE TestAccRDSProxy_basic
=== RUN   TestAccRDSProxy_tags
=== PAUSE TestAccRDSProxy_tags
=== RUN   TestAccRDSInstanceOffering_basic
=== PAUSE TestAccRDSInstanceOffering_basic
=== RUN   TestAccRDSReservedInstance_basic
    reserved_instance_test.go:24: Environment variable RUN_RDS_RESERVED_INSTANCE_TESTS is not set to true
--- SKIP: TestAccRDSReservedInstance_basic (0.00s)
=== RUN   TestAccRDSSnapshotCopy_basic
=== PAUSE TestAccRDSSnapshotCopy_basic
=== RUN   TestAccRDSSnapshotCopy_tags
=== PAUSE TestAccRDSSnapshotCopy_tags
=== RUN   TestAccRDSSnapshotDataSource_basic
=== PAUSE TestAccRDSSnapshotDataSource_basic
=== RUN   TestAccRDSSnapshot_basic
=== PAUSE TestAccRDSSnapshot_basic
=== RUN   TestAccRDSSnapshot_tags
=== PAUSE TestAccRDSSnapshot_tags
=== RUN   TestAccRDSSubnetGroupDataSource_basic
=== PAUSE TestAccRDSSubnetGroupDataSource_basic
=== RUN   TestAccRDSSubnetGroup_basic
=== PAUSE TestAccRDSSubnetGroup_basic
=== RUN   TestAccRDSSubnetGroup_tags
=== PAUSE TestAccRDSSubnetGroup_tags
=== CONT  TestAccRDSClusterActivityStream_basic
=== CONT  TestAccRDSInstance_tags
=== CONT  TestAccRDSProxyEndpoint_tags
--- PASS: TestAccRDSInstance_tags (549.81s)
=== CONT  TestAccRDSSnapshotDataSource_basic
--- PASS: TestAccRDSProxyEndpoint_tags (931.26s)
=== CONT  TestAccRDSSubnetGroup_tags
--- PASS: TestAccRDSSubnetGroup_tags (69.32s)
=== CONT  TestAccRDSSubnetGroup_basic
--- PASS: TestAccRDSSubnetGroup_basic (42.83s)
=== CONT  TestAccRDSSubnetGroupDataSource_basic
--- PASS: TestAccRDSSubnetGroupDataSource_basic (37.76s)
=== CONT  TestAccRDSSnapshot_tags
--- PASS: TestAccRDSSnapshotDataSource_basic (871.86s)
=== CONT  TestAccRDSSnapshot_basic
--- PASS: TestAccRDSSnapshot_tags (553.11s)
=== CONT  TestAccRDSOptionGroup_tags
--- PASS: TestAccRDSOptionGroup_tags (45.49s)
=== CONT  TestAccRDSProxyEndpoint_basic
--- PASS: TestAccRDSSnapshot_basic (640.55s)
=== CONT  TestAccRDSProxyDefaultTargetGroup_basic
--- PASS: TestAccRDSClusterActivityStream_basic (2072.89s)
=== CONT  TestAccRDSProxyDataSource_basic
panic: Invalid address to set: []string{"auth", "0", "client_password_auth_type"}

goroutine 113240 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc0172a3f80, {0xe3f8e86, 0x4}, {0xb9400c0, 0xc004d78708})
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource_data.go:230 +0x291
github.com/hashicorp/terraform-provider-aws/internal/service/rds.dataSourceProxyRead({0xf949240, 0xc00e6ed770}, 0x0?, {0xe3b9620?, 0xc016c75c00?})
	/Users/ewbankkit/src/github.com/terraform-providers/terraform-provider-aws/internal/service/rds/proxy_data_source.go:109 +0x3cc
github.com/hashicorp/terraform-provider-aws/internal/provider.interceptedHandler[...].func1(0x0?, {0xe3b9620?, 0xc016c75c00?})
	/Users/ewbankkit/src/github.com/terraform-providers/terraform-provider-aws/internal/provider/intercept.go:94 +0x175
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xf949240?, {0xf949240?, 0xc00e6eccc0?}, 0xd?, {0xe3b9620?, 0xc016c75c00?})
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource.go:719 +0x87
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc005e74e00, {0xf949240, 0xc00e6eccc0}, 0xc0172a3e80, {0xe3b9620, 0xc016c75c00})
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/resource.go:943 +0x145
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0xc005fe5ef0, {0xf949240?, 0xc00e6ecc00?}, 0xc016ba32e0)
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.26.1/helper/schema/grpc_provider.go:1195 +0x38f
github.com/hashicorp/terraform-plugin-mux/tf5muxserver.muxServer.ReadDataSource({0xc00886fa40, 0xc00886faa0, {0xc016983440, 0x2, 0x2}, {0x0, 0x0, 0x0}, {0x0, 0x0, ...}, ...}, ...)
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-mux@v0.9.0/tf5muxserver/mux_server_ReadDataSource.go:27 +0x102
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadDataSource(0xc014ade780, {0xf949240?, 0xc00e6ec180?}, 0xc017105e50)
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.14.3/tfprotov5/tf5server/server.go:658 +0x403
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler({0xe0b1020?, 0xc014ade780}, {0xf949240, 0xc00e6ec180}, 0xc0172b3030, 0x0)
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.14.3/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:421 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc015acba40, {0xf958ec0, 0xc014e2c1a0}, 0xc010594000, 0xc00b7802d0, 0x163dbab0, 0x0)
	/Users/ewbankkit/go/pkg/mod/google.golang.org/grpc@v1.53.0/server.go:1336 +0xd23
google.golang.org/grpc.(*Server).handleStream(0xc015acba40, {0xf958ec0, 0xc014e2c1a0}, 0xc010594000, 0x0)
	/Users/ewbankkit/go/pkg/mod/google.golang.org/grpc@v1.53.0/server.go:1704 +0xa2f
google.golang.org/grpc.(*Server).serveStreams.func1.2()
	/Users/ewbankkit/go/pkg/mod/google.golang.org/grpc@v1.53.0/server.go:965 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/Users/ewbankkit/go/pkg/mod/google.golang.org/grpc@v1.53.0/server.go:963 +0x28a
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2350.957s
=== RUN   TestAccRedshiftAuthenticationProfile_basic
=== PAUSE TestAccRedshiftAuthenticationProfile_basic
=== RUN   TestAccRedshiftClusterCredentialsDataSource_basic
=== PAUSE TestAccRedshiftClusterCredentialsDataSource_basic
=== RUN   TestAccRedshiftClusterDataSource_basic
=== PAUSE TestAccRedshiftClusterDataSource_basic
=== RUN   TestAccRedshiftClusterIAMRoles_basic
=== PAUSE TestAccRedshiftClusterIAMRoles_basic
=== RUN   TestAccRedshiftClusterSnapshot_basic
=== PAUSE TestAccRedshiftClusterSnapshot_basic
=== RUN   TestAccRedshiftClusterSnapshot_tags
=== PAUSE TestAccRedshiftClusterSnapshot_tags
=== RUN   TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== RUN   TestAccRedshiftCluster_tags
=== PAUSE TestAccRedshiftCluster_tags
=== RUN   TestAccRedshiftEndpointAccess_basic
=== PAUSE TestAccRedshiftEndpointAccess_basic
=== RUN   TestAccRedshiftEndpointAuthorization_basic
=== PAUSE TestAccRedshiftEndpointAuthorization_basic
=== RUN   TestAccRedshiftEventSubscription_basic
=== PAUSE TestAccRedshiftEventSubscription_basic
=== RUN   TestAccRedshiftEventSubscription_tags
=== PAUSE TestAccRedshiftEventSubscription_tags
=== RUN   TestAccRedshiftHSMClientCertificate_basic
=== PAUSE TestAccRedshiftHSMClientCertificate_basic
=== RUN   TestAccRedshiftHSMClientCertificate_tags
=== PAUSE TestAccRedshiftHSMClientCertificate_tags
=== RUN   TestAccRedshiftHSMConfiguration_basic
=== PAUSE TestAccRedshiftHSMConfiguration_basic
=== RUN   TestAccRedshiftHSMConfiguration_tags
=== PAUSE TestAccRedshiftHSMConfiguration_tags
=== RUN   TestAccRedshiftParameterGroup_basic
=== PAUSE TestAccRedshiftParameterGroup_basic
=== RUN   TestAccRedshiftParameterGroup_tags
=== PAUSE TestAccRedshiftParameterGroup_tags
=== RUN   TestAccRedshiftPartner_basic
=== PAUSE TestAccRedshiftPartner_basic
=== RUN   TestAccRedshiftServiceAccountDataSource_basic
=== PAUSE TestAccRedshiftServiceAccountDataSource_basic
=== RUN   TestAccRedshiftSnapshotCopyGrant_basic
=== PAUSE TestAccRedshiftSnapshotCopyGrant_basic
=== RUN   TestAccRedshiftSnapshotScheduleAssociation_basic
=== PAUSE TestAccRedshiftSnapshotScheduleAssociation_basic
=== RUN   TestAccRedshiftSnapshotSchedule_basic
=== PAUSE TestAccRedshiftSnapshotSchedule_basic
=== RUN   TestAccRedshiftSubnetGroupDataSource_basic
=== PAUSE TestAccRedshiftSubnetGroupDataSource_basic
=== RUN   TestAccRedshiftSubnetGroup_basic
=== PAUSE TestAccRedshiftSubnetGroup_basic
=== RUN   TestAccRedshiftSubnetGroup_tags
=== PAUSE TestAccRedshiftSubnetGroup_tags
=== RUN   TestAccRedshiftUsageLimit_basic
=== PAUSE TestAccRedshiftUsageLimit_basic
=== RUN   TestAccRedshiftUsageLimit_tags
=== PAUSE TestAccRedshiftUsageLimit_tags
=== CONT  TestAccRedshiftAuthenticationProfile_basic
=== CONT  TestAccRedshiftHSMConfiguration_basic
=== CONT  TestAccRedshiftSnapshotScheduleAssociation_basic
--- PASS: TestAccRedshiftHSMConfiguration_basic (71.65s)
=== CONT  TestAccRedshiftUsageLimit_tags
--- PASS: TestAccRedshiftAuthenticationProfile_basic (100.05s)
=== CONT  TestAccRedshiftUsageLimit_basic
--- PASS: TestAccRedshiftSnapshotScheduleAssociation_basic (349.99s)
=== CONT  TestAccRedshiftSubnetGroup_tags
--- PASS: TestAccRedshiftUsageLimit_basic (292.99s)
=== CONT  TestAccRedshiftSubnetGroup_basic
--- PASS: TestAccRedshiftUsageLimit_tags (348.53s)
=== CONT  TestAccRedshiftSubnetGroupDataSource_basic
--- PASS: TestAccRedshiftSubnetGroup_basic (57.45s)
=== CONT  TestAccRedshiftSnapshotSchedule_basic
--- PASS: TestAccRedshiftSubnetGroupDataSource_basic (47.18s)
=== CONT  TestAccRedshiftPartner_basic
--- PASS: TestAccRedshiftSubnetGroup_tags (123.12s)
=== CONT  TestAccRedshiftSnapshotCopyGrant_basic
--- PASS: TestAccRedshiftSnapshotCopyGrant_basic (34.09s)
=== CONT  TestAccRedshiftServiceAccountDataSource_basic
--- PASS: TestAccRedshiftSnapshotSchedule_basic (57.81s)
=== CONT  TestAccRedshiftCluster_tags
--- PASS: TestAccRedshiftServiceAccountDataSource_basic (12.77s)
=== CONT  TestAccRedshiftClusterSnapshot_basic
--- PASS: TestAccRedshiftPartner_basic (207.68s)
=== CONT  TestAccRedshiftHSMClientCertificate_tags
--- PASS: TestAccRedshiftHSMClientCertificate_tags (56.09s)
=== CONT  TestAccRedshiftCluster_basic
--- PASS: TestAccRedshiftCluster_tags (546.78s)
=== CONT  TestAccRedshiftHSMClientCertificate_basic
--- PASS: TestAccRedshiftHSMClientCertificate_basic (33.59s)
=== CONT  TestAccRedshiftClusterSnapshot_tags
--- PASS: TestAccRedshiftCluster_basic (533.28s)
=== CONT  TestAccRedshiftEventSubscription_tags
--- PASS: TestAccRedshiftClusterSnapshot_basic (745.90s)
=== CONT  TestAccRedshiftClusterDataSource_basic
=== CONT  TestAccRedshiftEventSubscription_tags
    event_subscription_test.go:153: Step 3/4 error: Check failed: Check 2/4 error: aws_redshift_event_subscription.test: Attribute 'tags.%' expected "2", got "0"
--- FAIL: TestAccRedshiftEventSubscription_tags (46.67s)
=== CONT  TestAccRedshiftEventSubscription_basic
--- PASS: TestAccRedshiftEventSubscription_basic (45.67s)
=== CONT  TestAccRedshiftEndpointAuthorization_basic
    acctest.go:772: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftEndpointAuthorization_basic (0.00s)
=== CONT  TestAccRedshiftEndpointAccess_basic
--- PASS: TestAccRedshiftClusterDataSource_basic (250.35s)
=== CONT  TestAccRedshiftClusterCredentialsDataSource_basic
--- PASS: TestAccRedshiftClusterSnapshot_tags (591.94s)
=== CONT  TestAccRedshiftClusterIAMRoles_basic
--- PASS: TestAccRedshiftClusterCredentialsDataSource_basic (228.62s)
=== CONT  TestAccRedshiftParameterGroup_basic
--- PASS: TestAccRedshiftParameterGroup_basic (17.49s)
=== CONT  TestAccRedshiftParameterGroup_tags
--- PASS: TestAccRedshiftParameterGroup_tags (38.54s)
=== CONT  TestAccRedshiftHSMConfiguration_tags
--- PASS: TestAccRedshiftHSMConfiguration_tags (40.33s)
--- PASS: TestAccRedshiftClusterIAMRoles_basic (300.83s)
--- PASS: TestAccRedshiftEndpointAccess_basic (902.60s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	2285.704s
=== RUN   TestAccRedshiftDataStatement_basic
=== PAUSE TestAccRedshiftDataStatement_basic
=== CONT  TestAccRedshiftDataStatement_basic
--- PASS: TestAccRedshiftDataStatement_basic (283.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftdata	331.822s
=== RUN   TestAccRedshiftServerlessCredentialsDataSource_basic
=== PAUSE TestAccRedshiftServerlessCredentialsDataSource_basic
=== RUN   TestAccRedshiftServerlessEndpointAccess_basic
=== PAUSE TestAccRedshiftServerlessEndpointAccess_basic
=== RUN   TestAccRedshiftServerlessNamespace_basic
=== PAUSE TestAccRedshiftServerlessNamespace_basic
=== RUN   TestAccRedshiftServerlessNamespace_tags
=== PAUSE TestAccRedshiftServerlessNamespace_tags
=== RUN   TestAccRedshiftServerlessResourcePolicy_basic
=== PAUSE TestAccRedshiftServerlessResourcePolicy_basic
=== RUN   TestAccRedshiftServerlessSnapshot_basic
=== PAUSE TestAccRedshiftServerlessSnapshot_basic
=== RUN   TestAccRedshiftServerlessUsageLimit_basic
=== PAUSE TestAccRedshiftServerlessUsageLimit_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_basic
=== PAUSE TestAccRedshiftServerlessWorkgroup_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_tags
=== PAUSE TestAccRedshiftServerlessWorkgroup_tags
=== CONT  TestAccRedshiftServerlessCredentialsDataSource_basic
=== CONT  TestAccRedshiftServerlessSnapshot_basic
=== CONT  TestAccRedshiftServerlessWorkgroup_basic
--- PASS: TestAccRedshiftServerlessCredentialsDataSource_basic (555.77s)
=== CONT  TestAccRedshiftServerlessWorkgroup_tags
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (694.42s)
=== CONT  TestAccRedshiftServerlessNamespace_tags
--- PASS: TestAccRedshiftServerlessNamespace_tags (62.97s)
=== CONT  TestAccRedshiftServerlessResourcePolicy_basic
    acctest.go:772: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftServerlessResourcePolicy_basic (0.00s)
=== CONT  TestAccRedshiftServerlessUsageLimit_basic
--- PASS: TestAccRedshiftServerlessSnapshot_basic (894.65s)
=== CONT  TestAccRedshiftServerlessNamespace_basic
--- PASS: TestAccRedshiftServerlessNamespace_basic (39.91s)
=== CONT  TestAccRedshiftServerlessEndpointAccess_basic
--- PASS: TestAccRedshiftServerlessWorkgroup_tags (644.26s)
--- PASS: TestAccRedshiftServerlessUsageLimit_basic (882.08s)
--- PASS: TestAccRedshiftServerlessEndpointAccess_basic (1415.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	2387.193s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2	44.759s [no tests to run]
=== RUN   TestAccResourceGroupsGroup_basic
=== PAUSE TestAccResourceGroupsGroup_basic
=== RUN   TestAccResourceGroupsGroup_tags
=== PAUSE TestAccResourceGroupsGroup_tags
=== CONT  TestAccResourceGroupsGroup_basic
=== CONT  TestAccResourceGroupsGroup_tags
--- PASS: TestAccResourceGroupsGroup_basic (72.21s)
--- PASS: TestAccResourceGroupsGroup_tags (91.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	137.157s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstaggingapi	10.179s [no tests to run]
=== RUN   TestAccRolesAnywhereProfile_basic
=== PAUSE TestAccRolesAnywhereProfile_basic
=== RUN   TestAccRolesAnywhereProfile_tags
=== PAUSE TestAccRolesAnywhereProfile_tags
=== RUN   TestAccRolesAnywhereTrustAnchor_basic
=== PAUSE TestAccRolesAnywhereTrustAnchor_basic
=== RUN   TestAccRolesAnywhereTrustAnchor_tags
=== PAUSE TestAccRolesAnywhereTrustAnchor_tags
=== CONT  TestAccRolesAnywhereProfile_basic
=== CONT  TestAccRolesAnywhereTrustAnchor_basic
=== CONT  TestAccRolesAnywhereTrustAnchor_tags
=== CONT  TestAccRolesAnywhereTrustAnchor_basic
    trust_anchor_test.go:25: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating RolesAnywhere Trust Anchor (tf-acc-test-6790653190008838439): operation error RolesAnywhere: CreateTrustAnchor, https response error StatusCode: 403, RequestID: 60c08ff0-65c2-4fe9-8d3b-d74a952e5e9a, AccessDeniedException: Unauthorized because no identity-based policy allows for the iam:CreateServiceLinkedRole action
        
          with aws_rolesanywhere_trust_anchor.test,
          on terraform_plugin_test.tf line 35, in resource "aws_rolesanywhere_trust_anchor" "test":
          35: resource "aws_rolesanywhere_trust_anchor" "test" {
        
--- FAIL: TestAccRolesAnywhereTrustAnchor_basic (23.03s)
=== CONT  TestAccRolesAnywhereProfile_tags
--- PASS: TestAccRolesAnywhereProfile_basic (33.55s)
--- PASS: TestAccRolesAnywhereTrustAnchor_tags (101.74s)
--- PASS: TestAccRolesAnywhereProfile_tags (93.84s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rolesanywhere	128.519s
=== RUN   TestAccRoute53CIDRCollection_basic
=== PAUSE TestAccRoute53CIDRCollection_basic
=== RUN   TestAccRoute53CIDRLocation_basic
=== PAUSE TestAccRoute53CIDRLocation_basic
=== RUN   TestAccRoute53DelegationSetDataSource_basic
--- PASS: TestAccRoute53DelegationSetDataSource_basic (76.26s)
=== RUN   TestAccRoute53DelegationSet_basic
=== PAUSE TestAccRoute53DelegationSet_basic
=== RUN   TestAccRoute53HealthCheck_basic
=== PAUSE TestAccRoute53HealthCheck_basic
=== RUN   TestAccRoute53HealthCheck_tags
=== PAUSE TestAccRoute53HealthCheck_tags
=== RUN   TestAccRoute53HostedZoneDNSSEC_basic
=== PAUSE TestAccRoute53HostedZoneDNSSEC_basic
=== RUN   TestAccRoute53KeySigningKey_basic
=== PAUSE TestAccRoute53KeySigningKey_basic
=== RUN   TestAccRoute53QueryLog_basic
=== PAUSE TestAccRoute53QueryLog_basic
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN   TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN   TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN   TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== PAUSE TestAccRoute53TrafficPolicyDocumentDataSource_basic
=== RUN   TestAccRoute53TrafficPolicyInstance_basic
=== PAUSE TestAccRoute53TrafficPolicyInstance_basic
=== RUN   TestAccRoute53TrafficPolicy_basic
=== PAUSE TestAccRoute53TrafficPolicy_basic
=== RUN   TestAccRoute53VPCAssociationAuthorization_basic
=== PAUSE TestAccRoute53VPCAssociationAuthorization_basic
=== RUN   TestAccRoute53ZoneAssociation_basic
=== PAUSE TestAccRoute53ZoneAssociation_basic
=== RUN   TestAccRoute53ZoneDataSource_tags
=== PAUSE TestAccRoute53ZoneDataSource_tags
=== RUN   TestAccRoute53Zone_basic
=== PAUSE TestAccRoute53Zone_basic
=== RUN   TestAccRoute53Zone_tags
=== PAUSE TestAccRoute53Zone_tags
=== CONT  TestAccRoute53CIDRCollection_basic
=== CONT  TestAccRoute53Record_Geolocation_basic
=== CONT  TestAccRoute53KeySigningKey_basic
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53KeySigningKey_basic (0.00s)
=== CONT  TestAccRoute53VPCAssociationAuthorization_basic
    acctest.go:772: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRoute53VPCAssociationAuthorization_basic (0.00s)
=== CONT  TestAccRoute53Zone_tags
--- PASS: TestAccRoute53CIDRCollection_basic (38.96s)
=== CONT  TestAccRoute53Zone_basic
--- PASS: TestAccRoute53Zone_basic (78.96s)
=== CONT  TestAccRoute53ZoneDataSource_tags
--- PASS: TestAccRoute53Zone_tags (167.57s)
=== CONT  TestAccRoute53ZoneAssociation_basic
--- PASS: TestAccRoute53Record_Geolocation_basic (169.61s)
=== CONT  TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53ZoneDataSource_tags (95.34s)
=== CONT  TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53ZoneAssociation_basic (150.74s)
=== CONT  TestAccRoute53TrafficPolicyDocumentDataSource_basic
--- PASS: TestAccRoute53TrafficPolicyDocumentDataSource_basic (13.25s)
=== CONT  TestAccRoute53TrafficPolicy_basic
--- PASS: TestAccRoute53Record_Weighted_basic (177.25s)
=== CONT  TestAccRoute53TrafficPolicyInstance_basic
--- PASS: TestAccRoute53TrafficPolicy_basic (17.64s)
=== CONT  TestAccRoute53HealthCheck_basic
--- PASS: TestAccRoute53HealthCheck_basic (33.22s)
=== CONT  TestAccRoute53HostedZoneDNSSEC_basic
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53HostedZoneDNSSEC_basic (0.00s)
=== CONT  TestAccRoute53HealthCheck_tags
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (201.60s)
=== CONT  TestAccRoute53DelegationSet_basic
--- PASS: TestAccRoute53HealthCheck_tags (60.05s)
=== CONT  TestAccRoute53QueryLog_basic
    acctest.go:834: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccRoute53QueryLog_basic (0.00s)
=== CONT  TestAccRoute53CIDRLocation_basic
--- PASS: TestAccRoute53DelegationSet_basic (27.71s)
=== CONT  TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53CIDRLocation_basic (26.33s)
=== CONT  TestAccRoute53Record_basic
--- PASS: TestAccRoute53TrafficPolicyInstance_basic (156.82s)
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (118.95s)
--- PASS: TestAccRoute53Record_basic (144.74s)
--- PASS: TestAccRoute53Record_Latency_basic (161.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	757.079s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	16.567s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig	16.883s [no tests to run]
=== RUN   TestAccRoute53RecoveryReadinessCell_basic
=== PAUSE TestAccRoute53RecoveryReadinessCell_basic
=== RUN   TestAccRoute53RecoveryReadinessCell_tags
=== PAUSE TestAccRoute53RecoveryReadinessCell_tags
=== RUN   TestAccRoute53RecoveryReadinessReadinessCheck_basic
=== PAUSE TestAccRoute53RecoveryReadinessReadinessCheck_basic
=== RUN   TestAccRoute53RecoveryReadinessReadinessCheck_tags
=== PAUSE TestAccRoute53RecoveryReadinessReadinessCheck_tags
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_tags
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_tags
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_basic
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_basic
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_tags
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_tags
=== CONT  TestAccRoute53RecoveryReadinessCell_basic
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_tags
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_basic
    recovery_group_test.go:24: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_route53recoveryreadiness_recovery_group.test will be updated in-place
          ~ resource "aws_route53recoveryreadiness_recovery_group" "test" {
                id                  = "tf-acc-test-4505256912069131627"
              + tags_all            = (known after apply)
                # (2 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccRoute53RecoveryReadinessRecoveryGroup_basic (26.71s)
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_basic
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_tags
    resource_set_test.go:99: Step 2/4 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"tags.%":        "1",
        - 	"tags.key1":     "value1",
        - 	"tags_all.%":    "1",
        - 	"tags_all.key1": "value1",
          }
--- PASS: TestAccRoute53RecoveryReadinessCell_basic (39.88s)
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_tags
--- FAIL: TestAccRoute53RecoveryReadinessResourceSet_tags (40.34s)
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_basic
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_basic
    resource_set_test.go:33: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_route53recoveryreadiness_resource_set.test will be updated in-place
          ~ resource "aws_route53recoveryreadiness_resource_set" "test" {
                id                = "tf-acc-test-6696650215917224987"
              + tags_all          = (known after apply)
                # (3 unchanged attributes hidden)
        
              ~ resources {
                  + readiness_scopes = []
                    # (1 unchanged attribute hidden)
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccRoute53RecoveryReadinessResourceSet_basic (26.37s)
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_tags
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_basic
    readiness_check_test.go:34: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_route53recoveryreadiness_resource_set.test will be updated in-place
          ~ resource "aws_route53recoveryreadiness_resource_set" "test" {
                id                = "tf-acc-test-set-2557407895367482572"
              + tags_all          = (known after apply)
                # (3 unchanged attributes hidden)
        
              ~ resources {
                  + readiness_scopes = []
                    # (1 unchanged attribute hidden)
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccRoute53RecoveryReadinessReadinessCheck_basic (31.43s)
=== CONT  TestAccRoute53RecoveryReadinessCell_tags
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_tags
    recovery_group_test.go:103: Step 2/4 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"tags.%":        "1",
        - 	"tags.key1":     "value1",
        - 	"tags_all.%":    "1",
        - 	"tags_all.key1": "value1",
          }
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_tags
    readiness_check_test.go:100: Step 1/4 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_route53recoveryreadiness_resource_set.test will be updated in-place
          ~ resource "aws_route53recoveryreadiness_resource_set" "test" {
                id                = "resource-set-for-testing"
              + tags_all          = (known after apply)
                # (3 unchanged attributes hidden)
        
              ~ resources {
                  + readiness_scopes = []
                    # (1 unchanged attribute hidden)
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccRoute53RecoveryReadinessRecoveryGroup_tags (39.69s)
--- FAIL: TestAccRoute53RecoveryReadinessReadinessCheck_tags (29.97s)
--- PASS: TestAccRoute53RecoveryReadinessCell_tags (103.65s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness	191.929s
=== RUN   TestAccRoute53ResolverConfig_basic
=== PAUSE TestAccRoute53ResolverConfig_basic
=== RUN   TestAccRoute53ResolverDNSSECConfig_basic
=== PAUSE TestAccRoute53ResolverDNSSECConfig_basic
=== RUN   TestAccRoute53ResolverEndpointDataSource_basic
=== PAUSE TestAccRoute53ResolverEndpointDataSource_basic
=== RUN   TestAccRoute53ResolverEndpoint_basic
=== PAUSE TestAccRoute53ResolverEndpoint_basic
=== RUN   TestAccRoute53ResolverEndpoint_tags
=== PAUSE TestAccRoute53ResolverEndpoint_tags
=== RUN   TestAccRoute53ResolverFirewallConfigDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallConfigDataSource_basic (44.09s)
=== RUN   TestAccRoute53ResolverFirewallConfig_basic
=== PAUSE TestAccRoute53ResolverFirewallConfig_basic
=== RUN   TestAccRoute53ResolverFirewallDomainListDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (120.35s)
=== RUN   TestAccRoute53ResolverFirewallDomainList_basic
=== PAUSE TestAccRoute53ResolverFirewallDomainList_basic
=== RUN   TestAccRoute53ResolverFirewallDomainList_tags
=== PAUSE TestAccRoute53ResolverFirewallDomainList_tags
=== RUN   TestAccRoute53ResolverRuleGroupAssociationDataSource_basic
--- PASS: TestAccRoute53ResolverRuleGroupAssociationDataSource_basic (147.37s)
=== RUN   TestAccRoute53ResolverFirewallRuleGroupAssociation_basic
=== PAUSE TestAccRoute53ResolverFirewallRuleGroupAssociation_basic
=== RUN   TestAccRoute53ResolverFirewallRuleGroupAssociation_tags
=== PAUSE TestAccRoute53ResolverFirewallRuleGroupAssociation_tags
=== RUN   TestAccRoute53ResolverFirewallRuleGroupDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroupDataSource_basic (21.59s)
=== RUN   TestAccRoute53ResolverFirewallRuleGroup_basic
=== PAUSE TestAccRoute53ResolverFirewallRuleGroup_basic
=== RUN   TestAccRoute53ResolverFirewallRuleGroup_tags
=== PAUSE TestAccRoute53ResolverFirewallRuleGroup_tags
=== RUN   TestAccRoute53ResolverFirewallRule_basic
=== PAUSE TestAccRoute53ResolverFirewallRule_basic
=== RUN   TestAccRoute53ResolverFirewallRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverFirewallRulesDataSource_basic
=== RUN   TestAccRoute53ResolverQueryLogConfigAssociation_basic
=== PAUSE TestAccRoute53ResolverQueryLogConfigAssociation_basic
=== RUN   TestAccRoute53ResolverQueryLogConfig_basic
=== PAUSE TestAccRoute53ResolverQueryLogConfig_basic
=== RUN   TestAccRoute53ResolverQueryLogConfig_tags
=== PAUSE TestAccRoute53ResolverQueryLogConfig_tags
=== RUN   TestAccRoute53ResolverRuleAssociation_basic
=== PAUSE TestAccRoute53ResolverRuleAssociation_basic
=== RUN   TestAccRoute53ResolverRuleDataSource_basic
=== PAUSE TestAccRoute53ResolverRuleDataSource_basic
=== RUN   TestAccRoute53ResolverRule_basic
=== PAUSE TestAccRoute53ResolverRule_basic
=== RUN   TestAccRoute53ResolverRule_tags
=== PAUSE TestAccRoute53ResolverRule_tags
=== RUN   TestAccRoute53ResolverRulesDataSource_basic
=== PAUSE TestAccRoute53ResolverRulesDataSource_basic
=== CONT  TestAccRoute53ResolverConfig_basic
=== CONT  TestAccRoute53ResolverFirewallRuleGroup_tags
=== CONT  TestAccRoute53ResolverRuleAssociation_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroup_tags (66.93s)
=== CONT  TestAccRoute53ResolverRule_tags
--- PASS: TestAccRoute53ResolverRule_tags (50.08s)
=== CONT  TestAccRoute53ResolverRulesDataSource_basic
--- PASS: TestAccRoute53ResolverRulesDataSource_basic (14.40s)
=== CONT  TestAccRoute53ResolverFirewallDomainList_basic
--- PASS: TestAccRoute53ResolverRuleAssociation_basic (188.83s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroup_basic
--- PASS: TestAccRoute53ResolverFirewallDomainList_basic (62.31s)
=== CONT  TestAccRoute53ResolverEndpoint_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroup_basic (22.95s)
=== CONT  TestAccRoute53ResolverFirewallConfig_basic
--- PASS: TestAccRoute53ResolverFirewallConfig_basic (30.77s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroupAssociation_tags
--- PASS: TestAccRoute53ResolverEndpoint_basic (105.46s)
=== CONT  TestAccRoute53ResolverEndpoint_tags
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_tags (217.99s)
=== CONT  TestAccRoute53ResolverFirewallRuleGroupAssociation_basic
--- PASS: TestAccRoute53ResolverConfig_basic (462.44s)
=== CONT  TestAccRoute53ResolverQueryLogConfigAssociation_basic
--- PASS: TestAccRoute53ResolverEndpoint_tags (187.26s)
=== CONT  TestAccRoute53ResolverQueryLogConfig_tags
--- PASS: TestAccRoute53ResolverQueryLogConfigAssociation_basic (40.32s)
=== CONT  TestAccRoute53ResolverQueryLogConfig_basic
--- PASS: TestAccRoute53ResolverQueryLogConfig_basic (26.59s)
=== CONT  TestAccRoute53ResolverFirewallRulesDataSource_basic
--- PASS: TestAccRoute53ResolverQueryLogConfig_tags (50.13s)
=== CONT  TestAccRoute53ResolverFirewallDomainList_tags
--- PASS: TestAccRoute53ResolverFirewallRuleGroupAssociation_basic (175.60s)
=== CONT  TestAccRoute53ResolverFirewallRule_basic
--- PASS: TestAccRoute53ResolverFirewallDomainList_tags (111.42s)
=== CONT  TestAccRoute53ResolverEndpointDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRule_basic (67.59s)
=== CONT  TestAccRoute53ResolverRule_basic
--- PASS: TestAccRoute53ResolverFirewallRulesDataSource_basic (179.50s)
=== CONT  TestAccRoute53ResolverRuleDataSource_basic
--- PASS: TestAccRoute53ResolverRule_basic (25.74s)
=== CONT  TestAccRoute53ResolverDNSSECConfig_basic
--- PASS: TestAccRoute53ResolverRuleDataSource_basic (25.06s)
--- PASS: TestAccRoute53ResolverEndpointDataSource_basic (106.06s)
--- PASS: TestAccRoute53ResolverDNSSECConfig_basic (417.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	1495.633s
=== RUN   TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN   TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN   TestAccRUMMetricsDestination_basic
=== PAUSE TestAccRUMMetricsDestination_basic
=== CONT  TestAccRUMAppMonitor_basic
=== CONT  TestAccRUMMetricsDestination_basic
=== CONT  TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMMetricsDestination_basic (52.95s)
--- PASS: TestAccRUMAppMonitor_basic (78.36s)
--- PASS: TestAccRUMAppMonitor_tags (99.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	109.866s
FAIL
make: *** [testacc] Error 1
% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=route53recoveryreadiness ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53recoveryreadiness/... -v -count 1 -parallel 3  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccRoute53RecoveryReadinessCell_basic
=== PAUSE TestAccRoute53RecoveryReadinessCell_basic
=== RUN   TestAccRoute53RecoveryReadinessCell_tags
=== PAUSE TestAccRoute53RecoveryReadinessCell_tags
=== RUN   TestAccRoute53RecoveryReadinessReadinessCheck_basic
=== PAUSE TestAccRoute53RecoveryReadinessReadinessCheck_basic
=== RUN   TestAccRoute53RecoveryReadinessReadinessCheck_tags
=== PAUSE TestAccRoute53RecoveryReadinessReadinessCheck_tags
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== RUN   TestAccRoute53RecoveryReadinessRecoveryGroup_tags
=== PAUSE TestAccRoute53RecoveryReadinessRecoveryGroup_tags
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_basic
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_basic
=== RUN   TestAccRoute53RecoveryReadinessResourceSet_tags
=== PAUSE TestAccRoute53RecoveryReadinessResourceSet_tags
=== CONT  TestAccRoute53RecoveryReadinessCell_basic
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_basic
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_basic
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_basic (29.36s)
=== CONT  TestAccRoute53RecoveryReadinessRecoveryGroup_tags
--- PASS: TestAccRoute53RecoveryReadinessCell_basic (29.47s)
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_basic
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_basic (29.65s)
=== CONT  TestAccRoute53RecoveryReadinessReadinessCheck_tags
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_basic (34.93s)
=== CONT  TestAccRoute53RecoveryReadinessCell_tags
--- PASS: TestAccRoute53RecoveryReadinessRecoveryGroup_tags (80.46s)
=== CONT  TestAccRoute53RecoveryReadinessResourceSet_tags
--- PASS: TestAccRoute53RecoveryReadinessReadinessCheck_tags (86.12s)
--- PASS: TestAccRoute53RecoveryReadinessCell_tags (72.41s)
--- PASS: TestAccRoute53RecoveryReadinessResourceSet_tags (51.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness	179.824s
% make testacc TESTARGS='-run=TestAccRedshiftEventSubscription_' PKG=redshift ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 3  -run=TestAccRedshiftEventSubscription_ -timeout 180m
=== RUN   TestAccRedshiftEventSubscription_basic
=== PAUSE TestAccRedshiftEventSubscription_basic
=== RUN   TestAccRedshiftEventSubscription_withSourceIDs
=== PAUSE TestAccRedshiftEventSubscription_withSourceIDs
=== RUN   TestAccRedshiftEventSubscription_categoryUpdate
=== PAUSE TestAccRedshiftEventSubscription_categoryUpdate
=== RUN   TestAccRedshiftEventSubscription_tags
=== PAUSE TestAccRedshiftEventSubscription_tags
=== RUN   TestAccRedshiftEventSubscription_disappears
=== PAUSE TestAccRedshiftEventSubscription_disappears
=== CONT  TestAccRedshiftEventSubscription_basic
=== CONT  TestAccRedshiftEventSubscription_tags
=== CONT  TestAccRedshiftEventSubscription_disappears
--- PASS: TestAccRedshiftEventSubscription_disappears (24.35s)
=== CONT  TestAccRedshiftEventSubscription_categoryUpdate
--- PASS: TestAccRedshiftEventSubscription_basic (54.15s)
=== CONT  TestAccRedshiftEventSubscription_withSourceIDs
--- PASS: TestAccRedshiftEventSubscription_tags (67.68s)
--- PASS: TestAccRedshiftEventSubscription_categoryUpdate (52.88s)
--- PASS: TestAccRedshiftEventSubscription_withSourceIDs (44.67s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	105.598s
% make testacc TESTARGS='-run=TestAccRDSCluster_tags' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCluster_tags -timeout 180m
=== RUN   TestAccRDSCluster_tags
=== PAUSE TestAccRDSCluster_tags
=== CONT  TestAccRDSCluster_tags
--- PASS: TestAccRDSCluster_tags (199.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	204.787s

@ewbankkit ewbankkit changed the title Tech debt: Reduce tags boilerplate code - Plugin Framework resources r* (Phase 3c) Tech debt: Reduce tags boilerplate code - Plugin SDK resources r* (Phase 3c) Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. service/ram Issues and PRs that pertain to the ram service. service/rbin Issues and PRs that pertain to the rbin service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. service/rolesanywhere Issues and PRs that pertain to the rolesanywhere service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53recoveryreadiness Issues and PRs that pertain to the route53recoveryreadiness service. service/rum Issues and PRs that pertain to the rum service. labels Apr 4, 2023
@ewbankkit ewbankkit mentioned this pull request Apr 4, 2023
Merged
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Apr 5, 2023
@ewbankkit ewbankkit merged commit 297e6c9 into main Apr 5, 2023
38 checks passed
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3c-r branch April 5, 2023 12:25
@github-actions github-actions bot added this to the v4.62.0 milestone Apr 5, 2023
@ewbankkit ewbankkit mentioned this pull request Apr 5, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Apr 5, 2023
Update CHANGELOG.md for #30461
077b23b
This was referenced Apr 5, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced Apr 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented May 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. service/ram Issues and PRs that pertain to the ram service. service/rbin Issues and PRs that pertain to the rbin service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. service/rolesanywhere Issues and PRs that pertain to the rolesanywhere service. service/route53recoveryreadiness Issues and PRs that pertain to the route53recoveryreadiness service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/rum Issues and PRs that pertain to the rum service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.62.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ewbankkit