Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Reduce tags boilerplate code - Plugin SDK resources d* (Phase 3c) #30509

Merged
merged 17 commits into from
Apr 6, 2023
Merged

Tech debt: Reduce tags boilerplate code - Plugin SDK resources d* (Phase 3c) #30509

merged 17 commits into from
Apr 6, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 6, 2023 •
edited

Description

Extends the work done in Phase 2 to the remaining resources implemented using Terraform Plugin SDK.

Relations

Relates #30280.
Relates #29747.
Relates #30417.
Relates #30421.
Relates #30430.
Relates #30449.
Relates #30454.
Relates #30461.
Relates #30463.
Relates #30476.
Relates #30477.
Relates #30478.
Relates #30483.
Relates #30484.
Relates #30491.

Output from Acceptance Testing

% make testacc TESTARGS='-run=_basic$$\|_tags$$' PKG=d... ACCTEST_PARALLELISM=2   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/d.../... -v -count 1 -parallel 2  -run=_basic$\|_tags$ -timeout 180m
=== RUN   TestAccDataExchangeDataSet_basic
=== PAUSE TestAccDataExchangeDataSet_basic
=== RUN   TestAccDataExchangeDataSet_tags
=== PAUSE TestAccDataExchangeDataSet_tags
=== RUN   TestAccDataExchangeRevision_basic
=== PAUSE TestAccDataExchangeRevision_basic
=== RUN   TestAccDataExchangeRevision_tags
=== PAUSE TestAccDataExchangeRevision_tags
=== CONT  TestAccDataExchangeDataSet_basic
=== CONT  TestAccDataExchangeRevision_tags
--- PASS: TestAccDataExchangeDataSet_basic (67.46s)
=== CONT  TestAccDataExchangeRevision_basic
--- PASS: TestAccDataExchangeRevision_tags (98.36s)
=== CONT  TestAccDataExchangeDataSet_tags
--- PASS: TestAccDataExchangeRevision_basic (45.09s)
--- PASS: TestAccDataExchangeDataSet_tags (100.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	208.510s
=== RUN   TestAccDataPipelinePipelineDataSource_basic
=== PAUSE TestAccDataPipelinePipelineDataSource_basic
=== RUN   TestAccDataPipelinePipelineDefinitionDataSource_basic
=== PAUSE TestAccDataPipelinePipelineDefinitionDataSource_basic
=== RUN   TestAccDataPipelinePipelineDefinition_basic
=== PAUSE TestAccDataPipelinePipelineDefinition_basic
=== RUN   TestAccDataPipelinePipeline_basic
=== PAUSE TestAccDataPipelinePipeline_basic
=== RUN   TestAccDataPipelinePipeline_tags
=== PAUSE TestAccDataPipelinePipeline_tags
=== CONT  TestAccDataPipelinePipelineDataSource_basic
=== CONT  TestAccDataPipelinePipeline_basic
--- PASS: TestAccDataPipelinePipelineDataSource_basic (36.25s)
=== CONT  TestAccDataPipelinePipeline_tags
--- PASS: TestAccDataPipelinePipeline_basic (67.99s)
=== CONT  TestAccDataPipelinePipelineDefinition_basic
--- PASS: TestAccDataPipelinePipelineDefinition_basic (44.75s)
=== CONT  TestAccDataPipelinePipelineDefinitionDataSource_basic
--- PASS: TestAccDataPipelinePipeline_tags (109.50s)
--- PASS: TestAccDataPipelinePipelineDefinitionDataSource_basic (42.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline	173.157s
=== RUN   TestAccDataSyncAgent_basic
=== PAUSE TestAccDataSyncAgent_basic
=== RUN   TestAccDataSyncAgent_tags
=== PAUSE TestAccDataSyncAgent_tags
=== RUN   TestAccDataSyncLocationEFS_basic
=== PAUSE TestAccDataSyncLocationEFS_basic
=== RUN   TestAccDataSyncLocationEFS_tags
=== PAUSE TestAccDataSyncLocationEFS_tags
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxLustreFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxLustreFileSystem_tags
=== RUN   TestAccDataSyncLocationFSxOpenZFSFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxOpenZFSFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxOpenZFSFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxOpenZFSFileSystem_tags
=== RUN   TestAccDataSyncLocationFSxWindowsFileSystem_basic
=== PAUSE TestAccDataSyncLocationFSxWindowsFileSystem_basic
=== RUN   TestAccDataSyncLocationFSxWindowsFileSystem_tags
=== PAUSE TestAccDataSyncLocationFSxWindowsFileSystem_tags
=== RUN   TestAccDataSyncLocationHDFS_basic
=== PAUSE TestAccDataSyncLocationHDFS_basic
=== RUN   TestAccDataSyncLocationHDFS_tags
=== PAUSE TestAccDataSyncLocationHDFS_tags
=== RUN   TestAccDataSyncLocationNFS_basic
=== PAUSE TestAccDataSyncLocationNFS_basic
=== RUN   TestAccDataSyncLocationNFS_tags
=== PAUSE TestAccDataSyncLocationNFS_tags
=== RUN   TestAccDataSyncLocationObjectStorage_basic
=== PAUSE TestAccDataSyncLocationObjectStorage_basic
=== RUN   TestAccDataSyncLocationObjectStorage_tags
=== PAUSE TestAccDataSyncLocationObjectStorage_tags
=== RUN   TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN   TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== RUN   TestAccDataSyncLocationSMB_basic
=== PAUSE TestAccDataSyncLocationSMB_basic
=== RUN   TestAccDataSyncLocationSMB_tags
=== PAUSE TestAccDataSyncLocationSMB_tags
=== RUN   TestAccDataSyncTask_basic
=== PAUSE TestAccDataSyncTask_basic
=== RUN   TestAccDataSyncTask_tags
=== PAUSE TestAccDataSyncTask_tags
=== CONT  TestAccDataSyncAgent_basic
=== CONT  TestAccDataSyncTask_tags
--- PASS: TestAccDataSyncAgent_basic (122.25s)
=== CONT  TestAccDataSyncTask_basic
--- PASS: TestAccDataSyncTask_tags (277.70s)
=== CONT  TestAccDataSyncLocationSMB_tags
--- PASS: TestAccDataSyncTask_basic (281.80s)
=== CONT  TestAccDataSyncLocationSMB_basic
--- PASS: TestAccDataSyncLocationSMB_tags (171.61s)
=== CONT  TestAccDataSyncLocationS3_tags
--- PASS: TestAccDataSyncLocationS3_tags (72.29s)
=== CONT  TestAccDataSyncLocationS3_basic
--- PASS: TestAccDataSyncLocationS3_basic (31.19s)
=== CONT  TestAccDataSyncLocationObjectStorage_tags
--- PASS: TestAccDataSyncLocationSMB_basic (165.22s)
=== CONT  TestAccDataSyncLocationObjectStorage_basic
--- PASS: TestAccDataSyncLocationObjectStorage_basic (132.20s)
=== CONT  TestAccDataSyncLocationNFS_tags
    location_nfs_test.go:189: Step 1/4 error: Error running pre-apply refresh: exit status 1
        
        Error: Your query returned no results. Please change your search criteria and try again.
        
          with data.aws_ami.aws-thinstaller,
          on terraform_plugin_test.tf line 2, in data "aws_ami" "aws-thinstaller":
           2: data "aws_ami" "aws-thinstaller" {
        
--- FAIL: TestAccDataSyncLocationNFS_tags (2.61s)
=== CONT  TestAccDataSyncLocationNFS_basic
    location_nfs_test.go:26: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Your query returned no results. Please change your search criteria and try again.
        
          with data.aws_ami.aws-thinstaller,
          on terraform_plugin_test.tf line 2, in data "aws_ami" "aws-thinstaller":
           2: data "aws_ami" "aws-thinstaller" {
        
--- FAIL: TestAccDataSyncLocationNFS_basic (2.58s)
=== CONT  TestAccDataSyncLocationHDFS_tags
--- PASS: TestAccDataSyncLocationObjectStorage_tags (168.42s)
=== CONT  TestAccDataSyncLocationHDFS_basic
--- PASS: TestAccDataSyncLocationHDFS_basic (118.09s)
=== CONT  TestAccDataSyncLocationFSxWindowsFileSystem_tags
--- PASS: TestAccDataSyncLocationHDFS_tags (175.46s)
=== CONT  TestAccDataSyncLocationFSxWindowsFileSystem_basic
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_tags (3327.23s)
=== CONT  TestAccDataSyncLocationFSxOpenZFSFileSystem_tags
--- PASS: TestAccDataSyncLocationFSxWindowsFileSystem_basic (3369.86s)
=== CONT  TestAccDataSyncLocationFSxOpenZFSFileSystem_basic
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_tags (873.90s)
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_tags
--- PASS: TestAccDataSyncLocationFSxOpenZFSFileSystem_basic (794.39s)
=== CONT  TestAccDataSyncLocationFSxLustreFileSystem_basic
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_basic (732.71s)
=== CONT  TestAccDataSyncLocationEFS_tags
--- PASS: TestAccDataSyncLocationFSxLustreFileSystem_tags (778.79s)
=== CONT  TestAccDataSyncLocationEFS_basic
--- PASS: TestAccDataSyncLocationEFS_basic (145.27s)
=== CONT  TestAccDataSyncAgent_tags
--- PASS: TestAccDataSyncLocationEFS_tags (189.35s)
--- PASS: TestAccDataSyncAgent_tags (226.71s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	6204.979s
=== RUN   TestAccDAXCluster_basic
=== PAUSE TestAccDAXCluster_basic
=== RUN   TestAccDAXParameterGroup_basic
=== PAUSE TestAccDAXParameterGroup_basic
=== RUN   TestAccDAXSubnetGroup_basic
=== PAUSE TestAccDAXSubnetGroup_basic
=== CONT  TestAccDAXCluster_basic
=== CONT  TestAccDAXSubnetGroup_basic
--- PASS: TestAccDAXSubnetGroup_basic (80.36s)
=== CONT  TestAccDAXParameterGroup_basic
--- PASS: TestAccDAXParameterGroup_basic (82.27s)
--- PASS: TestAccDAXCluster_basic (752.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dax	759.098s
=== RUN   TestAccDeployApp_basic
=== PAUSE TestAccDeployApp_basic
=== RUN   TestAccDeployApp_tags
=== PAUSE TestAccDeployApp_tags
=== RUN   TestAccDeployDeploymentConfig_basic
=== PAUSE TestAccDeployDeploymentConfig_basic
=== RUN   TestAccDeployDeploymentGroup_basic
=== PAUSE TestAccDeployDeploymentGroup_basic
=== RUN   TestAccDeployDeploymentGroup_tags
=== PAUSE TestAccDeployDeploymentGroup_tags
=== RUN   TestAccDeployDeploymentGroup_Trigger_basic
=== PAUSE TestAccDeployDeploymentGroup_Trigger_basic
=== CONT  TestAccDeployApp_basic
=== CONT  TestAccDeployDeploymentGroup_basic
--- PASS: TestAccDeployApp_basic (45.05s)
=== CONT  TestAccDeployDeploymentConfig_basic
--- PASS: TestAccDeployDeploymentConfig_basic (47.64s)
=== CONT  TestAccDeployDeploymentGroup_Trigger_basic
--- PASS: TestAccDeployDeploymentGroup_basic (106.08s)
=== CONT  TestAccDeployDeploymentGroup_tags
--- PASS: TestAccDeployDeploymentGroup_Trigger_basic (85.82s)
=== CONT  TestAccDeployApp_tags
--- PASS: TestAccDeployDeploymentGroup_tags (114.84s)
--- PASS: TestAccDeployApp_tags (78.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	291.954s
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/detective	23.011s [no tests to run]
=== RUN   TestAccDeviceFarmDevicePool_basic
=== PAUSE TestAccDeviceFarmDevicePool_basic
=== RUN   TestAccDeviceFarmDevicePool_tags
=== PAUSE TestAccDeviceFarmDevicePool_tags
=== RUN   TestAccDeviceFarmInstanceProfile_basic
=== PAUSE TestAccDeviceFarmInstanceProfile_basic
=== RUN   TestAccDeviceFarmInstanceProfile_tags
=== PAUSE TestAccDeviceFarmInstanceProfile_tags
=== RUN   TestAccDeviceFarmNetworkProfile_basic
=== PAUSE TestAccDeviceFarmNetworkProfile_basic
=== RUN   TestAccDeviceFarmNetworkProfile_tags
=== PAUSE TestAccDeviceFarmNetworkProfile_tags
=== RUN   TestAccDeviceFarmProject_basic
=== PAUSE TestAccDeviceFarmProject_basic
=== RUN   TestAccDeviceFarmProject_tags
=== PAUSE TestAccDeviceFarmProject_tags
=== RUN   TestAccDeviceFarmTestGridProject_basic
=== PAUSE TestAccDeviceFarmTestGridProject_basic
=== RUN   TestAccDeviceFarmTestGridProject_tags
=== PAUSE TestAccDeviceFarmTestGridProject_tags
=== RUN   TestAccDeviceFarmUpload_basic
=== PAUSE TestAccDeviceFarmUpload_basic
=== CONT  TestAccDeviceFarmDevicePool_basic
=== CONT  TestAccDeviceFarmProject_basic
--- PASS: TestAccDeviceFarmProject_basic (67.71s)
=== CONT  TestAccDeviceFarmInstanceProfile_tags
--- PASS: TestAccDeviceFarmDevicePool_basic (78.05s)
=== CONT  TestAccDeviceFarmNetworkProfile_tags
--- PASS: TestAccDeviceFarmInstanceProfile_tags (109.11s)
=== CONT  TestAccDeviceFarmNetworkProfile_basic
--- PASS: TestAccDeviceFarmNetworkProfile_tags (110.30s)
=== CONT  TestAccDeviceFarmInstanceProfile_basic
--- PASS: TestAccDeviceFarmNetworkProfile_basic (60.79s)
=== CONT  TestAccDeviceFarmTestGridProject_tags
--- PASS: TestAccDeviceFarmInstanceProfile_basic (59.03s)
=== CONT  TestAccDeviceFarmUpload_basic
--- PASS: TestAccDeviceFarmUpload_basic (51.40s)
=== CONT  TestAccDeviceFarmDevicePool_tags
--- PASS: TestAccDeviceFarmTestGridProject_tags (77.10s)
=== CONT  TestAccDeviceFarmTestGridProject_basic
--- PASS: TestAccDeviceFarmTestGridProject_basic (45.62s)
=== CONT  TestAccDeviceFarmProject_tags
--- PASS: TestAccDeviceFarmDevicePool_tags (77.59s)
--- PASS: TestAccDeviceFarmProject_tags (52.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm	441.337s
=== RUN   TestAccDirectConnectBGPPeer_basic
    bgp_peer_test.go:24: Environment variable DX_VIRTUAL_INTERFACE_ID is not set
--- SKIP: TestAccDirectConnectBGPPeer_basic (0.00s)
=== RUN   TestAccDirectConnectConnectionAssociation_basic
=== PAUSE TestAccDirectConnectConnectionAssociation_basic
=== RUN   TestAccDirectConnectConnectionConfirmation_basic
    acctest.go:76: TEST_AWS_DX_CONNECTION_ID and TEST_AWS_DX_OWNER_ACCOUNT_ID must be set for tests involving hosted connections
--- SKIP: TestAccDirectConnectConnectionConfirmation_basic (0.00s)
=== RUN   TestAccDirectConnectConnectionDataSource_basic
=== PAUSE TestAccDirectConnectConnectionDataSource_basic
=== RUN   TestAccDirectConnectConnection_basic
=== PAUSE TestAccDirectConnectConnection_basic
=== RUN   TestAccDirectConnectConnection_tags
=== PAUSE TestAccDirectConnectConnection_tags
=== RUN   TestAccDirectConnectGatewayDataSource_basic
=== PAUSE TestAccDirectConnectGatewayDataSource_basic
=== RUN   TestAccDirectConnectGateway_basic
=== PAUSE TestAccDirectConnectGateway_basic
=== RUN   TestAccDirectConnectHostedConnection_basic
    acctest.go:76: TEST_AWS_DX_CONNECTION_ID and TEST_AWS_DX_OWNER_ACCOUNT_ID must be set for tests involving hosted connections
--- SKIP: TestAccDirectConnectHostedConnection_basic (0.00s)
=== RUN   TestAccDirectConnectHostedPrivateVirtualInterface_basic
    hosted_private_virtual_interface_test.go:24: Environment variable DX_CONNECTION_ID is not set
--- SKIP: TestAccDirectConnectHostedPrivateVirtualInterface_basic (0.00s)
=== RUN   TestAccDirectConnectHostedPublicVirtualInterface_basic
    hosted_public_virtual_interface_test.go:24: Environment variable DX_CONNECTION_ID is not set
--- SKIP: TestAccDirectConnectHostedPublicVirtualInterface_basic (0.00s)
=== RUN   TestAccDirectConnectLag_basic
=== PAUSE TestAccDirectConnectLag_basic
=== RUN   TestAccDirectConnectLag_tags
=== PAUSE TestAccDirectConnectLag_tags
=== RUN   TestAccDirectConnectLocationDataSource_basic
=== PAUSE TestAccDirectConnectLocationDataSource_basic
=== RUN   TestAccDirectConnectPrivateVirtualInterface_basic
    private_virtual_interface_test.go:24: Environment variable DX_CONNECTION_ID is not set
--- SKIP: TestAccDirectConnectPrivateVirtualInterface_basic (0.00s)
=== RUN   TestAccDirectConnectPrivateVirtualInterface_tags
    private_virtual_interface_test.go:97: Environment variable DX_CONNECTION_ID is not set
--- SKIP: TestAccDirectConnectPrivateVirtualInterface_tags (0.00s)
=== RUN   TestAccDirectConnectPublicVirtualInterface_basic
    public_virtual_interface_test.go:24: Environment variable DX_CONNECTION_ID is not set
--- SKIP: TestAccDirectConnectPublicVirtualInterface_basic (0.00s)
=== RUN   TestAccDirectConnectPublicVirtualInterface_tags
    public_virtual_interface_test.go:81: Environment variable DX_CONNECTION_ID is not set
--- SKIP: TestAccDirectConnectPublicVirtualInterface_tags (0.00s)
=== RUN   TestAccDirectConnectRouterConfigurationDataSource_basic
    router_configuration_data_source_test.go:18: Environment variable VIRTUAL_INTERFACE_ID is not set
--- SKIP: TestAccDirectConnectRouterConfigurationDataSource_basic (0.00s)
=== CONT  TestAccDirectConnectConnectionAssociation_basic
=== CONT  TestAccDirectConnectGateway_basic
=== CONT  TestAccDirectConnectConnectionAssociation_basic
    connection_association_test.go:23: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating Direct Connect LAG (tf-acc-test-2820480487801587430): DirectConnectClientException: Could not find an available port in Direct Connect location DBLV1
        
          with aws_dx_lag.test,
          on terraform_plugin_test.tf line 14, in resource "aws_dx_lag" "test":
          14: resource "aws_dx_lag" "test" {
        
--- FAIL: TestAccDirectConnectConnectionAssociation_basic (21.61s)
=== CONT  TestAccDirectConnectConnection_tags
--- PASS: TestAccDirectConnectGateway_basic (56.42s)
=== CONT  TestAccDirectConnectGatewayDataSource_basic
=== CONT  TestAccDirectConnectConnection_tags
    connection_test.go:240: Step 2/4 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
          map[string]string{
        - 	"aws_device":             "",
        + 	"aws_device":             "ECPO1-1387dbdwbg81t",
        - 	"encryption_mode":        "",
        + 	"encryption_mode":        "unknown",
        - 	"has_logical_redundancy": "unknown",
        + 	"has_logical_redundancy": "no",
        - 	"jumbo_frame_capable":    "false",
        + 	"jumbo_frame_capable":    "true",
        - 	"port_encryption_status": "",
        + 	"port_encryption_status": "unknown",
          }
--- FAIL: TestAccDirectConnectConnection_tags (56.05s)
=== CONT  TestAccDirectConnectLag_tags
--- PASS: TestAccDirectConnectGatewayDataSource_basic (46.36s)
=== CONT  TestAccDirectConnectLocationDataSource_basic
--- PASS: TestAccDirectConnectLocationDataSource_basic (30.15s)
=== CONT  TestAccDirectConnectConnection_basic
--- PASS: TestAccDirectConnectConnection_basic (37.95s)
=== CONT  TestAccDirectConnectConnectionDataSource_basic
--- PASS: TestAccDirectConnectLag_tags (97.77s)
=== CONT  TestAccDirectConnectLag_basic
--- PASS: TestAccDirectConnectConnectionDataSource_basic (28.69s)
--- PASS: TestAccDirectConnectLag_basic (53.76s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	248.691s
=== RUN   TestAccDLMLifecyclePolicy_basic
=== PAUSE TestAccDLMLifecyclePolicy_basic
=== RUN   TestAccDLMLifecyclePolicy_tags
=== PAUSE TestAccDLMLifecyclePolicy_tags
=== CONT  TestAccDLMLifecyclePolicy_basic
=== CONT  TestAccDLMLifecyclePolicy_tags
--- PASS: TestAccDLMLifecyclePolicy_basic (49.32s)
--- PASS: TestAccDLMLifecyclePolicy_tags (98.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm	114.388s
=== RUN   TestAccDMSCertificate_basic
=== PAUSE TestAccDMSCertificate_basic
=== RUN   TestAccDMSCertificate_tags
=== PAUSE TestAccDMSCertificate_tags
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_Aurora_basic
=== PAUSE TestAccDMSEndpoint_Aurora_basic
=== RUN   TestAccDMSEndpoint_AuroraPostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_AuroraPostgreSQL_basic
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN   TestAccDMSEndpoint_MongoDB_basic
=== PAUSE TestAccDMSEndpoint_MongoDB_basic
=== RUN   TestAccDMSEndpoint_MariaDB_basic
=== PAUSE TestAccDMSEndpoint_MariaDB_basic
=== RUN   TestAccDMSEndpoint_MySQL_basic
=== PAUSE TestAccDMSEndpoint_MySQL_basic
=== RUN   TestAccDMSEndpoint_Oracle_basic
=== PAUSE TestAccDMSEndpoint_Oracle_basic
=== RUN   TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN   TestAccDMSEndpoint_SQLServer_basic
=== PAUSE TestAccDMSEndpoint_SQLServer_basic
=== RUN   TestAccDMSEndpoint_Sybase_basic
=== PAUSE TestAccDMSEndpoint_Sybase_basic
=== RUN   TestAccDMSEndpoint_db2_basic
=== PAUSE TestAccDMSEndpoint_db2_basic
=== RUN   TestAccDMSEndpoint_Redshift_basic
=== PAUSE TestAccDMSEndpoint_Redshift_basic
=== RUN   TestAccDMSEventSubscription_basic
=== PAUSE TestAccDMSEventSubscription_basic
=== RUN   TestAccDMSEventSubscription_tags
=== PAUSE TestAccDMSEventSubscription_tags
=== RUN   TestAccDMSReplicationInstance_basic
=== PAUSE TestAccDMSReplicationInstance_basic
=== RUN   TestAccDMSReplicationInstance_tags
=== PAUSE TestAccDMSReplicationInstance_tags
=== RUN   TestAccDMSReplicationSubnetGroup_basic
=== PAUSE TestAccDMSReplicationSubnetGroup_basic
=== RUN   TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN   TestAccDMSS3Endpoint_basic
=== PAUSE TestAccDMSS3Endpoint_basic
=== CONT  TestAccDMSCertificate_basic
=== CONT  TestAccDMSEndpoint_SQLServer_basic
--- PASS: TestAccDMSCertificate_basic (40.75s)
=== CONT  TestAccDMSEndpoint_OpenSearch_basic
--- PASS: TestAccDMSEndpoint_SQLServer_basic (46.18s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_basic
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (37.66s)
=== CONT  TestAccDMSEndpoint_Oracle_basic
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (34.52s)
=== CONT  TestAccDMSEndpoint_MySQL_basic
--- PASS: TestAccDMSEndpoint_Oracle_basic (29.26s)
=== CONT  TestAccDMSEndpoint_MariaDB_basic
--- PASS: TestAccDMSEndpoint_MySQL_basic (39.47s)
=== CONT  TestAccDMSEndpoint_MongoDB_basic
--- PASS: TestAccDMSEndpoint_MariaDB_basic (33.85s)
=== CONT  TestAccDMSEndpoint_Aurora_basic
--- PASS: TestAccDMSEndpoint_MongoDB_basic (32.38s)
=== CONT  TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_Aurora_basic (20.38s)
=== CONT  TestAccDMSEndpoint_AuroraPostgreSQL_basic
--- PASS: TestAccDMSEndpoint_AuroraPostgreSQL_basic (20.70s)
=== CONT  TestAccDMSEndpoint_basic
--- PASS: TestAccDMSEndpoint_S3_basic (73.30s)
=== CONT  TestAccDMSCertificate_tags
--- PASS: TestAccDMSEndpoint_basic (47.03s)
=== CONT  TestAccDMSReplicationInstance_basic
--- PASS: TestAccDMSCertificate_tags (39.61s)
=== CONT  TestAccDMSS3Endpoint_basic
--- PASS: TestAccDMSS3Endpoint_basic (30.59s)
=== CONT  TestAccDMSReplicationTask_basic
    replication_task_test.go:33: Step 1/4 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_dms_replication_task.test will be updated in-place
          ~ resource "aws_dms_replication_task" "test" {
                id                        = "tf-acc-test-5724865490022427808"
              ~ replication_task_settings = jsonencode(
                  ~ {
                      ~ Logging                             = {
                          - EnableLogContext = false -> null
                            # (2 unchanged elements hidden)
                        }
                        # (13 unchanged elements hidden)
                    }
                )
                tags                      = {
                    "Name"   = "tf-acc-test-5724865490022427808"
                    "Remove" = "to-remove"
                    "Update" = "to-update"
                }
                # (10 unchanged attributes hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccDMSReplicationInstance_basic (888.49s)
=== CONT  TestAccDMSReplicationSubnetGroup_basic
--- PASS: TestAccDMSReplicationSubnetGroup_basic (39.71s)
=== CONT  TestAccDMSReplicationInstance_tags
--- FAIL: TestAccDMSReplicationTask_basic (951.84s)
=== CONT  TestAccDMSEndpoint_Redshift_basic
--- PASS: TestAccDMSEndpoint_Redshift_basic (233.61s)
=== CONT  TestAccDMSEventSubscription_tags
--- PASS: TestAccDMSReplicationInstance_tags (929.25s)
=== CONT  TestAccDMSEventSubscription_basic
--- PASS: TestAccDMSEventSubscription_tags (1128.28s)
=== CONT  TestAccDMSEndpoint_db2_basic
--- PASS: TestAccDMSEndpoint_db2_basic (32.78s)
=== CONT  TestAccDMSEndpoint_Sybase_basic
--- PASS: TestAccDMSEndpoint_Sybase_basic (22.19s)
--- PASS: TestAccDMSEventSubscription_basic (981.45s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/dms	3081.240s
=== RUN   TestAccDocDBClusterInstance_basic
=== PAUSE TestAccDocDBClusterInstance_basic
=== RUN   TestAccDocDBClusterParameterGroup_basic
=== PAUSE TestAccDocDBClusterParameterGroup_basic
=== RUN   TestAccDocDBClusterParameterGroup_tags
=== PAUSE TestAccDocDBClusterParameterGroup_tags
=== RUN   TestAccDocDBClusterSnapshot_basic
=== PAUSE TestAccDocDBClusterSnapshot_basic
=== RUN   TestAccDocDBCluster_basic
=== PAUSE TestAccDocDBCluster_basic
=== RUN   TestAccDocDBEngineVersionDataSource_basic
=== PAUSE TestAccDocDBEngineVersionDataSource_basic
=== RUN   TestAccDocDBEventSubscription_basic
=== PAUSE TestAccDocDBEventSubscription_basic
=== RUN   TestAccDocDBEventSubscription_tags
=== PAUSE TestAccDocDBEventSubscription_tags
=== RUN   TestAccDocDBGlobalCluster_basic
=== PAUSE TestAccDocDBGlobalCluster_basic
=== RUN   TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
=== PAUSE TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
=== RUN   TestAccDocDBOrderableDBInstanceDataSource_basic
=== PAUSE TestAccDocDBOrderableDBInstanceDataSource_basic
=== RUN   TestAccDocDBSubnetGroup_basic
=== PAUSE TestAccDocDBSubnetGroup_basic
=== CONT  TestAccDocDBClusterInstance_basic
=== CONT  TestAccDocDBEventSubscription_basic
--- PASS: TestAccDocDBEventSubscription_basic (172.52s)
=== CONT  TestAccDocDBClusterSnapshot_basic
--- PASS: TestAccDocDBClusterSnapshot_basic (329.01s)
=== CONT  TestAccDocDBEngineVersionDataSource_basic
--- PASS: TestAccDocDBEngineVersionDataSource_basic (11.22s)
=== CONT  TestAccDocDBCluster_basic
--- PASS: TestAccDocDBCluster_basic (170.58s)
=== CONT  TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic
--- PASS: TestAccDocDBGlobalCluster_SourceDBClusterIdentifier_basic (182.72s)
=== CONT  TestAccDocDBSubnetGroup_basic
--- PASS: TestAccDocDBClusterInstance_basic (884.06s)
=== CONT  TestAccDocDBOrderableDBInstanceDataSource_basic
--- PASS: TestAccDocDBSubnetGroup_basic (23.66s)
=== CONT  TestAccDocDBGlobalCluster_basic
--- PASS: TestAccDocDBOrderableDBInstanceDataSource_basic (11.82s)
=== CONT  TestAccDocDBClusterParameterGroup_tags
--- PASS: TestAccDocDBGlobalCluster_basic (17.39s)
=== CONT  TestAccDocDBEventSubscription_tags
--- PASS: TestAccDocDBClusterParameterGroup_tags (37.21s)
=== CONT  TestAccDocDBClusterParameterGroup_basic
--- PASS: TestAccDocDBClusterParameterGroup_basic (15.37s)
--- PASS: TestAccDocDBEventSubscription_tags (192.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	1114.876s
=== RUN   TestAccDSConditionalForwarder_Condition_basic
=== PAUSE TestAccDSConditionalForwarder_Condition_basic
=== RUN   TestAccDSDirectory_basic
=== PAUSE TestAccDSDirectory_basic
=== RUN   TestAccDSDirectory_tags
=== PAUSE TestAccDSDirectory_tags
=== RUN   TestAccDSLogSubscription_basic
=== PAUSE TestAccDSLogSubscription_basic
=== RUN   TestAccDSRadiusSettings_basic
    radius_settings_test.go:24: Environment variable DIRECTORY_SERVICE_RADIUS_SERVER is not set
--- SKIP: TestAccDSRadiusSettings_basic (0.00s)
=== RUN   TestAccDSRegion_basic
=== PAUSE TestAccDSRegion_basic
=== RUN   TestAccDSRegion_tags
=== PAUSE TestAccDSRegion_tags
=== RUN   TestAccDSSharedDirectoryAccepter_basic
=== PAUSE TestAccDSSharedDirectoryAccepter_basic
=== RUN   TestAccDSSharedDirectory_basic
=== PAUSE TestAccDSSharedDirectory_basic
=== CONT  TestAccDSConditionalForwarder_Condition_basic
=== CONT  TestAccDSRegion_basic
--- PASS: TestAccDSConditionalForwarder_Condition_basic (1298.49s)
=== CONT  TestAccDSSharedDirectory_basic
    acctest.go:772: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDSSharedDirectory_basic (0.00s)
=== CONT  TestAccDSSharedDirectoryAccepter_basic
    acctest.go:772: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccDSSharedDirectoryAccepter_basic (0.00s)
=== CONT  TestAccDSRegion_tags
--- PASS: TestAccDSRegion_basic (7887.86s)
=== CONT  TestAccDSDirectory_tags
--- PASS: TestAccDSDirectory_tags (818.16s)
=== CONT  TestAccDSLogSubscription_basic
--- PASS: TestAccDSRegion_tags (7881.96s)
=== CONT  TestAccDSDirectory_basic
--- PASS: TestAccDSDirectory_basic (589.23s)
--- PASS: TestAccDSLogSubscription_basic (1297.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	10014.695s
=== RUN   TestAccDynamoDBContributorInsights_basic
=== PAUSE TestAccDynamoDBContributorInsights_basic
=== RUN   TestAccDynamoDBGlobalTable_basic
=== PAUSE TestAccDynamoDBGlobalTable_basic
=== RUN   TestAccDynamoDBKinesisStreamingDestination_basic
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_basic
=== RUN   TestAccDynamoDBTableDataSource_basic
=== PAUSE TestAccDynamoDBTableDataSource_basic
=== RUN   TestAccDynamoDBTableItemDataSource_basic
=== PAUSE TestAccDynamoDBTableItemDataSource_basic
=== RUN   TestAccDynamoDBTableItem_basic
=== PAUSE TestAccDynamoDBTableItem_basic
=== RUN   TestAccDynamoDBTableReplica_basic
=== PAUSE TestAccDynamoDBTableReplica_basic
=== RUN   TestAccDynamoDBTableReplica_tags
=== PAUSE TestAccDynamoDBTableReplica_tags
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== RUN   TestAccDynamoDBTable_tags
=== PAUSE TestAccDynamoDBTable_tags
=== RUN   TestAccDynamoDBTag_basic
=== PAUSE TestAccDynamoDBTag_basic
=== CONT  TestAccDynamoDBContributorInsights_basic
=== CONT  TestAccDynamoDBTableReplica_basic
--- PASS: TestAccDynamoDBContributorInsights_basic (102.47s)
=== CONT  TestAccDynamoDBTableDataSource_basic
--- PASS: TestAccDynamoDBTableDataSource_basic (30.89s)
=== CONT  TestAccDynamoDBTableItem_basic
--- PASS: TestAccDynamoDBTableItem_basic (25.00s)
=== CONT  TestAccDynamoDBTableItemDataSource_basic
--- PASS: TestAccDynamoDBTableReplica_basic (171.22s)
=== CONT  TestAccDynamoDBTable_tags
--- PASS: TestAccDynamoDBTableItemDataSource_basic (27.54s)
=== CONT  TestAccDynamoDBTag_basic
--- PASS: TestAccDynamoDBTag_basic (26.08s)
=== CONT  TestAccDynamoDBKinesisStreamingDestination_basic
--- PASS: TestAccDynamoDBTable_tags (46.17s)
=== CONT  TestAccDynamoDBGlobalTable_basic
--- PASS: TestAccDynamoDBGlobalTable_basic (50.41s)
=== CONT  TestAccDynamoDBTable_basic
--- PASS: TestAccDynamoDBKinesisStreamingDestination_basic (73.64s)
=== CONT  TestAccDynamoDBTableReplica_tags
--- PASS: TestAccDynamoDBTable_basic (33.27s)
--- PASS: TestAccDynamoDBTableReplica_tags (196.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	495.679s
FAIL
make: *** [testacc] Error 1

@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - dataexchange.
eecf1df
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - datapipeline.
3c58ffd
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - datasync.
7cbecfb
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - dax.
b03048c
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - deploy.
a4f657f
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - detective.
1afd0fd
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - devicefarm.
7d96653
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - directconnect.
56e6d0e
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - dlm.
3011966
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - dms.
491cd3a
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - docdb.
1a8ae1a
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - ds.
1f4477a
@ewbankkit
Remove tagging boilerplate for Plugin SDK resources - dynamodb.
d60c2c4
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/detective Issues and PRs that pertain to the detective service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/ds Issues and PRs that pertain to the ds service. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Apr 6, 2023
@ewbankkit ewbankkit removed the service/dynamodb Issues and PRs that pertain to the dynamodb service. label Apr 6, 2023
@github-actions github-actions bot added the generators Relates to code generators. label Apr 6, 2023
@ewbankkit ewbankkit mentioned this pull request Apr 6, 2023
Merged
@ewbankkit ewbankkit merged commit 69a4b56 into main Apr 6, 2023
34 checks passed
@ewbankkit ewbankkit deleted the td-transparent-tagging-phase3c-d branch April 6, 2023 17:20
@github-actions github-actions bot added this to the v4.62.0 milestone Apr 6, 2023
This was referenced Apr 6, 2023
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced Apr 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented May 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/detective Issues and PRs that pertain to the detective service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/ds Issues and PRs that pertain to the ds service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.62.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ewbankkit