Skip to content

Conversation

@drewmullen
Copy link
Collaborator

@drewmullen drewmullen commented Mar 13, 2025

Description

Provides a resource for managing IPAM Default Scopes. These cannot be deleted on their own and are managed by parent IPAM. To delete them you must delete the parent IPAM.

I leaned heavily on the aws_default_vpc resource for design

Relations

Closes #37097

References

Output from Acceptance Testing

$ PKG=ec2 TF_ACC=1 make test TESTARGS='--run=TestAccIPAMDefaultScope_'
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running unit tests...
go1.23.7 test -count 1 ./internal/service/ec2/... --run=TestAccIPAMDefaultScope_ -timeout=15m -vet=off
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	37.956s
...

@drewmullen drewmullen requested a review from a team as a code owner March 13, 2025 12:57
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/ipam Issues and PRs that pertain to the ipam service. size/XL Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Mar 13, 2025
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 13, 2025
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. service/ipam Issues and PRs that pertain to the ipam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Ability to manage IPAM default scope instances

2 participants