Skip to content

Conversation

@nam054
Copy link
Contributor

@nam054 nam054 commented Mar 19, 2025

Description

Prevents application from failing when hitting the "InvalidAction" error for specific regions where the DescribeAddressesAttribute is not supported such as govCloud or secret regions.

Relations

Closes #41177

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Mar 19, 2025
@nam054 nam054 marked this pull request as ready for review March 21, 2025 00:46
@nam054 nam054 requested a review from a team as a code owner March 21, 2025 00:46
@nam054 nam054 changed the title Add check in case for secret regions/govcloud f/Add check to ignore case for secret regions/govcloud Mar 21, 2025
Copy link
Member

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccEC2EIP_basic\|TestAccEC2EIP_disappears' PKG=ec2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2EIP_basic\|TestAccEC2EIP_disappears -timeout 360m -vet=off
2025/03/24 10:24:15 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2EIP_basic
=== PAUSE TestAccEC2EIP_basic
=== RUN   TestAccEC2EIP_disappears
=== PAUSE TestAccEC2EIP_disappears
=== CONT  TestAccEC2EIP_basic
=== CONT  TestAccEC2EIP_disappears
--- PASS: TestAccEC2EIP_disappears (14.78s)
--- PASS: TestAccEC2EIP_basic (17.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	24.124s

@nam054 nam054 merged commit b8c752e into main Mar 24, 2025
38 checks passed
@nam054 nam054 deleted the b-eip-region branch March 24, 2025 16:25
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.93.0 milestone Mar 24, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Mar 24, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 27, 2025
@github-actions
Copy link
Contributor

This functionality has been released in v5.93.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: EIP Addresses Attribute not supported in all AWS regions

2 participants