Skip to content

Conversation

@t0yv0
Copy link
Contributor

@t0yv0 t0yv0 commented Mar 28, 2025

Description

This change prevents retrying LimitExceededException, in particular one returned by CreateResolverEndpoint when an aws_route53_resolver_endpoint resource is provisioned with too many IPs. Instead of appearing to hang indefinitely, such programs now fail fast with an error.

Relations

Closes #40480

Output from Acceptance Testing

[130] anton@anton-mbp-m3> TF_ACC=1 go test -test.v -test.run TestAccRoute53ResolverEndpoint_LimitExceededException_failsFast
2025/03/28 10:56:23 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53ResolverEndpoint_LimitExceededException_failsFast
=== PAUSE TestAccRoute53ResolverEndpoint_LimitExceededException_failsFast
=== CONT  TestAccRoute53ResolverEndpoint_LimitExceededException_failsFast
--- PASS: TestAccRoute53ResolverEndpoint_LimitExceededException_failsFast (41.42s)
PASS

This change prevents retrying LimitExceededException, in particular one returned by CreateResolverEndpoint when an
aws_route53_resolver_endpoint resource is provisioned with too many IPs. Instead of appearing to hang indefinitely,
such programs now fail fast with an error.

Fixes hashicorp#40480
@t0yv0 t0yv0 requested a review from a team as a code owner March 28, 2025 15:07
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/M Managed by automation to categorize the size of a PR. labels Mar 28, 2025
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: aws_route53_resolver_endpoint: CreateResolverEndpoint retries indefinitely despite LimitExceededException

2 participants