Skip to content

Conversation

@jar-b
Copy link
Member

@jar-b jar-b commented Mar 31, 2025

Description

This series of helper functions are being renamed to ComputedOnlyFrom[Schema|Resource|SchemaResource] to better describe their usage given it is mixed between both data sources and managed resources.

Relations

Closes #42012

Output from Unit Testing

% go test -count=1 ./internal/sdkv2/...
ok      github.com/hashicorp/terraform-provider-aws/internal/sdkv2      0.323s
ok      github.com/hashicorp/terraform-provider-aws/internal/sdkv2/types        0.639s
ok      github.com/hashicorp/terraform-provider-aws/internal/sdkv2/types/nullable       0.453s

This series of helper functions are being renamed to `ComputedOnlyFrom[Schema|Resource|SchemaResource]` to better describe their usage given it is mixed between both data sources and managed resources.
@jar-b jar-b added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Mar 31, 2025
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/connect Issues and PRs that pertain to the connect service. service/appmesh Issues and PRs that pertain to the appmesh service. service/quicksight Issues and PRs that pertain to the quicksight service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/ce Issues and PRs that pertain to the ce service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/M Managed by automation to categorize the size of a PR. labels Mar 31, 2025
@jar-b jar-b marked this pull request as ready for review March 31, 2025 17:55
@jar-b jar-b requested a review from a team as a code owner March 31, 2025 17:56
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 4793d75 into main Apr 1, 2025
41 checks passed
@jar-b jar-b deleted the td-resource-to-computed branch April 1, 2025 14:22
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.94.0 milestone Apr 1, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Apr 1, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

This functionality has been released in v5.94.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

service/appmesh Issues and PRs that pertain to the appmesh service. service/ce Issues and PRs that pertain to the ce service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/connect Issues and PRs that pertain to the connect service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/quicksight Issues and PRs that pertain to the quicksight service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TechDebt]: Rename sdkv2.DataSourcePropertyFromResourceProperty

2 participants