[add test] aws_ecr_replication_configuration for cross-account and cross-region destination configuration

[tabito-hara]

Description

• Add a test for aws_ecr_replication_configuration to verify that combined cross-account and cross-region destination configurations work correctly.
• This test was motivated by ECR replication : cross both account and region rule configuration results in only a cross account rule #42155. While investigating the reported issue, I found that there was no existing test case covering both cross-account and cross-region replication together.
• Passing the newly added test indicates that combined a cross-account and cross-region destination configuration works as expected with the current implementation.

Relations

Closes #42155

Output from Acceptance Testing

$ AWS_ALTERNATE_PROFILE=admin-alt AWS_PROFILE=admin make testacc TESTS=TestAccECRReplicationConfiguration_ PKG=ecr      
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.7 test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRReplicationConfiguration_'  -timeout 360m -vet=off
2025/04/08 09:23:42 Initializing Terraform AWS Provider...
=== RUN   TestAccECRReplicationConfiguration_serial
=== PAUSE TestAccECRReplicationConfiguration_serial
=== CONT  TestAccECRReplicationConfiguration_serial
=== RUN   TestAccECRReplicationConfiguration_serial/basic
=== RUN   TestAccECRReplicationConfiguration_serial/disappears
=== RUN   TestAccECRReplicationConfiguration_serial/repositoryFilter
--- PASS: TestAccECRReplicationConfiguration_serial (140.72s)
    --- PASS: TestAccECRReplicationConfiguration_serial/basic (78.24s)
    --- PASS: TestAccECRReplicationConfiguration_serial/disappears (22.10s)
    --- PASS: TestAccECRReplicationConfiguration_serial/repositoryFilter (40.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        145.667s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECRReplicationConfiguration_serial/basic' PKG=ecr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/ecr/... -v -count 1 -parallel 20  -run=TestAccECRReplicationConfiguration_serial/basic -timeout 360m -vet=off
2025/04/30 09:02:07 Initializing Terraform AWS Provider...
=== RUN   TestAccECRReplicationConfiguration_serial
=== PAUSE TestAccECRReplicationConfiguration_serial
=== CONT  TestAccECRReplicationConfiguration_serial
=== RUN   TestAccECRReplicationConfiguration_serial/basic
--- PASS: TestAccECRReplicationConfiguration_serial (57.92s)
    --- PASS: TestAccECRReplicationConfiguration_serial/basic (57.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	62.718s

[ewbankkit]

@tabito-hara Thanks for the contribution 🎉 👏.

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.97.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.