Skip to content

docs: add ExpectResourceAction plan check in _disappears test design decision #42206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jar-b merged 1 commit into from
Apr 14, 2025
Merged

docs: add ExpectResourceAction plan check in _disappears test design decision #42206

jar-b merged 1 commit into from
Apr 14, 2025

Conversation

@jar-b
Copy link
Member

@jar-b jar-b commented Apr 11, 2025

Description

This design decision documents the suggested approach for implementing _disappears tests going forward, which should include an ExpectResourceAction plan check to verify the specific resource being deleted out of band is planned for creation after the post-apply refresh.

@jar-b
docs: add ExpectResourceAction plan check in _disappears test des…
d123de3 
…ign decision

This design decision documents the suggested approach for implementing
`_disappears` tests going forward, which should include an
`ExpectResourceAction` plan check to verify the specific resource being
deleted out of band is planned for creation after the post-apply
refresh.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/M Managed by automation to categorize the size of a PR. labels Apr 11, 2025
@jar-b jar-b marked this pull request as ready for review April 11, 2025 20:30
@jar-b jar-b requested a review from a team as a code owner April 11, 2025 20:30
@jar-b jar-b mentioned this pull request Apr 11, 2025
Merged
ewbankkit
ewbankkit approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit 2b7b8b9 into main Apr 14, 2025
13 checks passed
@jar-b jar-b deleted the d-disappears-test-design-decision branch April 14, 2025 13:14
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.95.0 milestone Apr 14, 2025
@jar-b jar-b mentioned this pull request Apr 16, 2025
Open
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

This functionality has been released in v5.95.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR.

Projects

None yet

Milestone

v5.95.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jar-b @ewbankkit