r/aws_elasticache_serverless_cache: allow in-place redis to valkey engine updates

[jar-b]

Description

Previously changing the engine from redis to valkey would have forced a replacement of the resource. Migrations from redis to valkey are now supported in-place as intended in the original implementation of valkey support.

Relations

Relates #39745
Closes #42204

References

• https://discuss.hashicorp.com/t/in-place-update-for-aws-elasticache-serverless-cache-from-redis-to-valkey/73319
• https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_ModifyServerlessCache.html

Output from Acceptance Testing

% make testacc PKG=elasticache TESTS=TestAccElastiCacheServerlessCache_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheServerlessCache_'  -timeout 360m -vet=off
2025/04/11 16:04:25 Initializing Terraform AWS Provider...

--- PASS: TestAccElastiCacheServerlessCache_full (399.87s)
--- PASS: TestAccElastiCacheServerlessCache_basicValkey (556.51s)
--- PASS: TestAccElastiCacheServerlessCache_basicRedis (567.35s)
--- PASS: TestAccElastiCacheServerlessCache_disappears (584.55s)
--- PASS: TestAccElastiCacheServerlessCache_description (584.98s)
--- PASS: TestAccElastiCacheServerlessCache_fullValkey (586.27s)
--- PASS: TestAccElastiCacheServerlessCache_tags (632.07s)
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (638.54s)
--- PASS: TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup (797.42s)
--- PASS: TestAccElastiCacheServerlessCache_cacheUsageLimits (874.83s)
--- PASS: TestAccElastiCacheServerlessCache_engine (1456.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        1463.285s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccElastiCacheServerlessCache_' PKG=elasticache ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/elasticache/... -v -count 1 -parallel 3  -run=TestAccElastiCacheServerlessCache_ -timeout 360m -vet=off
2025/04/14 08:27:13 Initializing Terraform AWS Provider...
=== RUN   TestAccElastiCacheServerlessCache_basicRedis
=== PAUSE TestAccElastiCacheServerlessCache_basicRedis
=== RUN   TestAccElastiCacheServerlessCache_basicValkey
=== PAUSE TestAccElastiCacheServerlessCache_basicValkey
=== RUN   TestAccElastiCacheServerlessCache_full
=== PAUSE TestAccElastiCacheServerlessCache_full
=== RUN   TestAccElastiCacheServerlessCache_fullRedis
=== PAUSE TestAccElastiCacheServerlessCache_fullRedis
=== RUN   TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup
=== PAUSE TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup
=== RUN   TestAccElastiCacheServerlessCache_fullValkey
=== PAUSE TestAccElastiCacheServerlessCache_fullValkey
=== RUN   TestAccElastiCacheServerlessCache_description
=== PAUSE TestAccElastiCacheServerlessCache_description
=== RUN   TestAccElastiCacheServerlessCache_cacheUsageLimits
=== PAUSE TestAccElastiCacheServerlessCache_cacheUsageLimits
=== RUN   TestAccElastiCacheServerlessCache_engine
=== PAUSE TestAccElastiCacheServerlessCache_engine
=== RUN   TestAccElastiCacheServerlessCache_disappears
=== PAUSE TestAccElastiCacheServerlessCache_disappears
=== RUN   TestAccElastiCacheServerlessCache_tags
=== PAUSE TestAccElastiCacheServerlessCache_tags
=== CONT  TestAccElastiCacheServerlessCache_basicRedis
=== CONT  TestAccElastiCacheServerlessCache_description
=== CONT  TestAccElastiCacheServerlessCache_fullRedis
--- PASS: TestAccElastiCacheServerlessCache_basicRedis (367.23s)
=== CONT  TestAccElastiCacheServerlessCache_fullValkey
--- PASS: TestAccElastiCacheServerlessCache_description (447.71s)
=== CONT  TestAccElastiCacheServerlessCache_full
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (470.68s)
=== CONT  TestAccElastiCacheServerlessCache_disappears
--- PASS: TestAccElastiCacheServerlessCache_fullValkey (231.93s)
=== CONT  TestAccElastiCacheServerlessCache_tags
--- PASS: TestAccElastiCacheServerlessCache_full (157.44s)
=== CONT  TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup
--- PASS: TestAccElastiCacheServerlessCache_disappears (135.05s)
=== CONT  TestAccElastiCacheServerlessCache_engine
--- PASS: TestAccElastiCacheServerlessCache_tags (108.66s)
=== CONT  TestAccElastiCacheServerlessCache_basicValkey
--- PASS: TestAccElastiCacheServerlessCache_redisUpdateWithUserGroup (410.09s)
=== CONT  TestAccElastiCacheServerlessCache_cacheUsageLimits
--- PASS: TestAccElastiCacheServerlessCache_basicValkey (334.89s)
--- PASS: TestAccElastiCacheServerlessCache_engine (682.88s)
--- PASS: TestAccElastiCacheServerlessCache_cacheUsageLimits (630.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	1651.771s

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.95.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.