Update AppRole documentation with modern parameters#387
Merged
chrisarcand merged 1 commit intomasterfrom Feb 4, 2026
Merged
Conversation
beekus
previously approved these changes
Feb 4, 2026
beekus
previously approved these changes
Feb 4, 2026
Updated the set_role method documentation to include current Vault AppRole parameters: - secret_id_bound_cidrs (replaces deprecated bound_cidr_list) - token_bound_cidrs (for token IP restrictions) - token_policies (replaces deprecated policies) - local_secret_ids - token_explicit_max_ttl - token_no_default_policy - token_num_uses - token_period - token_type These parameters were already supported by vault-ruby (the method passes all options directly to Vault), but were not documented. Added reference to official Vault API documentation for the complete list of available parameters. Fixes #220
6f7d269 to
3aab644
Compare
Member
Author
|
When you fall, try try again or something like that. |
beekus
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the set_role method documentation to include current Vault AppRole parameters:
These parameters were already supported by vault-ruby (the method passes all options directly to Vault), but were not documented and caused some confusion. Added reference to official Vault API documentation for the complete list of available parameters.
Fixes #220