Update Docs For Bound Audience Explanation #30519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
jaireddjawed
force-pushed
the
VAULT-33101-update-bound-audience-docs
branch
from
c08640f to
3c4c325
Compare
fairclothjm
reviewed
May 12, 2025
Contributor
fairclothjm
left a comment
fairclothjm
left a comment
There was a problem hiding this comment.
LGTM, if we remove the changelog entry.
FYI: you can skip all the Vault CI checks if you prefix your git branch with docs/.
Contributor
Author
Sounds good. I'll keep that in mind for the next doc update. Added the "no changelog" entry for this PR for now. |
yhyakuna
previously approved these changes
May 13, 2025
schavis
requested changes
May 13, 2025
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
schavis
approved these changes
May 13, 2025
6 tasks
jaireddjawed
added a commit
that referenced
this pull request
May 13, 2025
* update docs for more clarity around bound audiences * more updates * update changelog * Delete changelog/30519.txt * Update website/content/docs/auth/jwt/index.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Update website/content/api-docs/auth/jwt.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
jaireddjawed
added a commit
that referenced
this pull request
May 13, 2025
* update docs for more clarity around bound audiences * more updates * update changelog * Delete changelog/30519.txt * Update website/content/docs/auth/jwt/index.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Update website/content/api-docs/auth/jwt.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
This was referenced May 13, 2025
jaireddjawed
added a commit
that referenced
this pull request
May 13, 2025
* update docs for more clarity around bound audiences * more updates * update changelog * Delete changelog/30519.txt * Update website/content/docs/auth/jwt/index.mdx * Update website/content/api-docs/auth/jwt.mdx --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
jaireddjawed
added a commit
that referenced
this pull request
Jul 17, 2025
* update docs for more clarity around bound audiences * more updates * update changelog * Delete changelog/30519.txt * Update website/content/docs/auth/jwt/index.mdx * Update website/content/api-docs/auth/jwt.mdx --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
* update docs for more clarity around bound audiences * more updates * update changelog * Delete changelog/30519.txt * Update website/content/docs/auth/jwt/index.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> * Update website/content/api-docs/auth/jwt.mdx Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com> --------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our JWT documentation to clearly specify that the bound audience must exactly match the bound claim stored in Vault for successful authentication when using the JWT login method.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.