Skip to content

Conversation

@Monkeychip
Copy link
Contributor

Description

Working to replace button selectors with one of the following GENERAL selectors:

  backButton: '[data-test-back-button]',
  cancelButton: '[data-test-cancel]',
  saveButton: '[data-test-save]',
  testButton: (label: string) => `[data-test-button="${label}"]`, // generic button that uses a dynamic input to individualize itself.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@Monkeychip Monkeychip added this to the 1.20.0-rc milestone May 7, 2025
@Monkeychip Monkeychip requested a review from a team as a code owner May 7, 2025 16:11
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 7, 2025
@Monkeychip Monkeychip marked this pull request as draft May 7, 2025 16:13
@github-actions
Copy link

github-actions bot commented May 7, 2025

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented May 7, 2025

CI Results: failed ❌

@Monkeychip Monkeychip closed this Jun 9, 2025
@Monkeychip Monkeychip deleted the ui/button-selectors-1 branch June 9, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant