Docs: Removing estimates for current month from counters api #30572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
divyaac
reviewed
May 12, 2025
| | 1.16 | All | Added synced secrets as a new category in client counting | ||
| | 1.17 | All | Separated PKI ACME certificates as their own category in client counting | ||
| | 1.20 | All | Get client count endpoint response excludes the current month and any future date | ||
| | 1.20+ent | All | Actual values are returned for `new_clients` counts for the current month and they are no longer an estimate |
Contributor
There was a problem hiding this comment.
@schavis is this formatting ok? And is it alright that we call it 1.20 and 1.20+ent?
Contributor
There was a problem hiding this comment.
Technically "ent" isn't a version. If we need to differentiate between edition and version, we should probably add a third column for version with "Community", "Enterprise", or "All".
Contributor
Author
There was a problem hiding this comment.
Added edition column
aslamovamir
reviewed
May 12, 2025
aslamovamir
reviewed
May 12, 2025
aslamovamir
reviewed
May 12, 2025
aslamovamir
reviewed
May 12, 2025
aslamovamir
reviewed
May 12, 2025
aslamovamir
reviewed
May 12, 2025
aslamovamir
reviewed
May 12, 2025
Contributor
aslamovamir
left a comment
aslamovamir
left a comment
There was a problem hiding this comment.
Left some nits and clarifying questions, otherwise looks great!
Co-authored-by: Amir Aslamov <amir.aslamov@hashicorp.com>
Co-authored-by: Amir Aslamov <amir.aslamov@hashicorp.com>
Co-authored-by: Amir Aslamov <amir.aslamov@hashicorp.com>
aslamovamir
approved these changes
May 14, 2025
Contributor
aslamovamir
left a comment
aslamovamir
left a comment
There was a problem hiding this comment.
Looks good! Thank you for addressing the questions!
yhyakuna
approved these changes
May 14, 2025
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
…rp#30572) * removing estimates docs * Update website/content/docs/concepts/client-count/counting.mdx Co-authored-by: Amir Aslamov <amir.aslamov@hashicorp.com> * Update website/content/partials/counters-api-wait-warning.mdx Co-authored-by: Amir Aslamov <amir.aslamov@hashicorp.com> * Update website/content/api-docs/system/internal-counters.mdx Co-authored-by: Amir Aslamov <amir.aslamov@hashicorp.com> * add edition column --------- Co-authored-by: Amir Aslamov <amir.aslamov@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Jira: https://hashicorp.atlassian.net/browse/VAULT-34684
Updates internal/counters api, client count calculation, client count FAQ
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.