This repository was archived by the owner on Jan 8, 2024. It is now read-only.
core/install: Add configurable CSI mount flags to install#4387
Merged
core/install: Add configurable CSI mount flags to install#4387
Conversation
izaaklauer
approved these changes
Jan 11, 2023
paladin-devops
approved these changes
Jan 12, 2023
paladin-devops
suggested changes
Jan 12, 2023
Contributor
paladin-devops
left a comment
paladin-devops
left a comment
There was a problem hiding this comment.
The default was named twice in the docs, which is because the sentence "The default is..." is now auto-generated based on the variable's default value! 😃
briancain
approved these changes
Jan 12, 2023
Contributor
briancain
left a comment
briancain
left a comment
There was a problem hiding this comment.
Approving, but +1 to @paladin-devops suggestions before merge! Our CLI package will auto-generate the default value into the description
demophoon
force-pushed
the
f/main/nomad-csi-mount-flags
branch
from
0855023 to
9606cd5
Compare
paladin-devops
approved these changes
Feb 1, 2023
Contributor
Author
|
Gonna rebase before merge since its been a while |
Before this commit the default mount settings for volumes created and attached were hardcoded to `noatime`. Some CSI driver setups, such as in NFS can produce incompatible setups in which the installation always fails. This commit adds in the `-nomad-csi-mount-flags` flag which can be used to override the default mount flags.
demophoon
force-pushed
the
f/main/nomad-csi-mount-flags
branch
from
9606cd5 to
5f6eaa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit the default mount settings for volumes created and attached were hardcoded to
noatime. Some CSI driver setups, such as in NFS can produce incompatible setups in which the installation always fails.This commit adds in the
-nomad-csi-mount-flagsflag which can be used to override the default mount flags.