feat: add PRODUCT_CONFIG #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vercel Previews Deployed
|
EnMod
approved these changes
Dec 11, 2024
Contributor
EnMod
left a comment
EnMod
left a comment
There was a problem hiding this comment.
Deferring to @RubenSandwich for a final sign-off, but LGTM!
RubenSandwich
requested changes
Dec 11, 2024
Contributor
RubenSandwich
left a comment
RubenSandwich
left a comment
There was a problem hiding this comment.
Overall looks good. Let's just add a key to repoConfig "unversionedDoc: boolean" or "versionedDoc: boolean" you choice, as I believe that will help clean up certain parts of our code.
If you feel that that work would be better in a PR, as this PR already contains a lot of changes, then I will approve this and we can make a new ticket for that work.
im2nguyen
pushed a commit
that referenced
this pull request
Mar 6, 2025
* WIP * feat: add PRODUCT_CONFIG * remove comment and add types to PRODUCT_CONFIG * remove console log * fix attribute name * add attribute comment * remove unnecessary comment * add versionedDocs to product config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎟️ Asana task
This PR creates a PRODUCT_CONFIG object that can be used across the repo to access any product config information. This mainly gets used in the migration scripts but also is used across a few other scripts in the repo. I also added the
productSlugattribute to contain the product name that the repo belongs to. For example, terraform-docs-agents content shows up in the terraform section of dev-portal so theproductSlugfor that section is 'terraform'.Testing
.content-source-reposdirectory is created and contains docs repos