-
Notifications
You must be signed in to change notification settings - Fork 112
Fix version plugins #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,23 +1,6 @@ | |||
| import fs from 'node:fs/promises' | |||
|
|
|||
| const terraformBasePaths = [ | |||
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using repo-config rather than hard-coded values
RubenSandwich
approved these changes
Dec 13, 2024
Contributor
RubenSandwich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. 👍🏻
9243930 to
283e176
Compare
Contributor
Vercel Previews Deployed
|
im2nguyen
pushed a commit
that referenced
this pull request
Mar 6, 2025
* Fixed versioning plugins; wip test * Remove unused semver var * Change terraform-docs-common to empty array in fixture; remove version from tfc test * Fix nav data versions bugs * Fix merge conflict * Fix build error by importing product config instead of repo config --------- Co-authored-by: Ruben Nic <RubenSandwich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task