Skip to content

Conversation

@heatlikeheatwave
Copy link
Contributor

  • Fixed bugs with version transforms

Asana task

@heatlikeheatwave heatlikeheatwave self-assigned this Dec 12, 2024
@heatlikeheatwave heatlikeheatwave requested a review from a team as a code owner December 12, 2024 21:41
@heatlikeheatwave heatlikeheatwave requested review from RubenSandwich and mikegolus and removed request for a team and mikegolus December 12, 2024 21:41
@@ -1,23 +1,6 @@
import fs from 'node:fs/promises'

const terraformBasePaths = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using repo-config rather than hard-coded values

@heatlikeheatwave heatlikeheatwave marked this pull request as draft December 12, 2024 22:38
@heatlikeheatwave heatlikeheatwave marked this pull request as ready for review December 12, 2024 23:20
Copy link
Contributor

@RubenSandwich RubenSandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍🏻

@heatlikeheatwave heatlikeheatwave force-pushed the heat/chore/fix-version-plugins branch from 9243930 to 283e176 Compare December 13, 2024 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Dec 13, 2024, 9:00 PM
Unified Docs API ✅ Ready (Inspect) Visit Preview Dec 13, 2024, 8:48 PM

@RubenSandwich RubenSandwich merged commit bc07eed into main Dec 13, 2024
3 checks passed
@heatlikeheatwave heatlikeheatwave deleted the heat/chore/fix-version-plugins branch January 28, 2025 20:50
im2nguyen pushed a commit that referenced this pull request Mar 6, 2025
* Fixed versioning plugins; wip test

* Remove unused semver var

* Change terraform-docs-common to empty array in fixture; remove version from tfc test

* Fix nav data versions bugs

* Fix merge conflict

* Fix build error by importing product config instead of repo config

---------

Co-authored-by: Ruben Nic <RubenSandwich@users.noreply.github.com>
hashibot-web added a commit that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants