Docker fixes #95
Merged
Docker fixes #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of the `docker-compose` command is deprecated and instead it is generally recommended that people use `docker compose` (note the lack of hyphen) going forward. To that end, this commit replaces the invoation of `docker-compose` with `docker compose`. More info: https://stackoverflow.com/a/66526176
As a convenience docker desktop provides a DNS alias (host.docker.internal) that can be used to connect to services on the host machine from within containers. However, this would fail to work for anyone not docker desktop. Therefore, using service names here is probably a better option.
rmainwork
requested review from
RubenSandwich and
pbortnick
and removed request for
a team
Contributor
Vercel Previews Deployed
|
im2nguyen
pushed a commit
that referenced
this pull request
Mar 6, 2025
* Switch to docker compose plugin Usage of the `docker-compose` command is deprecated and instead it is generally recommended that people use `docker compose` (note the lack of hyphen) going forward. To that end, this commit replaces the invoation of `docker-compose` with `docker compose`. More info: https://stackoverflow.com/a/66526176 * Replace docker host DNS alias with service name As a convenience docker desktop provides a DNS alias (host.docker.internal) that can be used to connect to services on the host machine from within containers. However, this would fail to work for anyone not docker desktop. Therefore, using service names here is probably a better option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues with the docker setup
docker-compose.ymlto point to thedev-portalservice instead of the docker desktop DNS redirectmakefileto usedocker composeinstead of the (deprecated)docker-composepythonapp
Also considered adding some changes in to remove the usage of docker profiles and container names, but thought we should probably talk about that and didn't want to derail this PR with that.