Skip to content

FE-674: Sync planning for V3 cascade through reconciliation_need#110

Merged
kostandinang merged 3 commits into
mainfrom
ka/fe-674-sync-cascade-planning
May 8, 2026
Merged

FE-674: Sync planning for V3 cascade through reconciliation_need#110
kostandinang merged 3 commits into
mainfrom
ka/fe-674-sync-cascade-planning

Conversation

@kostandinang
Copy link
Copy Markdown
Contributor

@kostandinang kostandinang commented May 8, 2026

Stack Context

Stacks on top of FE-704 (Sync planning after multi-chat substrate + V2 plumbing). This PR is the planning groundwork for FE-674 — V3 hard-edit cascade. Implementation slices follow on top of this branch.

Why?

The existing SIDE_CHAT.md V3 design pre-dates the multi-chat substrate (FE-697). It described "Hard edit absorbs REVISIT_MODULE" against an ad-hoc REVISIT walk and treated the patch ledger as a future-work assumption (A71). Since FE-697 landed, the substrate ships a durable reconciliation_need queue that V3 should read from instead. Without this sync, V3 implementation cards would encode stale assumptions.

PLAN.md also still listed V3 as a Next item with "batch-resolution secondary-thread mode" framing inherited from the archived REVISIT_MODULE. This PR promotes V3.0 (the narrow, deterministic cascade slice) onto the Active frontier and adds V3.1 (agent-grouped resolution) as horizon work.

What changed

docs/design/SIDE_CHAT.md

  • §5.3 rewritten: hard-edit cascade reads from the reconciliation_need queue (Path 1 deterministic enumeration over knowledge_edge rows incident on the changed item). Auto-confirm / auto-edit / substantive grouping reframed as V3.1 agent work.
  • §8 A71 demoted from "future-work assumption" to "partly satisfied" — chat substrate landed; patch ledger is still horizon.
  • §9 phasing split V3 into V3.0 (deterministic cascade, deferred-banner removed) and V3.1 (agent-grouped resolution).
  • New §13 Substrate Alignment table — maps user-surface versions (V1–V4) onto MULTI_CHAT.md substrate phases.

memory/SPEC.md

  • Acceptance Criterion Remove claude agent #7 — "secondary thread" replaced with "reconciliation_need queue + patch list".
  • New A84 — Path 1 deterministic enumeration suffices for V3.0; agent grouping is V3.1.
  • New D139 — hard-impact edit cascade routes through the reconciliation_need queue; deferred: true apply contract is removed at V3.0 ship.
  • New I112 — hard-impact apply opens at least one reconciliation_need per existing typed dependency edge incident on the changed item; never returns deferred: true; resolutions are idempotent.

memory/PLAN.md

  • Active is now V3.0 (was Continuous workspace). The frontier framing is updated to call out the deferred-banner gap as the unlock.
  • Next is now Continuous workspace (bumped behind V3.0). The standalone V2 UI trigger Next item is folded into V3.0's scope-card queue rather than tracked as a separate frontier item — they're commit-sized steps inside one frontier per the anti-fragmentation rule.
  • Horizon adds Side-chat V3.1 (agent-grouped reconciliation resolution).
  • Recently Completed adds the FE-674 planning sync entry; the older 2026-05-04 graph view entry rolls off (kept in docs/archive/PLAN_HISTORY.md).
  • Dependencies track A updated: V3.0 active, V3.1 horizon, V2 UI trigger removed.

Verification

  • npm run check passes (fmt + lint + typecheck — doc-only changes, no src/ touched).
  • No code changes; the V2 deferred-banner stays live until V3.0 implementation lands.

Out of scope

  • V3.0 implementation (server openReconciliationNeedsForItemChange(), edit-applier rewrite to drop deferred: true, patch-list-overlay Pending-review section, V2 Edit-button un-stub).
  • V3.1 reconciliation agent.

Copy link
Copy Markdown
Contributor Author

kostandinang commented May 8, 2026

@kostandinang kostandinang marked this pull request as ready for review May 8, 2026 08:02
@cursor
Copy link
Copy Markdown

cursor Bot commented May 8, 2026

PR Summary

Low Risk
Doc-only updates that reshape the planned V3 hard-edit cascade to use the existing reconciliation_need queue; no runtime behavior changes in this PR.

Overview
Updates the side-chat V3 design to route hard-impact edits through the durable reconciliation_need queue (deterministic enumeration from incident knowledge_edge rows), superseding the archived REVISIT walk and splitting the plan into V3.0 (mechanical queue-backed cascade + remove deferred: true) vs V3.1 (agent-grouped resolution).

Refreshes planning/spec artifacts to match this direction: promotes Side-chat V3.0 to the active frontier in memory/PLAN.md, adds V3.1 as horizon work, and updates memory/SPEC.md with a new assumption/invariant and revised Acceptance Criterion #7 to make the patch-list overlay the canonical cascade resolution surface.

Reviewed by Cursor Bugbot for commit 37b0bcd. Bugbot is set up for automated code reviews on this repo. Configure here.

@kostandinang kostandinang requested a review from lunelson May 8, 2026 08:02
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 8, 2026

🤖 Augment PR Summary

Summary: Updates planning/docs to align side-chat V3 hard-edit cascade with the reconciliation_need queue (multi-chat substrate) instead of the archived REVISIT walk.

Changes:

  • Rewrites docs/design/SIDE_CHAT.md §5.3, reframes A71, splits V3 into V3.0 (mechanical grouping) vs V3.1 (agent grouping), and adds a substrate-alignment table.
  • Extends memory/SPEC.md with A84, D139, I112 and revises Acceptance Criterion 7 to route cascade via reconciliation_need + patch list resolution.
  • Reorders memory/PLAN.md to make V3.0 Active, move Continuous workspace to Next, and add V3.1 agent-grouped resolution as Horizon work.

Technical Notes: Documentation/planning-only PR; no src/ changes.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread docs/design/SIDE_CHAT.md Outdated
Comment thread docs/design/SIDE_CHAT.md
@kostandinang kostandinang force-pushed the ka/fe-704-sync-substrate-v2 branch from ee277d0 to 88d2252 Compare May 8, 2026 11:42
@kostandinang kostandinang force-pushed the ka/fe-674-sync-cascade-planning branch from 281d570 to 8d6a188 Compare May 8, 2026 11:44
@graphite-app graphite-app Bot changed the base branch from ka/fe-704-sync-substrate-v2 to graphite-base/110 May 8, 2026 13:28
lunelson
lunelson previously approved these changes May 8, 2026
@kostandinang kostandinang force-pushed the ka/fe-674-sync-cascade-planning branch from 855aba0 to 37b0bcd Compare May 8, 2026 13:32
@github-actions github-actions Bot dismissed lunelson’s stale review May 8, 2026 13:32

Latest approval commit 855aba0 is not an ancestor of 37b0bcd, indicating rewritten history after approval

@graphite-app graphite-app Bot changed the base branch from graphite-base/110 to main May 8, 2026 13:32
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 8, 2026

Merge activity

  • May 8, 1:32 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@kostandinang kostandinang requested a review from lunelson May 8, 2026 13:33
@kostandinang kostandinang added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit c5d6245 May 8, 2026
12 checks passed
@kostandinang kostandinang deleted the ka/fe-674-sync-cascade-planning branch May 8, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants